similar to: Updates to metaflac man

I know Erik is busy with maintenance and wants to get a release out soon. In the meantime, is it appropriate to tag HEAD as 1.2.1_git and include this in the CLI tools (flac, metaflac, etc)? This would make it easier to allow programs in development to test against git flac and older flac versions. For example, sample rates above 48kHz (for ReplayGain) is available in git flac but not 1.2.1.

Jaren Stangret wrote: > Attached is a patch for 'test_grabbag.sh'. Continuing in the same vein as > the other patches, this patch consists of minor reworks of > functions/commands as well as heavily commenting what's going on. > > More than halfway there! Jaren, Any sign of the patches for the rest of these tests? I have some other changes to the tests that I'd

Erik, I was thinking of doing this: export MALLOC_PERTURB_=$(awk 'BEGIN { srand(); print int(rand() * 32767 % 255 + 1) }') Or would you prefer using 'date'? On Tue, Mar 19, 2013 at 10:22 PM, Erik de Castro Lopo <mle+la at mega-nerd.com>wrote: > Jesse Weinstein wrote: > > > The subject line mostly says it all, but for reference, having #!/bin/sh > causes

Seems time is going to be a constraint for me in the coming week, but I'll try and get more of these out to you as fast as I can get them written and tested. Keeping the patches in a separate branch for now seems like a good idea to me. Attached is a patch for 'test_streams.sh' On Tue, Mar 12, 2013 at 1:44 AM, Erik de Castro Lopo <mle+la at mega-nerd.com>wrote: > Jaren

Erik, I don't know what abcde would be providing as tags, or why on Earth it would be importing that from stdin. Unfortunately, abcde is a bash script, and so not exactly easy for me to read. I haven't gotten any response from posting on their mailing list. I do get the same crash when running metaflac without the --import-tags-from, so I'm not sure this is the problem. Unless

I agree on everything you said. I did not intend or expect to have pre-release flac bundled with software, but can understand the dismay at my earlier request. If people think there should be a snapshot version for testing, I'm all for it, especially now that the build system has undergone some changes. I found that for some source distros, the removal of autogen.sh's prior features and

Gentoo bundles flac 1.2.1 with numerous patches applied. Some of these patches are already included in upstream flac-dev (for example the gcc 4.3 cstring issue). Below are the patches supplied by Gentoo (merged against MASTER) and with the Changelog explanations of them as well as the discussion link surrounding the patch: *flac-9999-asm.patch:* *28 Sep 2007; Samuli Suominen <drac at

I mention metaflac because there are a few shell scripts that use it to write RG tags in a flac music library on Linux. With support for Ebu R128 gain in metaflac (the calculation according to specification, not an external program) it would be easy to use, just change the cmd line for metaflac in the script. Now that metaflac supports sample rates higher than 48kHz this would be a good thing in

Erik, The command used by abcde is metaflac --no-utf8-convert --import-cuesheet-from=/home/me/Audio/abcde.50107806/cue-50107806.txt --import-tags-from=- /home/me/Audio/abcde.50107806/track1.flac but I get the same result re-trying without the --no-utf8-convert and -no-utf8-convert. Here's the cuesheet: PERFORMER "William Shakespeare" TITLE "A Midsummer

I'd also like to note that this is happening for me with current HEAD (619b43df36b725e11e12db768d558b1930a583b6). On Mon, Mar 18, 2013 at 11:25 PM, Jaren Stangret <sirjaren at gmail.com> wrote: > I've been trying to get the test suite cleaned up and even with the > original "untouched" test suite via flac 1.3.0pre2, I'm getting a test > suite failure. >

Hi all, I'm currently going through the massive test suite, updating all the scripts making sure they conform to the POSIX standard. I've added a bunch of comments to them and have slightly changed/reworked some of the functions to make it easier to read and process. I'm also eliminating the use of 'echo' in favor of 'printf' since echo has many unspecified uses.

Janne Hyv?rinen wrote: > > On 14.3.2013 9:37, Erik de Castro Lopo wrote: > > Janne Hyv?rinen wrote: > > > >> The patch was made from the published pre2 version. It missed the MinGW > >> changes that were applied to git version. > > Patch applied. Thanks. > > > > Erik > > Unfortunately with this commit the LRN's patch from commit

Jaren Stangret wrote: > Interestingly, I noticed compression level '0' is omitted, so I've added it > in. Thanks. > Also, I tested this on a 24bit/96kHz FLAC file and the test failed between > compression level 0 and compression level 1 -- the file size was greater > with a compression level of 1, rather than 0. The test works on > 'noisy-sine.wav'. It

>The use of R128 also raises the question about "REPLAYGAIN_REFERENCE_LOUDNESS" >tag. Currently flac/metaflac writes "REPLAYGAIN_REFERENCE_LOUDNESS=89.0 dB" >but doesn't use it when decoding (it seems that nothing uses this tag). >R128 defines reference level differently, so this tag makes little sense for >it. IMHO it's better not to write this tag when

Hi has anyone looked at adding R128gain code to metaflac so we can select to use this calculation for RP tags rather than replay gain? Best regards -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.xiph.org/pipermail/flac-dev/attachments/20140615/1c1ca9c9/attachment.htm

Jaren Stangret wrote: > Testing the metadata-handling properties of flac-to-flac encoding... > case00a... Files case00a-expect.meta and out.meta differ > ERROR: metadata does not match expected case00a-expect.meta > make: *** [fullcheck] Error 1 Last night I did a git bisect on this issue and this error arose when I changed the version from "1.2.1" to "1.3.0pre1".

The test is rather simple, and only compares the computed output values for a 1kHz signal at the known filter table sampling frequencies with previously obained golden values. As such, the test only verifies that the performance of the replay gain analyser has not changed. A better test would be to compare the computed value with an independently obtain theorectical value. This is possible by

Erik ? ? Testing FLAC file with unknown metadata... OK ? ? ./test_metaflac.sh: line 450: syntax error near unexpected token `then' ? ? ./test_metaflac.sh: line 450: `? then' Do both /bin/bash and /bin/dash give exactly the same error message ? Earl ________________________________ From: Erik de Castro Lopo <mle+la at mega-nerd.com> To: flac-dev at xiph.org Cc: Earl Chew

Erik, I cannot reproduce the problem you see with either dash(1) or bash(1). > test case62: --import-picture-from... OK > Testing FLAC file with unknown metadata... OK > Testing FLAC replaygain 8000 (8000 x 1) ... OK > Testing FLAC replaygain 11025 (11025 x 1) ... OK > Testing FLAC replaygain 11025 (11025 x 1) ... OK > Testing FLAC replaygain 12000 (12000 x 1) ... OK >

strlen() returns the length excluding the terminating null byte..then an string of len 4 will be off-by-one in application_id[4]; GCC 4.7 detects this bug. --- src/metaflac/options.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/metaflac/options.c b/src/metaflac/options.c index eb3498d..2cb0959 100644 --- a/src/metaflac/options.c +++ b/src/metaflac/options.c @@