similar to: v2.2.28: patches (to use libressl 2.4.5) and test error (strftime)

Timo, re: What OS is this? OS 10.12.3 with Xcode 8.2.1 and the official clang 3.9.0 re: test-time-util.c t_strftime and variants now .......................................... : ok Info: 'Thu, 08 Dec 2016 18:42:16 +0100' test-time-util.c:124: Assert failed: strcmp(t_strftime(RFC2822_FMT, gmtime(&ts)), exp) == 0 Info: 'Thu, 08 Dec 2016 18:42:16 +0100'

On 25 Feb 2017, at 21.11, Ruga <ruga at protonmail.com> wrote: > > t_strftime and variants now .......................................... : ok > > > test-time-util.c:123: Assert failed: strcmp(t_strftime(RFC2822_FMT, gmtime(&ts)), exp) == 0 > > > test-time-util.c:124: Assert failed: strcmp(t_strfgmtime(RFC2822_FMT, ts), exp) == 0 > > > t_strftime

On 25 Feb 2017, at 21.54, Timo Sirainen <tss at iki.fi> wrote: > > Oh, I forgot to remove the #if OPENSSL_VERSION_NUMBER checks from lib-dcrypt. Will be removed in v2.2.29. Attached the planned patch that should do it. Well that didn't work with <v1.1. Maybe this one. -------------- next part -------------- A non-text attachment was scrubbed... Name: openssl.diff Type:

t?st? j?i p?tsi =) Aki On 2017-02-25 22:08, Timo Sirainen wrote: > On 25 Feb 2017, at 21.54, Timo Sirainen <tss at iki.fi> wrote: >> Oh, I forgot to remove the #if OPENSSL_VERSION_NUMBER checks from lib-dcrypt. Will be removed in v2.2.29. Attached the planned patch that should do it. > Well that didn't work with <v1.1. Maybe this one. > > > >

Silly thunderbird, does not understand that "reply to sender" should reply to sender... Aki On 2017-02-25 23:40, Aki Tuomi wrote: > t?st? j?i p?tsi =) > > Aki > > > On 2017-02-25 22:08, Timo Sirainen wrote: >> On 25 Feb 2017, at 21.54, Timo Sirainen <tss at iki.fi> wrote: >>> Oh, I forgot to remove the #if OPENSSL_VERSION_NUMBER checks from

On 5 Feb 2017, at 19.49, Timo Sirainen <tss at iki.fi> wrote: > > On 4 Feb 2017, at 20.03, Ruga <ruga at protonmail.com> wrote: >> >> https://github.com/libressl-portable/portable/issues/278 > > I've no idea why that would happen. The only idea I had got rejected by someone. Oh, that's with OSX. I think that's the reason. Nothing to do with

var-expand.c:687:17: warning: passing an object that undergoes default argument promotion to 'va_start' has undefined behavior [-Wvarargs] va_start(args, key2); ^ var-expand.c:674:58: note: parameter of type 'char' is declared here var_expand_table_build(char key, const char *value, char key2, ...) ^

Standard way to fix it (on the LibreSSL page) is to check for LIBRESSL_VERSION_NUMBER - e.g. the patch attached which I think catches them all where needed. Note the word think. It certainly appears to be working anyway with it. On 11/02/2016 04:07 AM, Aki Tuomi wrote: > After doing some testing by myself, I noticed that libressl, for some > unknown reason, defines > > #define

https://github.com/libressl-portable/portable/issues/278

>openssl version Libressl 2.4.4 Patch for dovecot: perl -i -ple 's/^(#if OPENSSL_VERSION_NUMBER < 0x10100000L\s*)$/$1 || defined (LIBRESSL_VERSION_NUMBER)/' ./src/lib-dcrypt/dcrypt-openssl.c; perl -i -ple 's/^(#if OPENSSL_VERSION_NUMBER < 0x10100000L\s*)$/$1 || defined (LIBRESSL_VERSION_NUMBER)/' ./src/lib-ssl-iostream/dovecot-openssl-common.c; perl -i -ple 's/^(#if

Hi! Those are used if #if OPENSSL_VERSION_NUMBER >= 0x10100000L So (your) libressl is providing this define. We compile our code using GCC and CLANG regularly, with OpenSSL v1.0.x which is the currently officially supported one. Aki On 02.11.2016 12:34, Ruga wrote: > dovecot 2.2.26.0 uses the following functions, which are not available on libressl 2.4.3: > > HMAC_CTX_new >

They have stated they are going to remain API compatible with 1.0.1h (or g, forget which they forked) - their new stuff is outside of libcrypto. On 11/02/2016 04:25 AM, Aki Tuomi wrote: > It does work today, I am just bit worried that it will keep on breaking > with libressl as they evolve their API. I would personally like to avoid > more ifdef hell if possible... > > Aki >

libressl is a leaner and safer openssl Sent from ProtonMail Mobile On Wed, Nov 2, 2016 at 12:39 PM, Michael A. Peters <'mpeters at domblogger.net'> wrote: IMHO it would be acceptable to have a LibreSSL patch that is maintained by the people who want it. It's free software, and that kind of is the point of Open Source. On 11/02/2016 04:36 AM, Michael A. Peters wrote: >

> On 1 Mar 2018, at 5:56 pm, Aki Tuomi <aki.tuomi at dovecot.fi <mailto:aki.tuomi at dovecot.fi>> wrote: > > > > On 01.03.2018 07:34, James Brown wrote: >> On 1 Mar 2018, at 4:09 pm, Aki Tuomi <aki.tuomi at dovecot.fi <mailto:aki.tuomi at dovecot.fi>> wrote: >>> >>> >>> What SSL library and version? >>> ---

Have tried 2.3.0, 2.3.0.1 & 2.2.34. Compile is failing for me. ./configure --with-mysql --with-ssl=openssl: ... checking for SSL_read in -lssl... yes checking openssl/ssl.h usability... yes checking openssl/ssl.h presence... yes checking for openssl/ssl.h... yes checking openssl/err.h usability... yes checking openssl/err.h presence... yes checking for openssl/err.h... yes checking if

On 1 Mar 2018, at 4:09 pm, Aki Tuomi <aki.tuomi at dovecot.fi <mailto:aki.tuomi at dovecot.fi>> wrote: > > >> On 01 March 2018 at 06:21 James Brown < jlbrown at bordo.com.au <mailto:jlbrown at bordo.com.au>> wrote: >> >> >> Have tried 2.3.0, 2.3.0.1 & 2.2.34. >> >> Compile is failing for me. >> >> ./configure

On 08/04/2016 06:50 AM, aki.tuomi at dovecot.fi wrote: > >> On August 4, 2016 at 4:19 PM "Michael A. Peters" <mpeters at domblogger.net> wrote: >> >> >> On 08/04/2016 06:13 AM, Aki Tuomi wrote: >>> >>> >>> On 04.08.2016 16:11, Michael A. Peters wrote: >>>> Operating system - 64 bit CentOS 7 >>>>

On 26.10.2016 13:48, Christian Ehrhardt wrote: > Hi, > I was wondering about a crash when building dovecot 2.2.25 on latest > Ubuntu. > I wondered as I've had the same source building on Debian just fine. > > Some debugging led me to this weird behavior: > Using this gdb command file called autoreportissue in my case: > break dcrypt_initialize > commands >

On 08/04/2016 06:13 AM, Aki Tuomi wrote: > > > On 04.08.2016 16:11, Michael A. Peters wrote: >> Operating system - 64 bit CentOS 7 >> gcc-4.8.5-4.el7.x86_64 >> >> Building against LibreSSL which has been fine for other releases, but >> it is a crypto test that is fails. >> >> Tried with LibreSSL 2.4.2 and 2.3.6 - both the build completes but

Operating system - 64 bit CentOS 7 gcc-4.8.5-4.el7.x86_64 Building against LibreSSL which has been fine for other releases, but it is a crypto test that is fails. Tried with LibreSSL 2.4.2 and 2.3.6 - both the build completes but fails the make check Dovecot 2.2.24 passes make check on both. This is where it fails: Making check in lib-dcrypt make[2]: Entering directory