similar to: TableGen Code owner

LGTM as well. Thanks a lot Paul for the work on TableGen! -- Mehdi On Tue, Nov 10, 2020 at 9:16 AM Eric Christopher via llvm-dev < llvm-dev at lists.llvm.org> wrote: > Nope. :) > > On Mon, Nov 9, 2020 at 9:11 PM Chris Lattner via llvm-dev < > llvm-dev at lists.llvm.org> wrote: > >> I’d like to propose that Paul C. Anagnostopoulos takes on the role as the

Nope. :) On Mon, Nov 9, 2020 at 9:11 PM Chris Lattner via llvm-dev < llvm-dev at lists.llvm.org> wrote: > I’d like to propose that Paul C. Anagnostopoulos takes on the role as the > code owner of TableGen. This is a critical tool in LLVM and Paul has been > doing a great job making across the board upgrades to it. Any concerns? > > -Chris >

+1 TableGen deserves lots of love and Paul did an amazing job there! On Tue, Nov 10, 2020 at 9:43 PM Mehdi AMINI via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > LGTM as well. > > Thanks a lot Paul for the work on TableGen! > > -- > Mehdi > > > On Tue, Nov 10, 2020 at 9:16 AM Eric Christopher via llvm-dev <llvm-dev at lists.llvm.org> wrote: >>

Great, it sounds like consensus. Paul, please update CODE_OWNERS, congratulations and thank you for all the great work! -Chris > On Nov 11, 2020, at 1:15 AM, Anton Korobeynikov via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > +1 > > TableGen deserves lots of love and Paul did an amazing job there! > > On Tue, Nov 10, 2020 at 9:43 PM Mehdi AMINI via llvm-dev

Are all the records collected as they are parsed, with template parameter substitution and lets, and *then*, after all records are collected, a "pass" is made to calculate the inter-field expressions? Once I understand this, I will add a section to the new guide to explain it. I presume it is the case that this behavior should be publicized. It also appears to be the case that a record

On Tue, Oct 13, 2020 at 10:47 AM Madhur Amilkanthwar <madhur13490 at gmail.com> wrote: > What do you guys think about the below enhancements? > > 5. !getdagrestype(dag [, index]) - Returns type of result value. If the DAG computes multiple values then return type of 'index'th result. > > 6. !setdagrestype(dag target_dag, type T [, index]) - Set return type of

Well, I was hinting at LLVM_DEBUG messages. You can pretty much dump all "actions" Tablegen would take to process a .td file, which should suffice, IMO. On Wed, Aug 5, 2020 at 5:59 PM Paul C. Anagnostopoulos <paul at windfall.com> wrote: > Your reply suggests that there is a way to see debug messages from > TableGen. Is that what you meant? If so, can you explain how that

I understood that the name is a matching tag for the operand and not its name (as in named macro or function arguments). However, I was assuming that the names in any one DAG node had to be unique and so could serve as selectors for operands. But a quick investigation shows that I was wrong: names can be duplicated in the same node. So DAG indexes are integers only. At 10/12/2020 01:46 PM,

Hi Paul, If all you care about is debugging then for now we can just emit a few more debug messages which would help to "trace" the flow. To distinguish traces you can prefix it with some known string. I don't think you really need a 'trace' tag in the language spec for this. Debugging Tablegen has always been a nightmare and I don't think we can ever reach a stage where

I'm glad you find it useful. I haven't thought about it being done as part of the build, nor am I any sort of build guru. What do other people think? At 10/7/2020 08:12 AM, Nemanja Ivanovic wrote: >This is really useful. Is there a way to produce this output automatically (by providing some CMake variable)? For example, something like: >-DBUILD_TBLGEN_DEBUG=<Target> >

Thank you for driving this Paul, I agree that it is better to have one doc on TableGen. This has been a point of confusion for me as well - when I land in the wrong one and can’t find what I’m looking for :-). -Chris > On Jul 31, 2020, at 1:49 PM, Paul C. Anagnostopoulos via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > Thanks, David. I have started a new document titled

I certainly agree that there are a boatload of CMake options. I haven't even scratched the surface. In keeping with your suggestion: Is there a way to tell Ninja to build just one target machine? At 10/7/2020 02:58 PM, Nicolai Hähnle wrote: >Hi Paul, > >On Wed, Oct 7, 2020 at 3:33 PM Paul C. Anagnostopoulos via llvm-dev ><llvm-dev at lists.llvm.org> wrote: >>

Yes, I understand the problem. To be more useful, TableGen would have to carry the traces along with the classes and records and (re)display the values while the substitutions are being made. I'm writing a new Programmer's Guide for TableGen and have been digging into the parse-time versus substitution-time issue. I haven't found a document that makes it clear. Can you give a quick

I included the ability to get/set an operand by name because I thought it would be easier to copy+modify an existing DAG by specifying the name of the operand you want to replace rather than having to remember its position. For example, if you want to replace the first source, isn't it easier to specify $src than remember it's the second operand? Perhaps the people actually coding these

Could you expand on this a bit? I see from my build directory that llvm-tblgen.exe was built before the Target/* .inc files. It sounds like you're saying that something has to be built between the .exe and the .inc files. At 8/4/2020 02:44 PM, Chris Lattner wrote: >> On Aug 4, 2020, at 11:31 AM, Paul C. Anagnostopoulos via llvm-dev <llvm-dev at lists.llvm.org> wrote: >>

I was confused by the lack of TableGen backends in the llvm/lib/tablegen directory until I stumbled upon the llvm/utils/tablegen directory. Could someone explain why TableGen is divided into these two directories? ---------------------------------------------------------------- Windfall Paul C. Anagnostopoulos ----------------------------------------------------------

John, I'm pretty much down to details and smoothing the text. Here is a pdf. Can you mark it with comments? Or you can send an email with a list. I will incorporate your comments and send you a second proof, so you can be sure I understood you. Is a week long enough? ~~ Paul At 8/5/2020 02:16 PM, John Byrd wrote: >I'd like to collaborate, if you point me at your tree. Like you,

I'm pondering a new timing feature for TableGen and am wondering whether anyone uses the existing -time-regions option. Some instrumentation for it appears in CodeGenTarget.cpp and GICombinerEmitter.cpp but nowhere else. If no one is using it, I'll be tempted to remove it.

Can you explain how to revert for someone who is a 2 on a git scale of 0 to 10? At 9/22/2020 03:51 PM, Arthur Eubanks wrote: >Yes, push whatever is needed to fix the build if the fix is fairly simple (else revert and get an LGTM with the fix). > >Next time I'd recommend creating and pushing a revert first if you can't quickly figure out the issue.

A question for all you TableGen aficionados: Does anyone know why the collection of RecordVal field values stored in a Record are represented by a SmallVector rather than some sort of map? This means that every time a record field is looked up by name, a linear search is performed. Is it a question of RAM usage?