LGTM as well. Thanks a lot Paul for the work on TableGen! -- Mehdi On Tue, Nov 10, 2020 at 9:16 AM Eric Christopher via llvm-dev < llvm-dev at lists.llvm.org> wrote:> Nope. :) > > On Mon, Nov 9, 2020 at 9:11 PM Chris Lattner via llvm-dev < > llvm-dev at lists.llvm.org> wrote: > >> I’d like to propose that Paul C. Anagnostopoulos takes on the role as the >> code owner of TableGen. This is a critical tool in LLVM and Paul has been >> doing a great job making across the board upgrades to it. Any concerns? >> >> -Chris >> _______________________________________________ >> LLVM Developers mailing list >> llvm-dev at lists.llvm.org >> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >> > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20201110/24334ec7/attachment.html>
+1 TableGen deserves lots of love and Paul did an amazing job there! On Tue, Nov 10, 2020 at 9:43 PM Mehdi AMINI via llvm-dev <llvm-dev at lists.llvm.org> wrote:> > LGTM as well. > > Thanks a lot Paul for the work on TableGen! > > -- > Mehdi > > > On Tue, Nov 10, 2020 at 9:16 AM Eric Christopher via llvm-dev <llvm-dev at lists.llvm.org> wrote: >> >> Nope. :) >> >> On Mon, Nov 9, 2020 at 9:11 PM Chris Lattner via llvm-dev <llvm-dev at lists.llvm.org> wrote: >>> >>> I’d like to propose that Paul C. Anagnostopoulos takes on the role as the code owner of TableGen. This is a critical tool in LLVM and Paul has been doing a great job making across the board upgrades to it. Any concerns? >>> >>> -Chris >>> _______________________________________________ >>> LLVM Developers mailing list >>> llvm-dev at lists.llvm.org >>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >> >> _______________________________________________ >> LLVM Developers mailing list >> llvm-dev at lists.llvm.org >> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev > > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev-- With best regards, Anton Korobeynikov Department of Statistical Modelling, Saint Petersburg State University
Great, it sounds like consensus. Paul, please update CODE_OWNERS, congratulations and thank you for all the great work! -Chris> On Nov 11, 2020, at 1:15 AM, Anton Korobeynikov via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > +1 > > TableGen deserves lots of love and Paul did an amazing job there! > > On Tue, Nov 10, 2020 at 9:43 PM Mehdi AMINI via llvm-dev > <llvm-dev at lists.llvm.org> wrote: >> >> LGTM as well. >> >> Thanks a lot Paul for the work on TableGen! >> >> -- >> Mehdi >> >> >> On Tue, Nov 10, 2020 at 9:16 AM Eric Christopher via llvm-dev <llvm-dev at lists.llvm.org> wrote: >>> >>> Nope. :) >>> >>> On Mon, Nov 9, 2020 at 9:11 PM Chris Lattner via llvm-dev <llvm-dev at lists.llvm.org> wrote: >>>> >>>> I’d like to propose that Paul C. Anagnostopoulos takes on the role as the code owner of TableGen. This is a critical tool in LLVM and Paul has been doing a great job making across the board upgrades to it. Any concerns? >>>> >>>> -Chris >>>> _______________________________________________ >>>> LLVM Developers mailing list >>>> llvm-dev at lists.llvm.org >>>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >>> >>> _______________________________________________ >>> LLVM Developers mailing list >>> llvm-dev at lists.llvm.org >>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >> >> _______________________________________________ >> LLVM Developers mailing list >> llvm-dev at lists.llvm.org >> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev > > > > -- > With best regards, Anton Korobeynikov > Department of Statistical Modelling, Saint Petersburg State University > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev