similar to: [OCaml] Reset of the libvirt-ocaml repository

Hi Daniel, Thanks a lot for providing us your pointers. From the domain.xml(attached in my previous mail) which we have used for defining virtual guest i can see below lines <emulator>/usr/local/bin/qemu-system-x86_64</emulator> We were using same domain.xml in eralier libvirt version and the execution of cpu_stats command was successful. Now if we have to get "cpu_stats"

On Tuesday, 27 November 2018 12:17:52 CET Richard W.M. Jones wrote: > On Tue, Nov 27, 2018 at 11:13:12AM +0000, Daniel P. Berrangé wrote: > > On Tue, Nov 27, 2018 at 11:59:08AM +0100, Pino Toscano wrote: > > > We ship our own copy of it, so we do not need the external version. > > > (Also, the latest upstream version of ocaml-libvirt was already not > > > usable

On Tue, Nov 27, 2018 at 11:13:12AM +0000, Daniel P. Berrangé wrote: > On Tue, Nov 27, 2018 at 11:59:08AM +0100, Pino Toscano wrote: > > We ship our own copy of it, so we do not need the external version. > > (Also, the latest upstream version of ocaml-libvirt was already not > > usable to build the test harness of v2v.) > > This is a significant step backwards from a

On Wednesday, 10 April 2019 15:19:54 CEST Richard W.M. Jones wrote: > I think for 2, we really need a plan, written down, about how and when > we're going to remove the bundled library. It might be included as a > README in the common/mllibvirt/ directory. But it needs to be clear > about when it goes and how we're going to work towards that. Well, I'm not the

On Mon, Dec 16, 2019 at 03:58:29PM +0100, Pino Toscano wrote: > Use the newer copy shipped locally as 3rdparty, instead of the one in > the common submodule, as the latter copy will go away soon. > --- > .gitignore | 2 ++ > Makefile.am | 2 +- > configure.ac | 2 +- > test-harness/Makefile.am | 2 +- > v2v/Makefile.am | 4

On Tue, Nov 27, 2018 at 11:59:08AM +0100, Pino Toscano wrote: > We ship our own copy of it, so we do not need the external version. > (Also, the latest upstream version of ocaml-libvirt was already not > usable to build the test harness of v2v.) This is a significant step backwards from a Fedora packaging POV which expects maintainers to unbundle any 3rd party deps and use the external

On Fri, Mar 03, 2017 at 03:33:02PM +0100, Pino Toscano wrote: > In case there are no event handlers registered with the handle, > get_all_event_callbacks will count 0 elements, trying to malloc a buffer > of that size. POSIX says that this can result in either a null pointer, > or an unusable pointer. Since we assume a null pointer means failure, > then always add a null element

On Wednesday, 19 July 2017 22:25:41 CEST Richard W.M. Jones wrote: > On Wed, Jul 19, 2017 at 03:13:47PM +0200, Pino Toscano wrote: > > On Friday, 14 July 2017 15:39:10 CEST Richard W.M. Jones wrote: > > > .gitignore | 6 +- > > > Makefile.am | 2 +- > > > common/mlutils/Makefile.am | 4 - > > > daemon/Makefile.am

On Tuesday, 12 September 2017 09:03:08 CEST Cédric Bosdonnat wrote: > From: Pino Toscano <ptoscano@redhat.com> > > The C osinfo database parser has been deprecated, reimplement the base > of it in ocaml for virt-builder-repository to use. This provides an > Osinfo.iterate_db() function traversing the files of the osinfo database > and calling a function on each of them.

On Friday, 14 July 2017 15:39:09 CEST Richard W.M. Jones wrote: > Previously the OCaml compiler was only required if building from git > but was at least theoretically optional if building from tarballs > (although this was never tested). Since we want to write parts of the > daemon in OCaml, this makes OCaml required for all builds. > > Note that the ‘--disable-ocaml’ option

On Friday, 21 July 2017 22:36:04 CEST Richard W.M. Jones wrote: > v1 -> v2: > > - [lots of changes] Thanks for them. > Requested, but not done for various reasons: > > - Removing GUESTFSD_EXT_CMD. This is still being used by OpenSUSE, so > we'll have to think of a better mechanism for it. Something like > ‘guestfsd --dump-commands’ may work better. Note I

On Tue, Sep 12, 2017 at 06:41:36PM +0200, Pino Toscano wrote: > On Wednesday, 9 August 2017 19:23:37 CEST Richard W.M. Jones wrote: > > This commit bundles the ocaml-augeas library (upstream here: > > http://git.annexia.org/?p=ocaml-augeas.git;a=summary). It's identical > > to the upstream version and should remain so. > > > > We can work towards using system

On Monday, 31 July 2017 17:40:51 CEST Richard W.M. Jones wrote: > This commit embeds the ocaml-augeas library (upstream here: > http://git.annexia.org/?p=ocaml-augeas.git;a=summary). It's identical > to the upstream version and should remain so. > > We can work towards using system ocaml-augeas, when it's more widely > available. > --- > daemon/Makefile.am |

On Wednesday, 4 October 2017 14:56:23 CEST Richard W.M. Jones wrote: > If you have a struct containing ‘field’, eg: > > type t = { field : int } > > then previously to pattern-match on this type, eg. in function > parameters, you had to write: > > let f { field = field } = > (* ... use field ... *) > > In OCaml >= 3.12 it is possible to abbreviate

On Wed, Jul 19, 2017 at 03:13:47PM +0200, Pino Toscano wrote: > On Friday, 14 July 2017 15:39:10 CEST Richard W.M. Jones wrote: > > .gitignore | 6 +- > > Makefile.am | 2 +- > > common/mlutils/Makefile.am | 4 - > > daemon/Makefile.am | 103 +++++++++++++++++++++++-- > > daemon/chroot.ml | 85

On Wednesday, 9 August 2017 19:23:37 CEST Richard W.M. Jones wrote: > This commit bundles the ocaml-augeas library (upstream here: > http://git.annexia.org/?p=ocaml-augeas.git;a=summary). It's identical > to the upstream version and should remain so. > > We can work towards using system ocaml-augeas, when it's more widely > available. > --- IMHO it would be better

On Tuesday 06 October 2015 16:05:44 Richard W.M. Jones wrote: > These are considerably more efficient than ordinary global roots, but > with the caveat that the program is not allowed to modify them without > calling a special function. We don't modify them, so this change is > safe. > > This requires OCaml >= 3.11, but we have that on RHEL 6 > (since we dropped

On Monday, 17 July 2017 18:55:24 CEST Richard W.M. Jones wrote: > Unlike previous ‘daemon: Reimplement ...’ patches, this does not > reimplement the umount_all API completely (yet, but this > implementation could be completed in future and then replace the C > one). However it is necessary to have a version of umount_all which > we can call from the OCaml inspection code. > ---

This is a simple fix for building also with the upcoming OCaml 4.09, which has a slight API change in the C library. This does not cover embedded copies such as ocaml-augeas, and ocaml-libvirt, which are being fixed separately, and will then be synchronized. Pino Toscano (1): ocaml: make const the return value of caml_named_value() common/mlpcre/pcre-c.c | 2 +- common/mltools/uri-c.c |

On Thursday, 15 June 2017 19:06:00 CEST Richard W.M. Jones wrote: > Create a module ‘C_utils’ containing functions like ‘drive_name’ and > ‘shell_unquote’ which come from the C utilities. > > The new directory ‘common/mlutils’ also contains the ‘Unix_utils’ > wrappers around POSIX functions missing from the OCaml stdlib. > --- I fear we are spreading the code among too many