similar to: [PATCH nbdkit v2 0/3] build: Rename configure --without-linuxdisk -> --disable-linuxdisk

When I was reviewing this I forgot the slightly ridiculous rules that autoconf uses for --enable/disable vs --with/without: https://www.gnu.org/software/autoconf/manual/autoconf-2.66/html_node/Package-Options.html https://www.gnu.org/software/autoconf/manual/autoconf-2.66/html_node/External-Software.html Since this is disabling an intrinsic feature of the software (a plugin) it should use

From: Alan Somers <asomers@gmail.com> There was a missing #include. It only worked on Linux due to header pollution. --- plugins/ssh/ssh.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/plugins/ssh/ssh.c b/plugins/ssh/ssh.c index ea199a93..a4007c40 100644 --- a/plugins/ssh/ssh.c +++ b/plugins/ssh/ssh.c @@ -30,6 +30,8 @@ * SUCH DAMAGE. */ +#include <sys/stat.h> +

From: Alan Somers <asomers@gmail.com> This can be used to disable the linuxdisk plugin, which otherwise is always built if a suitable mke2fs command is present. --- configure.ac | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index f24c3734..c93e822b 100644 --- a/configure.ac +++ b/configure.ac @@ -483,18 +483,25 @@

For v3 I reimplemented this using mke2fs -d. This obviously makes the implementation a whole lot simpler, but cannot support multiple directory merging. Patches 1-3 are the same as before. I've also reproduced the notes from v2 below. v2: - Fix inconsistent tab/space. - All 3 plugins now contain a block of text pointing to the other 2 plugins. - TMDIR -> TMPDIR - Unlink the

Another interesting thing you can do with this plugin: https://rwmj.wordpress.com/2019/02/19/nbdkit-linuxdisk-plugin/ v2: - Fix inconsistent tab/space. - All 3 plugins now contain a block of text pointing to the other 2 plugins. - TMDIR -> TMPDIR - Unlink the temporary file and other cleanups along error paths. - fclose -> pclose, and check the return value for errors. -

Turns out Japanese trains are good for coding! In supermin we have a bunch of code to create the libguestfs appliance. It creates it directly using libext2fs (part of e2fsprogs). We can use the same technique to create ext2 virtual disks in nbdkit, which is what this new plugin does. Why a new plugin instead of modifying the floppy plugin? See the 4/4 commit message for an explanation. The

On Tue, Feb 19, 2019 at 09:21:10AM -0600, Eric Blake wrote: > Missing an unlink(). Also, does the caller properly use close(disk->fd) > on early exits like this, or does it not matter because we're just going > to exit()? Just about the early exits: I started off trying to get those paths right but it made the code ridiculously complicated so I gave up. As you say

I made some stylistic changes to the first two patches so they match existing code, and I pushed them, along with your third patch unmodified. Thanks, Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many powerful

Thanks. I didn't realize that #include <config.h> must always come first. I'm used to the FreeBSD convention, where sys/* comes first. -Alan On Fri, Jun 19, 2020 at 8:29 AM Richard W.M. Jones <rjones@redhat.com> wrote: > I made some stylistic changes to the first two patches so they match > existing code, and I pushed them, along with your third patch > unmodified.

On 2/22/19 3:07 AM, Richard W.M. Jones wrote: > From: "Richard W.M. Jones" <rjones@redhat.com> > > This plugin allows you to create a complete ext2, ext3 or ext4 > filesystem in a GPT partitioned disk image. This can be attached as a > disk to a Linux virtual machine. It is implemented using e2fsprogs > mke2fs ‘-d’ option thus allowing the implementation to be

Unfinished (needs tests). This is my attempt to make a "remote tmpfs" plugin as outlined in this prior email: https://www.redhat.com/archives/libguestfs/2020-March/msg00134.html Although it would be possible to construct something a bit like this using existing plugins and filters (perhaps with some new features in those filters) I think it may be nicer to have a dedicated plugin for

The nbdkit tests take a long time to run especially on armv7. To try to get an idea of which tests take the most time, and since I happen to have a qemu aarch64 *TCG* guest available, I ran the tests on that guest. A TCG guest is about the worst case for libguestfs, used by some tests, since it uses double-nested TCG, and as you can see below there are tests taking over 6 hours. In fact I

On 2/19/19 1:49 AM, Richard W.M. Jones wrote: > From: "Richard W.M. Jones" <rjones@redhat.com> > > This plugin allows you to create a complete ext2 filesystem in a GPT > partitioned disk image. This can be attached as a disk to a Linux > virtual machine. It is implemented using libext2fs (the same as > supermin). > > Although there is some overlap with

v2 was here: https://www.redhat.com/archives/libguestfs/2020-March/msg00154.html v3: - Micro-optimize tmpdir. - Quote $disk in default command shell fragment. - Don't redirect mkfs output to /dev/null. Instead use exec </dev/null >/dev/null before the shell fragment. We may want to do this in other places where we run external shell scripts, or more generally for all

I like this change. I think we were overloading the config_complete method before to do two different things (complete configuration; do any allocation/housekeeping necessary before we can start serving). The only questions in my mind are whether we want this before 1.18, and whether the name ("get_ready") is a good one. Rich.

From: "Richard W.M. Jones" <rjones@redhat.com> This plugin allows you to create a complete ext2, ext3 or ext4 filesystem in a GPT partitioned disk image. This can be attached as a disk to a Linux virtual machine. It is implemented using e2fsprogs mke2fs ‘-d’ option thus allowing the implementation to be very small and simple, with all the hard work done by mke2fs. Although

From: "Richard W.M. Jones" <rjones@redhat.com> This plugin allows you to create a complete ext2 filesystem in a GPT partitioned disk image. This can be attached as a disk to a Linux virtual machine. It is implemented using libext2fs (the same as supermin). Although there is some overlap with nbdkit-iso-plugin and nbdkit-floppy-plugin, the implementations and use cases of all

Question: Should the new directory= parameter of the file plugin be "dir="? It's shorter. It's also consistent with the plugins floppy, iso, linuxdisk, and of course ondemand ... Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to

I will be following up to this email with four separate threads each addressed to the appropriate single list, with proposed changes to: - the NBD protocol - qemu: both server and client - libnbd: client - nbdkit: server The feature in question adds a new optional NBD_INFO_ packet to the NBD_OPT_GO portion of handshake, adding up to 16 bits of information that the server can advertise to the

This is a major rewrite compared to my v1 series, where I've tried a lot harder to ensure that we still accommodate building on Haiku (although I have not actually yet fired up a Haiku VM to try it for myself). I also managed to make the sh plugin fully parallel, on capable platforms. See also my question on patch 10 on whether I've picked the best naming convention. Eric Blake (17):