similar to: [PATCH nbdkit] build: Rename configure --without-linuxdisk -> --disable-linuxdisk

From: Alan Somers <asomers@gmail.com> This can be used to disable the linuxdisk plugin, which otherwise is always built if a suitable mke2fs command is present. --- configure.ac | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index f24c3734..c93e822b 100644 --- a/configure.ac +++ b/configure.ac @@ -483,18 +483,25 @@

This time it should hopefully work. I tested all 3 combinations: autoconf ./configure [--disable-linuxdisk | --enable-linuxdisk | <nothing> ] make clean && make && make check and they all appear to do the right thing. Rich.

From: Alan Somers <asomers@gmail.com> There was a missing #include. It only worked on Linux due to header pollution. --- plugins/ssh/ssh.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/plugins/ssh/ssh.c b/plugins/ssh/ssh.c index ea199a93..a4007c40 100644 --- a/plugins/ssh/ssh.c +++ b/plugins/ssh/ssh.c @@ -30,6 +30,8 @@ * SUCH DAMAGE. */ +#include <sys/stat.h> +

From: "Richard W.M. Jones" <rjones@redhat.com> This plugin allows you to create a complete ext2, ext3 or ext4 filesystem in a GPT partitioned disk image. This can be attached as a disk to a Linux virtual machine. It is implemented using e2fsprogs mke2fs ‘-d’ option thus allowing the implementation to be very small and simple, with all the hard work done by mke2fs. Although

On 2/22/19 3:07 AM, Richard W.M. Jones wrote: > From: "Richard W.M. Jones" <rjones@redhat.com> > > This plugin allows you to create a complete ext2, ext3 or ext4 > filesystem in a GPT partitioned disk image. This can be attached as a > disk to a Linux virtual machine. It is implemented using e2fsprogs > mke2fs ‘-d’ option thus allowing the implementation to be

From: "Richard W.M. Jones" <rjones@redhat.com> This plugin allows you to create a complete ext2 filesystem in a GPT partitioned disk image. This can be attached as a disk to a Linux virtual machine. It is implemented using libext2fs (the same as supermin). Although there is some overlap with nbdkit-iso-plugin and nbdkit-floppy-plugin, the implementations and use cases of all

On 2/19/19 1:49 AM, Richard W.M. Jones wrote: > From: "Richard W.M. Jones" <rjones@redhat.com> > > This plugin allows you to create a complete ext2 filesystem in a GPT > partitioned disk image. This can be attached as a disk to a Linux > virtual machine. It is implemented using libext2fs (the same as > supermin). > > Although there is some overlap with

--- configure.ac | 2 ++ filters/blocksize/Makefile.am | 1 + filters/cache/Makefile.am | 1 + filters/cacheextents/Makefile.am | 1 + filters/cow/Makefile.am | 1 + filters/ddrescue/Makefile.am | 1 + filters/delay/Makefile.am | 3 +++ filters/error/Makefile.am | 1 + filters/exitlast/Makefile.am | 3 +++

On Tue, Feb 19, 2019 at 09:21:10AM -0600, Eric Blake wrote: > Missing an unlink(). Also, does the caller properly use close(disk->fd) > on early exits like this, or does it not matter because we're just going > to exit()? Just about the early exits: I started off trying to get those paths right but it made the code ridiculously complicated so I gave up. As you say

I made some stylistic changes to the first two patches so they match existing code, and I pushed them, along with your third patch unmodified. Thanks, Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many powerful

Thanks. I didn't realize that #include <config.h> must always come first. I'm used to the FreeBSD convention, where sys/* comes first. -Alan On Fri, Jun 19, 2020 at 8:29 AM Richard W.M. Jones <rjones@redhat.com> wrote: > I made some stylistic changes to the first two patches so they match > existing code, and I pushed them, along with your third patch > unmodified.

The NBD protocol is adding an extension to let servers advertise initialization state to the client: whether the image contains holes, and whether it is known to read as all zeroes. For file-based plugins, we are already probing lseek(SEEK_HOLE) to learn if extents are supported; a slight tweak to remember if that result is EOF tells us if we are sparse, and a similar lseek(SEEK_DATA) returning

I pushed a change which should reduce the time taken in the test-cache-* and test-cow.sh tests. Again note this is double TCG which is the worst case for these tests and explains the excessively long times which wouldn't be seen on a normal build system. Updated results: 01:04:18 PASS: test-readahead 01:02:32 PASS: test-cow.sh 00:37:25 PASS: test-floppy.sh 00:34:57 PASS: test-shell 00:34:53

Allow a plugin field to declare whether a parallel plugin can tolerate windows where fds are not CLOEXEC, or must take precautions to avoid leaking fds if the plugin may fork. For safety reasons, the flag defaults to off, but many in-tree plugins can set it to on (most commonly because they don't fork after .config_complete; for libvirt because it is documented to clean up fds on fork so it

The nbdkit tests take a long time to run especially on armv7. To try to get an idea of which tests take the most time, and since I happen to have a qemu aarch64 *TCG* guest available, I ran the tests on that guest. A TCG guest is about the worst case for libguestfs, used by some tests, since it uses double-nested TCG, and as you can see below there are tests taking over 6 hours. In fact I

--- configure.ac | 4 ++-- plugins/nbd/nbd.c | 12 +++++++++--- README | 2 +- 3 files changed, 12 insertions(+), 6 deletions(-) diff --git a/configure.ac b/configure.ac index 8c7ee8b..0ce78c7 100644 --- a/configure.ac +++ b/configure.ac @@ -718,12 +718,12 @@ AC_ARG_WITH([libnbd], [], [with_libnbd=check]) AS_IF([test "$with_libnbd" != "no"],[ -

This can be used for creating temporary disks to thin clients, as a kind of "remote tmpfs". See also: https://www.redhat.com/archives/libguestfs/2020-March/msg00134.html --- plugins/data/nbdkit-data-plugin.pod | 1 + plugins/file/nbdkit-file-plugin.pod | 1 + plugins/linuxdisk/nbdkit-linuxdisk-plugin.pod | 7 +- plugins/memory/nbdkit-memory-plugin.pod |

A fairly straightforward replacement, but note that we must rename all variables called ‘regions’ as something else (eg. ‘rs’) because -Wshadow warns about them (which is surprising to me since I thought this warning only applied to local vs global variable, not local variable vs global typedef). Also I got rid of the get_regions accessor method, replacing it everywhere with direct use of

See the cross-posted cover letter for more details. Eric Blake (10): protocol: Add NBD_INFO_INIT_STATE extension protocol: Wire up backend support for NBD_INFO_INIT_STATE filters: Wire up filter support for NBD_INFO_INIT_STATE plugins: Wire up in-memory plugin support for NBD_INFO_INIT_STATE plugins: Wire up file-based plugin support for NBD_INFO_INIT_STATE plugins: Wire up shell

I spent a bit of my holiday trying to get some more tests working on the Windows port. Unfortunately I hit some unexpected and deep snags. I'm writing down these thoughts before I forget them. nbdkit runs shell scripts from a lot of places. The places which are important for tests are: (a) nbdkit --run 'script'. (b) linuxdisk plugin (used to create tests/disk, so important for