similar to: [PATCH] java: support OpenJDK 10+

This commit starts to split our massive, monolithic configure.ac file into smaller files, using the m4_include mechanism to combine them. I don't know if we should really do this, so I'm open to comments about it. However: - Our configure.ac script is 1800+ lines long, and that's pretty long. - configure.ac lacks structure; splitting it up might improve that. - From what I read,

* Pino Toscano: > @@ -163,6 +161,7 @@ if test "x$with_java" != "xno"; then > AC_SUBST(JAR_INSTALL_DIR) > AC_SUBST(JNI_INSTALL_DIR) > AC_SUBST(JNI_VERSION_INFO) > + AM_CONDITIONAL([HAVE_JAVAH],[test -n "$JAVAH"]) > fi > > AM_CONDITIONAL([HAVE_JAVA],[test "x$with_java" != "xno" && test -n

On Sun, May 06, 2018 at 04:11:36PM +0200, Hilko Bengen wrote: > * Pino Toscano: > > > @@ -163,6 +161,7 @@ if test "x$with_java" != "xno"; then > > AC_SUBST(JAR_INSTALL_DIR) > > AC_SUBST(JNI_INSTALL_DIR) > > AC_SUBST(JNI_VERSION_INFO) > > + AM_CONDITIONAL([HAVE_JAVAH],[test -n "$JAVAH"]) > > fi > >

Two (not related to each other) refactorings: Patches 1-12 split configure.ac into smaller files using the m4_include mechanism. Patches 13-15 split out parts of guestfs.pod (ie. guestfs(3)) into three new manual pages: guestfs-hacking(3) - how to extend and contribute to libguestfs guestfs-internals(3) - architecture and internals guestfs-security(3) - security and CVEs Patch 16 is a

>From Apple's xdr.h: "If your code invokes an xdrproc_t callback, it must be modified to pass a third parameter, which may simply be zero." --- src/proto.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/proto.c b/src/proto.c index 92ae84d..57f4882 100644 --- a/src/proto.c +++ b/src/proto.c @@ -252,7 +252,12 @@ guestfs___send (guestfs_h *g, int proc_nr, *

On Monday 09 February 2015 11:06:17 Margaret Lewicka wrote: > On JDK 8, doclint is enabled by default with strict validation of HTML > tags, which causes the build to fail. See > http://blog.joda.org/2014/02/turning-off-doclint-in-jdk-8-javadoc.html > --- > java/Makefile.am | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/java/Makefile.am

From: Hilko Bengen <bengen at hilluzination.de> --- erlang/Makefile.am | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/erlang/Makefile.am b/erlang/Makefile.am index f336375..2c9e359 100644 --- a/erlang/Makefile.am +++ b/erlang/Makefile.am @@ -32,7 +32,7 @@ erlang_bindir = $(libdir)/erlang/lib/$(PACKAGE_NAME)-$(PACKAGE_VERSION)/ebin erlang_bin_DATA = guestfs.beam

This helps some distros (e.g. Archlinux) where openjdk is installed in java-MAJOR-openjdk directories, without any "default version" symlink. --- configure.ac | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configure.ac b/configure.ac index 1d93ca0..fa26924 100644 --- a/configure.ac +++ b/configure.ac @@ -1251,6 +1251,8 @@ if test "x$with_java" != "xno"; then

Add makefile variables to enable silent rules for simple command invocations, such as ocamlc, ocamlopt, javac, and erlc. This reduces the log output when building with silent rules, still showing the full command lines otherwise. --- erlang/Makefile.am | 2 +- java/Makefile.am | 6 +++--- ocaml/Makefile.am | 14 +++++++------- subdir-rules.mk | 20 +++++++++++++++++--- 4 files changed,

On JDK 8, doclint is enabled by default with strict validation of HTML tags, which causes the build to fail. See http://blog.joda.org/2014/02/turning-off-doclint-in-jdk-8-javadoc.html --- java/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/java/Makefile.am b/java/Makefile.am index fa5b45c..a76a9d1 100644 --- a/java/Makefile.am +++ b/java/Makefile.am @@ -68,7 +68,7

In Gentoo the java alternatives are managed using jva-config (or eselect java), but because the selection is treated as a configuration the symlink to the current jvm selected is stored in /etc, particularly in the symlink /etc/java-config-2/current-system-vm which works such as /usr/lib/jvm/default. Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- m4/guestfs-java.m4 | 1 + 1

Output each path where we attempt to find 'java', so it is easier to spot whether the location for the current OS is missing. This also removes the need to print the location next to the version, since the location was already printed above. --- m4/guestfs_java.m4 | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/m4/guestfs_java.m4 b/m4/guestfs_java.m4 index

I am not a techie and have been struggling 2 days solid to try and install SJava (the source from http://www.omegahat.org/RSJava/). Does anybody have a binary file for me (I am Windows XP and rw2001)? I have tried installing Perl, mingwin and the cygwin tools but still no luck. When I try “R CMD INSTALL c:\SJava_0.78-0.tar.gz” I get the following (and haven’t a clue what it could mean):

I am not a Mac user, but I do use Linux and I would recommend not running R with sudo unless you are an admin ninja. That defensive practice would render the answer to your question moot. It is possible that your problem may have started with inappropriate use of sudo in configuring java, but configuring Java is not on-topic here. -- Sent from my phone. Please excuse my brevity. On March 27,

Hi! I?m on macOS 10.13.3 and just installed the new Java 10 using Homebrew Cask. I also have installed R with Homebrew. Everything seems to work fine, however I just get different outputs if I run sudo R CMD javareconf or R CMD javareconf. With sudo I get pointed to Java 9 and without sudo I get pointed to Java 10. I really don?t know why. Without sudo: $ R CMD javareconf

Add sort of "headers" to split most of the logical sections of the configure, so it is easier to get feedback on the progress of configure. --- configure.ac | 46 ++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 46 insertions(+) diff --git a/configure.ac b/configure.ac index 7f9c1dac0..5ccf6f821 100644 --- a/configure.ac +++ b/configure.ac @@ -76,11 +76,15 @@

Hi Jeff!! I really don?t know if running R CMD javareconf with sudo has posed a problem here, now or in the past. What I know is sometimes it?s the only way to really config it, if I don?t run with sudo, in the end it asks me if I want to overwrite the configuration from root override rw-r--r-- root/admin for /usr/local/Cellar/r/3.4.4/lib/R/etc/Makeconf? (y/n [n]) y override rw-r--r--

I failed to build SJava dure to teh error below. Any ideas? # R CMD INSTALL -c SJava_0.68-0.tar.gz * Installing *source* package 'SJava' ... checking for java... /opt/j2sdk1.4.2_06//bin/java Java VM /opt/j2sdk1.4.2_06//bin/java checking for javah... /opt/j2sdk1.4.2_06//bin/javah Looking in /opt/j2sdk1.4.2_06/include Looking in /opt/j2sdk1.4.2_06/include/linux checking for g++... no

This just fixes 'make'. 'make check' is still broken. Further patches for that to follow tomorrow. Rich.

Sorry if this isn't the correct list, but I couldn't find any mailing lists on the JRI site. I am able to install JRI on a 32 bin linux machine without any problem, but I am unable to isntall on a 64 bit machine. I have R installed with the correct option, R_HOME is set up and libR.so is in there. However, I get the following error when running "./configure", any help is