Libguestfs - Aug 2017 - [PATCH 2/2] configure: output paths where java is searched in

Add sort of "headers" to split most of the logical sections of the
configure, so it is easier to get feedback on the progress of configure.
---
 configure.ac | 46 ++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 46 insertions(+)

diff --git a/configure.ac b/configure.ac
index 7f9c1dac0..5ccf6f821 100644
--- a/configure.ac
+++ b/configure.ac
@@ -76,11 +76,15 @@
AC_DEFINE_UNQUOTED([PACKAGE_VERSION_FULL],["$PACKAGE_VERSION_FULL"],[Full
versio
 AC_SUBST([PACKAGE_VERSION_FULL])
 
 dnl Early gnulib initialization.
+AS_ECHO
+AS_ECHO(["Configuring Gnulib:"])
 gl_EARLY
 gl_INIT
 
 dnl Check for external programs required to either build or run
 dnl libguestfs.
+AS_ECHO
+AS_ECHO(["Checking for external programs:"])
 m4_include([m4/guestfs_progs.m4])
 
 dnl Find the release date for this version.  This is used in
@@ -99,43 +103,83 @@ AS_IF([test "x$RELEASE_DATE" != "x"],[
 AC_SUBST([RELEASE_DATE])
 
 dnl The C compiler environment.
+AS_ECHO
+AS_ECHO(["Checking for the C compiler environment:"])
 m4_include([m4/guestfs_c.m4])
 
 dnl Any C libraries required by the libguestfs C library (not the daemon).
+AS_ECHO
+AS_ECHO(["Checking for libraries used by libguestfs:"])
 m4_include([m4/guestfs_libraries.m4])
 
 dnl Check for FUSE.
+AS_ECHO
+AS_ECHO(["Checking for FUSE:"])
 m4_include([m4/guestfs_fuse.m4])
 
 dnl The daemon and any dependencies.
+AS_ECHO
+AS_ECHO(["Checking the daemon and its dependencies:"])
 m4_include([m4/guestfs_daemon.m4])
 
 dnl The appliance and any dependencies.
+AS_ECHO
+AS_ECHO(["Checking the appliance and its dependencies:"])
 m4_include([m4/guestfs_appliance.m4])
 
 dnl Check for QEMU.
+AS_ECHO
+AS_ECHO(["Checking for QEMU:"])
 m4_include([m4/guestfs_qemu.m4])
 
 dnl Miscellaneous libraries used by other programs.
+AS_ECHO
+AS_ECHO(["Checking for other libraries:"])
 m4_include([m4/guestfs_misc_libraries.m4])
 
 dnl Check for language bindings.
+AS_ECHO
+AS_ECHO(["Checking for OCaml:"])
 m4_include([m4/guestfs_ocaml.m4])
+AS_ECHO
+AS_ECHO(["Checking for Perl:"])
 m4_include([m4/guestfs_perl.m4])
+AS_ECHO
+AS_ECHO(["Checking for Python:"])
 m4_include([m4/guestfs_python.m4])
+AS_ECHO
+AS_ECHO(["Checking for Ruby:"])
 m4_include([m4/guestfs_ruby.m4])
+AS_ECHO
+AS_ECHO(["Checking for Java:"])
 m4_include([m4/guestfs_java.m4])
+AS_ECHO
+AS_ECHO(["Checking for Haskell:"])
 m4_include([m4/guestfs_haskell.m4])
+AS_ECHO
+AS_ECHO(["Checking for PHP:"])
 m4_include([m4/guestfs_php.m4])
+AS_ECHO
+AS_ECHO(["Checking for Erlang:"])
 m4_include([m4/guestfs_erlang.m4])
+AS_ECHO
+AS_ECHO(["Checking for Lua:"])
 m4_include([m4/guestfs_lua.m4])
+AS_ECHO
+AS_ECHO(["Checking for Go:"])
 m4_include([m4/guestfs_golang.m4])
+AS_ECHO
+AS_ECHO(["Checking for GObject Introspection:"])
 m4_include([m4/guestfs_gobject.m4])
 
 dnl Bash completion.
+AS_ECHO
+AS_ECHO(["Checking for bash completion:"])
 m4_include([m4/guestfs_bash_completion.m4])
 
 dnl Miscellaneous configuration that doesn't fit anywhere else.
+AS_ECHO
+AS_ECHO(["Performing additional configuration:"])
 m4_include([m4/guestfs_misc.m4])
 
 dnl Work around autoconf's lack of expanded variables.
@@ -145,6 +189,8 @@ SYSCONFDIR="${my_sysconfdir}"
 AC_SUBST(SYSCONFDIR)
 
 dnl Produce output files.
+AS_ECHO
+AS_ECHO(["Generating output files:"])
 
 AC_CONFIG_HEADERS([config.h])
 
-- 
2.13.4

Output each path where we attempt to find 'java', so it is easier to
spot whether the location for the current OS is missing.  This also
removes the need to print the location next to the version, since the
location was already printed above.
---
 m4/guestfs_java.m4 | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/m4/guestfs_java.m4 b/m4/guestfs_java.m4
index 347cab6da..b86f0c423 100644
--- a/m4/guestfs_java.m4
+++ b/m4/guestfs_java.m4
@@ -50,9 +50,13 @@ if test "x$with_java" != "xno"; then
             /usr/lib/jvm/java-7-openjdk \
             /usr/lib/jvm/java-6-openjdk
         do
+            AC_MSG_CHECKING([for 'java' in $d])
             if test -d $d && test -f $d/bin/java; then
+                AC_MSG_RESULT([found])
                 JAVA=$d
                 break
+            else
+                AC_MSG_RESULT([not found])
             fi
         done
     fi
@@ -85,7 +89,7 @@ if test "x$with_java" != "xno"; then
             JAR="$JAVA/bin/jar"
         fi
         java_version=`$JAVA_EXE -version 2>&1 | $AWK -F '"'
'/^(java|openjdk) version/ {print $2;}'`
-        AC_MSG_RESULT(found $java_version in $JAVA)
+        AC_MSG_RESULT(found $java_version)
 
         dnl Find jni.h.
         AC_MSG_CHECKING([for jni.h])
-- 
2.13.4

Good idea, ACK series.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://people.redhat.com/~rjones/virt-df/