similar to: Re: [PATCH v1 1/2] appliance: search all types of appliances for each path separately

Eric, what do you think of Pavel's analysis and/or suggested fix below? It seems all too plausible to me unfortunately :-( On Fri, May 05, 2017 at 03:46:45PM +0300, Pavel Butsykin wrote: > On 05.05.2017 12:27, Richard W.M. Jones wrote: > > > >Looks good. I'll push this if it passes 'make check && make check-valgrind' > >which I'm currently

Some compilers do not manage to figure out that the members of it are set only when search_appliance() in the end returns 1, which is already checked. Help them a bit by resetting the appliance_files struct on our own, so they will not report that 'appliance.kernel', and the others are used as uninitialized. --- lib/appliance.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

On Tue, Apr 25, 2017 at 02:35:26PM +0300, Pavel Butsykin wrote: > The patch changes the order of the steps to search for fixed/supermin > appliance in accordance with documentation: > > "If the fixed appliance is found, libguestfs skips supermin entirely > and just runs qemu with the kernel, initrd and root disk from the > fixed appliance." Does anyone rely on the

On Fri, Apr 28, 2017 at 05:04:15PM +0300, Pavel Butsykin wrote: > At least two control files (packages and base.tar.gz) are necessary for the > supermin appliance. > > Signed-off-by: Pavel Butsykin <pbutsykin@virtuozzo.com> > --- > lib/appliance.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/lib/appliance.c b/lib/appliance.c >

On Tue, Jun 20, 2017 at 06:48:16PM +0300, Pavel Butsykin wrote: > On 20.06.2017 18:41, Richard W.M. Jones wrote: > >On Tue, Jun 20, 2017 at 06:34:28PM +0300, Pavel Butsykin wrote: > >>On 20.06.2017 17:47, Richard W.M. Jones wrote: > >>>On Tue, Jun 20, 2017 at 05:04:53PM +0300, Pavel Butsykin wrote: > >>>>I noticed that raw is intentionally used as image

On Tue, Jun 20, 2017 at 06:34:28PM +0300, Pavel Butsykin wrote: > On 20.06.2017 17:47, Richard W.M. Jones wrote: > >On Tue, Jun 20, 2017 at 05:04:53PM +0300, Pavel Butsykin wrote: > >>I noticed that raw is intentionally used as image format for appliance > >>image. So I would like to ask, is there any reason to use raw as image > >>format for appliance? >

GCC has two warnings related to large stack frames. We were already using the -Wframe-larger-than warning, but this reduces the threshold from 10000 to 5000 bytes. However that warning only covers the static part of frames (not alloca). So this change also enables -Wstack-usage=10000 which covers both the static and dynamic usage (alloca and variable length arrays). Multiple changes are made

On Tue, Apr 25, 2017 at 03:58:45PM +0300, Pavel Butsykin wrote: > On 25.04.2017 15:11, Richard W.M. Jones wrote: > >On Tue, Apr 25, 2017 at 02:35:26PM +0300, Pavel Butsykin wrote: > >>The patch changes the order of the steps to search for fixed/supermin > >>appliance in accordance with documentation: > >> > >>"If the fixed appliance is found,

On Fri, Apr 28, 2017 at 05:03:58PM +0300, Pavel Butsykin wrote: > On 27.04.2017 18:28, Richard W.M. Jones wrote: > > > >On Thu, Apr 27, 2017 at 03:55:10PM +0300, Pavel Butsykin wrote: > >>The flag determines the behavior of working with the appliance, and specifically > >>the choice to use the build supermin appliance or the fixed appliance. If the >

On Fri, Jun 23, 2017 at 04:12:35PM +0300, Pavel Butsykin wrote: > This feature allows you to use different image formats for the fixed > appliance. The raw format is used by default. > > Signed-off-by: Pavel Butsykin <pbutsykin@virtuozzo.com> > --- > lib/create.c | 5 +++-- > lib/guestfs-internal.h | 2 ++ > lib/launch-direct.c | 2 ++ >

On Fri, Jun 23, 2017 at 04:12:36PM +0300, Pavel Butsykin wrote: > Signed-off-by: Pavel Butsykin <pbutsykin@virtuozzo.com> > --- > m4/guestfs_appliance.m4 | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/m4/guestfs_appliance.m4 b/m4/guestfs_appliance.m4 > index 81c43879f..7e8d28271 100644 > --- a/m4/guestfs_appliance.m4 > +++

On Tue, Jun 27, 2017 at 07:42:20PM +0300, Pavel Butsykin wrote: > This feature allows you to use different image formats for the fixed > appliance. The raw format is used by default. I wonder if you're stil using this feature? Unfortunately because of a recent change in libvirt it is no longer possible to have a backing file where libvirt will autodetect the format. See:

The filesystem_walk command is the appliance's counterpart of the daemon's internal_filesystem_walk command. It writes the daemon's command output on a temporary file and parses it, deserialising the XDR formatted tsk_dirent structs. It returns to the caller the list of tsk_dirent structs generated by the internal_filesystem_walk command. Signed-off-by: Matteo Cafasso <noxdafox

GCC 7.0.1 can determine if there is likely to be sufficient space in the output buffer when using sprintf/snprintf, based on the format string. The errors were all either of this form: bindtests.c:717:29: error: '%zu' directive output may be truncated writing between 1 and 19 bytes into a region of size 16 [-Werror=format-truncation=] snprintf (strs[i], 16, "%zu", i);

GCC 7.0.1 can determine if there is likely to be sufficient space in the output buffer when using sprintf/snprintf, based on the format string. The errors were all either of this form: bindtests.c:717:29: error: '%zu' directive output may be truncated writing between 1 and 19 bytes into a region of size 16 [-Werror=format-truncation=] snprintf (strs[i], 16, "%zu", i);

The filesystem_walk command is the appliance's counterpart of the daemon's internal_filesystem_walk command. It writes the daemon's command output on a temporary file and parses it, deserialising the XDR formatted tsk_dirent structs. It returns to the caller the list of tsk_dirent structs generated by the internal_filesystem_walk command. Signed-off-by: Matteo Cafasso

On Wed, Nov 02, 2016 at 09:50:20PM +0300, Pavel Butsykin wrote: > On 02.11.2016 18:01, Richard W.M. Jones wrote: > >From: Pavel Butsykin <pbutsykin@virtuozzo.com> > > > >This patch improves the search of grub config on EFI partition. This > >means that the config will be found not only for rhel but also for > >many other distributions. Tests were performed

On Fri, Apr 28, 2017 at 05:02:29PM +0300, Pavel Butsykin wrote: > > On 20.04.2017 12:19, Pavel Butsykin wrote: > >[This sender failed our fraud detection checks and may not be who they > >appear to be. Learn about spoofing at http://aka.ms/LearnAboutSpoofing] > > > >20.04.2017 10:54, Richard W.M. Jones пишет: > > > >>On Wed, Apr 19, 2017 at 04:58:56PM

On Thu, May 04, 2017 at 02:21:59PM +0300, Pavel Butsykin wrote: > On 03.05.2017 12:57, Richard W.M. Jones wrote: > >On Tue, May 02, 2017 at 03:35:06PM +0300, Pavel Butsykin wrote: > >>This patch improves the search of grub config on EFI partition. This > >>means that the config will be found not only for rhel but also for > >>many other distributions. Tests

This attempts to implement the idea proposed in https://www.redhat.com/archives/libguestfs/2010-April/msg00087.html The idea is that an externally managed QEMU (manual, or via libvirt) can boot the appliance kernel/initrd. libguestfs can then be just told of the UNIX domain socket associated with the guest daemon. An example based on guestfish. 1. Step one, find the appliance kernel/initrd