Libguestfs - May 2017 - Re: [PATCH] v2v: bootloaders: search grub config for all distributions

On Thu, May 04, 2017 at 02:21:59PM +0300, Pavel Butsykin
wrote:
> On 03.05.2017 12:57, Richard W.M. Jones wrote:
> >On Tue, May 02, 2017 at 03:35:06PM +0300, Pavel Butsykin wrote:
> >>This patch improves the search of grub config on EFI partition.
This
> >>means that the config will be found not only for rhel but also for
> >>many other distributions.  Tests were performed on the following
> >>distributions: centos, fedora, ubuntu, suse. In all cases, the
config
> >>path was /boot/efi/EFI/*distname*/grub.cfg
> >>
> >>The main purpose of the patch is to improve support for converting
of
> >>vm with UEFI for most distributions. Unfortunately this patch does
not
> >>solve the problem for all distributions, for example Debian does
not
> >>store grub config on the EFI partition, therefore for such
> >>distributions another solution is necessary.
> >>
> >>Signed-off-by: Pavel Butsykin <pbutsykin@virtuozzo.com>
> >
> >Thanks - this is pushed.
> >
> >Sorry it took a bit of time, I had to run all of the virt-v2v non-free
> >test cases to convince myself there were no corner cases that might
> >regress.  They passed fine.
> 
> Thank you for the extra check, it's always helpful!
> 
> What are "non-free test cases" ? Is it something in addition to
> " v2v]# make check && make check-slow" ?
Unfortunately they are non-free (and hence not (re-)distributable), as
the name suggests.  However you can look at the framework here:

  http://git.annexia.org/?p=virt-v2v-test-cases-nonfree.git;a=summary

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top