similar to: [PATCH] v2v: Support loading virtio-win drivers from virtio-win.iso (RHBZ#1234351).

This makes several changes to the handling of virtio-win drivers: The VIRTIO_WIN_DIR environment variable has been renamed VIRTIO_WIN (but you can still use the old name). You can point the VIRTIO_WIN either at a RHEL virtio-win directory (ie. /usr/share/virtio-win), OR at a loopback-mounted virtio-win ISO, OR at the virtio-win.iso file itself. In the latter case, libguestfs is used to open the

Refactor copying of virtio windows drivers into the guest so that the matching of the drivers to the guest os flavor and copying the files happens one next to the other in a single function, and no guestfs handle (nor any other irrelevant info) is leaked outside. Signed-off-by: Roman Kagan <rkagan@virtuozzo.com> --- v2v/convert_windows.ml | 77 ++++++++++------- v2v/utils.ml |

Refactor copying of virtio windows drivers into the guest so that the matching of the drivers to the guest os flavor and copying the files happens one next to the other in a single function, and no guestfs handle (nor any other irrelevant info) is leaked outside. Signed-off-by: Roman Kagan <rkagan@virtuozzo.com> --- changes since v1: - former patch #3 - updated usage of string functions

In version 2: - Add a bunch of debugging output. - Recognize Windows Vista, Windows 10. - Compare driver paths case-insensitively.

Libguestfs supports passing an ISO image as a source of virtio windows drivers to v2v. That support, however, looks too heavy-weight: in order to access those drivers, a separate guestfs handle is created (and thus a new emulator process is started), which runs until v2v completes. This series attempts to make it simpler and lighter-weight, by making the relevant code more local, and by

Libguestfs supports passing an ISO image as a source of virtio windows drivers to v2v. This series attempts to make it simpler and better scoped. Roman Kagan (3): v2v: consolidate virtio-win file copying v2v: copy virtio drivers without guestfs handle leak v2v: drop useless forced gc --- changes since v2: - drop patch 4 (reuse of the master guestfs handle for hot-adding the ISO image)

Copy the appropriate driver files from the virtio-win storage into %SYSTEMROOT%\Drivers\VirtIO once they are discovered, and stick to using those copies later on. This way the knowledge of where the drivers come from originally is consolidated in one place, so the lifetime of the associated entities becomes easier to control (to be implemented in followup patches). Signed-off-by: Roman Kagan

Copy the appropriate driver files from the virtio-win storage into %SYSTEMROOT%\Drivers\VirtIO once they are discovered, and stick to using those copies later on. This way the knowledge of where the drivers come from originally is consolidated in one place, so the lifetime of the associated entities becomes easier to control (to be implemented in followup patches). Signed-off-by: Roman Kagan

On 22.06.15 15:33, Richard W.M. Jones wrote: > This makes several changes to the handling of virtio-win drivers: > > The VIRTIO_WIN_DIR environment variable has been renamed > VIRTIO_WIN (but you can still use the old name). > > You can point the VIRTIO_WIN either at a RHEL virtio-win directory > (ie. /usr/share/virtio-win), OR at a loopback-mounted virtio-win ISO, > OR

On 23.06.15 09:04, Richard W.M. Jones wrote: > On Tue, Jun 23, 2015 at 09:18:01AM +0300, Shahar Havivi wrote: > > On 22.06.15 15:33, Richard W.M. Jones wrote: > > > This makes several changes to the handling of virtio-win drivers: > > > > > > The VIRTIO_WIN_DIR environment variable has been renamed > > > VIRTIO_WIN (but you can still use the old name).

On Tue, Jun 23, 2015 at 09:18:01AM +0300, Shahar Havivi wrote: > On 22.06.15 15:33, Richard W.M. Jones wrote: > > This makes several changes to the handling of virtio-win drivers: > > > > The VIRTIO_WIN_DIR environment variable has been renamed > > VIRTIO_WIN (but you can still use the old name). > > > > You can point the VIRTIO_WIN either at a RHEL

Now that all the stuff related to Windows virtio drivers has been moved into a dedicated module, it makes sense to move the definition of virtio_win there, too, and stop passing it around as a parameter. Signed-off-by: Roman Kagan <rkagan@virtuozzo.com> --- v2v/convert_windows.ml | 9 +-------- v2v/windows_virtio.ml | 13 ++++++++++--- v2v/windows_virtio.mli | 2 +- 3 files changed, 12

Instead of trying to split and parse elements from virtio-win paths, use the '*.inf' files supplied with the drivers to control how Windows drivers are installed. The following emails best explain how this works: https://www.redhat.com/archives/libguestfs/2015-October/msg00352.html https://www.redhat.com/archives/libguestfs/2015-November/msg00065.html Currently the product variant (eg.

Give the caller certain control over what kind of interface to use for virtual disks, network and video cards upon conversion. For that, make convert functions accept additional rcaps parameter containing an object with optional capabilities similar to the ones produced on output, with None indicating that the decision is left to the convert function itself. To facilicate review, this patch

Give the caller certain control over what kind of interface to use for virtual disks, network and video cards upon conversion. For that, make convert functions accept additional rcaps parameter containing an object with optional capabilities similar to the ones produced on output, with None indicating that the decision is left to the convert function itself. To facilicate review, this patch

On Tue, Feb 09, 2016 at 05:53:57PM +0300, Roman Kagan wrote: > diff --git a/v2v/windows_virtio.ml b/v2v/windows_virtio.ml > index bdce038..8e0430c 100644 > --- a/v2v/windows_virtio.ml > +++ b/v2v/windows_virtio.ml > @@ -33,57 +33,105 @@ let virtio_win = > with Not_found -> > Guestfs_config.datadir // "virtio-win" > > -let rec install_drivers g

On Tue, Feb 09, 2016 at 07:02:06PM +0000, Richard W.M. Jones wrote: > On Tue, Feb 09, 2016 at 05:53:57PM +0300, Roman Kagan wrote: > > diff --git a/v2v/windows_virtio.ml b/v2v/windows_virtio.ml > > index bdce038..8e0430c 100644 > > --- a/v2v/windows_virtio.ml > > +++ b/v2v/windows_virtio.ml > > @@ -33,57 +33,105 @@ let virtio_win = > > with Not_found

This is just a straight refactoring. Various ad hoc string_* functions that appeared in Common_utils have been renamed and placed in the String.* namespace. The old vs "new" functions are: string_prefix -> String.is_prefix string_suffix -> String.is_suffix string_find -> String.find replace_str -> String.replace string_nsplit -> String.nsplit string_split

Support virtio drivers for Windows Server 2016 once they are available. Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com> --- v2v/windows_virtio.ml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/v2v/windows_virtio.ml b/v2v/windows_virtio.ml index 354aa19..334e347 100644 --- a/v2v/windows_virtio.ml +++ b/v2v/windows_virtio.ml @@ -330,6 +330,8 @@ and

Make the location of the Windows virtio drivers overridable with the environment variable VIRTIO_WIN_DIR, in the same vein as is done for virt-tools. Signed-off-by: Roman Kagan <rkagan@parallels.com> --- changes from v1: - document the new environment variable v2v/convert_windows.ml | 4 +++- v2v/virt-v2v.pod | 10 ++++++++-- 2 files changed, 11 insertions(+), 3 deletions(-) diff