similar to: [PATCH 0/2] p2v: Warn if vcpus or memory would be larger than supported by RHEL (RHBZ#823758).

On Tuesday 05 May 2015 15:13:16 Richard W.M. Jones wrote: > No functional change, just code refactoring. > --- > p2v/gui.c | 42 ++++++++++++++++++++++++++++++------------ > 1 file changed, 30 insertions(+), 12 deletions(-) > > diff --git a/p2v/gui.c b/p2v/gui.c > index 7e9de0d..bc762c2 100644 > --- a/p2v/gui.c > +++ b/p2v/gui.c > @@ -375,6 +375,8 @@ static void

Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1792141 Let the user pass "-oo" options from the kernel cmdline and from the GUI to virt-v2v. This is primarily useful with the OpenStack output mode, so reenable that mode. Cc: Alban Lecorps <alban.lecorps at ubisoft.com> Laszlo Alban Lecorps (1): Introduce "p2v.output.misc" for passing "-oo" options

No functional change, just code refactoring. --- p2v/gui.c | 42 ++++++++++++++++++++++++++++++------------ 1 file changed, 30 insertions(+), 12 deletions(-) diff --git a/p2v/gui.c b/p2v/gui.c index 7e9de0d..bc762c2 100644 --- a/p2v/gui.c +++ b/p2v/gui.c @@ -375,6 +375,8 @@ static void set_interfaces_from_ui (struct config *); static void conversion_back_clicked (GtkWidget *w, gpointer data);

Set mnemonics for all the labels with a text entry or combo box next to them, and for all the buttons, and check boxes. --- p2v/gui.c | 56 ++++++++++++++++++++++++++++++++++---------------------- 1 file changed, 34 insertions(+), 22 deletions(-) diff --git a/p2v/gui.c b/p2v/gui.c index 36bb655..dee8b83 100644 --- a/p2v/gui.c +++ b/p2v/gui.c @@ -285,13 +285,14 @@ create_connection_dialog (struct

This version of the Gtk 2/3 patch gets alignment and padding mostly right. I still can't work out how to vertically align labels in the middle of a cell in a GtkGrid. The GtkTextView in the final dialog is still broken. Rich.

... and a small initial patch which makes it easier to test virt-p2v without having to start up a virtual machine. There is still a bug in Gtk 3 where the GtkTextView on the final (running) dialog ignores gtk_widget_set_size_request and so the window appears just a single pixel high. Rich.

This is basically the same as what I posted earlier today. The main difference is I split out the GDK thread sychronization (removal of) changes from the other Gtk 2/3 changes, which should make it a bit easier to review. Gtk 3 is still not quite perfect. Apart from the problem with the GtkTextView noted before, there are also vertical alignment and padding problems with labels in GtkGrid

Now that virt-p2v has its own repository [1] and releases [2], it is time to remove it from libguestfs. [1] https://github.com/libguestfs/virt-p2v [2] http://download.libguestfs.org/virt-p2v/ Pino Toscano (2): Remove virt-p2v Remove remaining virt-p2v bits .gitignore | 4 - Makefile.am | 7 +- bash/Makefile.am

Currently virt-p2v requires Gtk 2. This commit changes virt-p2v so it can be built with either Gtk 2 or 3. By careful use of macros, this code should compile on both recent Gtk 2 and Gtk 3. With no other options, ./configure will now prefer Gtk 3 if it finds it, or fall back to Gtk 2. But you can control this by setting './configure --with-gtk=2|3|check|no' where the options mean: *

Accoding to its documentation [1], it takes as second parameter a PangoWrapMode and not a GtkWrapMode. While the change should reflect the actual value intended, it should slightly change the label wrap mode: GTK_WRAP_WORD is 2, which corresponds (as int value) to PANGO_WRAP_WORD_CHAR. [1] https://developer.gnome.org/gtk2/stable/GtkLabel.html#gtk-label-set-line-wrap-mode --- p2v/gui.c | 2 +- 1

These are a prelude to fixing https://bugzilla.redhat.com/show_bug.cgi?id=1590220 A lot of the virt-p2v configuration code was duplicated manually. These changes make sure that most of it is generated. Rich.

This patchset provides updates to the viewer in preperation for its fedora submission. Included are patches cmd-line parameterizing hostname/user/pass/vm, the addition of a man page, cleanup of the project's structure, and updates to the spec.

On Mon, Jan 30, 2023 at 03:22:26PM +0100, Laszlo Ersek wrote: > + str = gtk_entry_get_text (GTK_ENTRY (oo_entry)); > + guestfs_int_free_string_list (config->output.misc); > + config->output.misc = guestfs_int_split_string (',', str); My concern here is that someone is going to put "foo=bar, baz=1" in this field, and it will improperly split above. So maybe a

run on startup by default like the other ovirt services --- conf/ovirt-vnc-proxy | 49 ++++++++ installer/modules/ovirt/manifests/ovirt.pp | 1 + ovirt-server.spec.in | 5 + src/vnc-proxy/vnc-proxy.rb | 167 ++++++++++++++++++++++++++++ 4 files changed, 222 insertions(+), 0 deletions(-) create mode 100755 conf/ovirt-vnc-proxy

A mixed bag, but all the patches make sense together! Patch 1: Fix a bug that Tingting found: https://bugzilla.redhat.com/show_bug.cgi?id=1256222 Patch 2: Revert a patch that makes no sense now that we've added virt-v2v into base RHEL. This is just included because it's a cleanup needed before applying patch 3. Patch 3: Add the ability to use SSH identities (private keys) for virt-p2v

Fixes https://bugzilla.redhat.com/1256222

Wherever we had code which did: if (something_bad) { perror (...); exit (EXIT_FAILURE); } replace this with use of the error(3) function: if (something_bad) error (EXIT_FAILURE, errno, ...); The error(3) function is supplied by glibc, or by gnulib on platforms which don't have it, and is much more flexible than perror(3). Since we already use error(3), there seems to be

I'm pleased to announce libguestfs 1.30, a library and set of tools for accessing and modifying virtual machine disk images. This release took 9 months of work by a considerable number of people, and has many new features (see release notes below). You can get libguestfs 1.30 here: Main website: http://libguestfs.org/ Source: http://libguestfs.org/download/1.30-stable/

Like with the previous commit, this replaces instances of: if (something_bad) { fprintf (stderr, "%s: error message\n", guestfs_int_program_name); exit (EXIT_FAILURE); } with: if (something_bad) error (EXIT_FAILURE, 0, "error message"); (except in a few cases were errno was incorrectly being ignored, in which case I have fixed that). It's slightly

libguestfs has used double and triple underscores in identifiers. These aren't valid for global names in C++. (http://stackoverflow.com/a/228797) These large but completely mechanical patches change the illegal identifiers to legal ones. Rich.