Pino Toscano
2015-Oct-05 14:10 UTC
[Libguestfs] [PATCH] p2v: fix mode for gtk_label_set_line_wrap_mode
Accoding to its documentation [1], it takes as second parameter a
PangoWrapMode and not a GtkWrapMode. While the change should reflect
the actual value intended, it should slightly change the label wrap
mode: GTK_WRAP_WORD is 2, which corresponds (as int value) to
PANGO_WRAP_WORD_CHAR.
[1]
https://developer.gnome.org/gtk2/stable/GtkLabel.html#gtk-label-set-line-wrap-mode
---
p2v/gui.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/p2v/gui.c b/p2v/gui.c
index fa8a7b0..8c6dc31 100644
--- a/p2v/gui.c
+++ b/p2v/gui.c
@@ -525,7 +525,7 @@ create_conversion_dialog (struct config *config)
target_warning_label = gtk_label_new ("");
gtk_label_set_line_wrap (GTK_LABEL (target_warning_label), TRUE);
gtk_label_set_line_wrap_mode (GTK_LABEL (target_warning_label),
- GTK_WRAP_WORD);
+ PANGO_WRAP_WORD);
gtk_widget_set_size_request (target_warning_label, -1, 7 * 16);
gtk_box_pack_end (GTK_BOX (target_vbox), target_warning_label, TRUE, TRUE,
0);
--
2.1.0
Reasonably Related Threads
- [PATCH 0/2] p2v: Warn if vcpus or memory would be larger than supported by RHEL (RHBZ#823758).
- [PATCH v2 3/3] p2v: Allow virt-p2v to be built with Gtk 2 or 3.
- [p2v PATCH 00/11] Expose virt-v2v's "-oo"; re-enable openstack
- [PATCH] p2v: add mnemonics to labels and buttons (RHBZ#1379289)
- [PATCH 0/2] Remove virt-p2v from libguestfs
