similar to: [PATCH v2 8/8] dma-buf: use krealloc_array()

On Tue, Nov 3, 2020 at 12:13 PM Bartosz Golaszewski <brgl at bgdev.pl> wrote: > On Tue, Nov 3, 2020 at 5:14 AM Joe Perches <joe at perches.com> wrote: > > On Mon, 2020-11-02 at 16:20 +0100, Bartosz Golaszewski wrote: > > > From: Bartosz Golaszewski <bgolaszewski at baylibre.com> > Yeah so I had this concern for devm_krealloc() and even sent a patch > that

On Mon, 2020-11-02 at 16:20 +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bgolaszewski at baylibre.com> > > Andy brought to my attention the fact that users allocating an array of > equally sized elements should check if the size multiplication doesn't > overflow. This is why we have helpers like kmalloc_array(). > > However we don't have

On Mon, Nov 02, 2020 at 04:20:30PM +0100, Bartosz Golaszewski wrote: > +Chunks allocated with `kmalloc` can be resized with `krealloc`. Similarly > +to `kmalloc_array`: a helper for resising arrays is provided in the form of > +`krealloc_array`. Is there any reason you chose to `do_this` instead of do_this()? The automarkup script turns do_this() into a nice link to the documentation

On Mon, Jul 03, 2017 at 03:05:30PM +0300, Andy Shevchenko wrote: > On Fri, 2017-06-09 at 15:07 +0300, Andy Shevchenko wrote: > > Use sysfs_match_string() helper instead of open coded variant. > > Did I miss maintainer? > > > > > Cc: "Michael S. Tsirkin" <mst at redhat.com> > > Cc: Jason Wang <jasowang at redhat.com> > >

On Mon, Jul 03, 2017 at 03:05:30PM +0300, Andy Shevchenko wrote: > On Fri, 2017-06-09 at 15:07 +0300, Andy Shevchenko wrote: > > Use sysfs_match_string() helper instead of open coded variant. > > Did I miss maintainer? > > > > > Cc: "Michael S. Tsirkin" <mst at redhat.com> > > Cc: Jason Wang <jasowang at redhat.com> > >

I don't think the root cause of those warnings are introduced by virtio-crypto driver. What's your opinion? Sam and David? Thanks, -Gonglei > -----Original Message----- > From: kbuild test robot [mailto:lkp at intel.com] > Sent: Sunday, December 04, 2016 10:40 AM > Subject: Re: [PATCH v5 1/1] crypto: add virtio-crypto driver > > Hi Gonglei, > > [auto build

Hi Gonglei, [auto build test ERROR on cryptodev/master] [also build test ERROR on v4.9-rc7 next-20161202] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Gonglei/crypto-add-virtio-crypto-driver/20161202-190424 base: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master

Hi Gonglei, [auto build test ERROR on cryptodev/master] [also build test ERROR on v4.9-rc7 next-20161202] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Gonglei/crypto-add-virtio-crypto-driver/20161202-190424 base: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master

On Fri, 2017-06-09 at 15:07 +0300, Andy Shevchenko wrote: > Use sysfs_match_string() helper instead of open coded variant. Did I miss maintainer? > > Cc: "Michael S. Tsirkin" <mst at redhat.com> > Cc: Jason Wang <jasowang at redhat.com> > Signed-off-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com> > --- > ?drivers/block/virtio_blk.c | 7

Use sysfs_match_string() helper instead of open coded variant. Cc: "Michael S. Tsirkin" <mst at redhat.com> Cc: Jason Wang <jasowang at redhat.com> Signed-off-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com> --- drivers/block/virtio_blk.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/block/virtio_blk.c

Use sysfs_match_string() helper instead of open coded variant. Cc: "Michael S. Tsirkin" <mst at redhat.com> Cc: Jason Wang <jasowang at redhat.com> Signed-off-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com> --- drivers/block/virtio_blk.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/block/virtio_blk.c

On Fri, 2017-05-05 at 10:06 +0300, Amir Goldstein wrote: > On Fri, May 5, 2017 at 9:20 AM, Dan Williams <dan.j.williams at intel.com > > wrote: > > On Thu, May 4, 2017 at 2:21 AM, Andy Shevchenko > > <andriy.shevchenko at linux.intel.com> wrote: > > >         for (i = 0; i < NFIT_UUID_MAX; i++) > > > -               if (memcmp(to_nfit_uuid(i),

On Thu, May 4, 2017 at 2:21 AM, Andy Shevchenko <andriy.shevchenko at linux.intel.com> wrote: > acpi_evaluate_dsm() and friends take a pointer to a raw buffer of 16 > bytes. Instead we convert them to use uuid_le type. At the same time we > convert current users. > > acpi_str_to_uuid() becomes useless after the conversion and it's safe to > get rid of it. > > The

On Fri, May 5, 2017 at 9:20 AM, Dan Williams <dan.j.williams at intel.com> wrote: > On Thu, May 4, 2017 at 2:21 AM, Andy Shevchenko > <andriy.shevchenko at linux.intel.com> wrote: >> acpi_evaluate_dsm() and friends take a pointer to a raw buffer of 16 >> bytes. Instead we convert them to use uuid_le type. At the same time we >> convert current users. >>

On Mon, 2017-07-03 at 19:37 +0300, Michael S. Tsirkin wrote: > On Mon, Jul 03, 2017 at 03:05:30PM +0300, Andy Shevchenko wrote: > > On Fri, 2017-06-09 at 15:07 +0300, Andy Shevchenko wrote: > > > Use sysfs_match_string() helper instead of open coded variant. > > > > Did I miss maintainer? > > > You didn't, I'll merge this in the next PULL. I

On Thu, May 04, 2017 at 12:21:51PM +0300, Andy Shevchenko wrote: > acpi_evaluate_dsm() and friends take a pointer to a raw buffer of 16 > bytes. Instead we convert them to use uuid_le type. At the same time we > convert current users. > > acpi_str_to_uuid() becomes useless after the conversion and it's safe to > get rid of it. > > The conversion fixes a potential bug

On Wed, Apr 22, 2020 at 4:52 PM Dejin Zheng <zhengdejin5 at gmail.com> wrote: > > On Tue, Apr 21, 2020 at 08:24:24PM +0300, Andy Shevchenko wrote: > > On Tue, Apr 21, 2020 at 7:45 PM Dejin Zheng <zhengdejin5 at gmail.com> wrote: > > > > > > It forgot to call bochs_hw_fini() to release related resources when > > > bochs_pci_probe() fail. eg: io

On Thu, 04 May 2017, Andy Shevchenko <andriy.shevchenko at linux.intel.com> wrote: > diff --git a/drivers/gpu/drm/i915/intel_acpi.c b/drivers/gpu/drm/i915/intel_acpi.c > index eb638a1e69d2..72bfe6ceadf8 100644 > --- a/drivers/gpu/drm/i915/intel_acpi.c > +++ b/drivers/gpu/drm/i915/intel_acpi.c > @@ -15,13 +15,9 @@ static struct intel_dsm_priv { > acpi_handle dhandle; >

On Fri, May 5, 2017 at 12:24 PM, Andy Shevchenko <andriy.shevchenko at linux.intel.com> wrote: > On Fri, 2017-05-05 at 10:06 +0300, Amir Goldstein wrote: [...] >> I think with this semantic change, our proposals can reach common >> grounds >> and satisfy a wider group of users (i.e. filesystem developers). >> >> Christoph also suggested a similar treatment to

On Wed, Jul 26, 2017 at 4:53 PM, Arnd Bergmann <arnd at arndb.de> wrote: > randconfig builds occasionally produce this Kconfig warning: > > warning: (DRM_RADEON && DRM_AMDGPU && DRM_NOUVEAU && DRM_I915 && DRM_GMA500 && DRM_SHMOBILE && DRM_TILCDC && DRM_FSL_DCU && DRM_TINYDRM && DRM_PARADE_PS8622 &&