thr3ads.net - Linux Virtualization - [PATCH v5 1/1] crypto: add virtio-crypto driver [Dec 2016]

If this information is useful, please help other people find it:
Share via:

kbuild test robot

2016-Dec-04 02:39 UTC

[PATCH v5 1/1] crypto: add virtio-crypto driver

Hi Gonglei,

[auto build test ERROR on cryptodev/master]
[also build test ERROR on v4.9-rc7 next-20161202]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]

url:   
https://github.com/0day-ci/linux/commits/Gonglei/crypto-add-virtio-crypto-driver/20161202-190424
base:  
https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
config: sparc64-allyesconfig (attached as .config)
compiler: sparc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        wget
https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross
-O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=sparc64 

All errors (new ones prefixed by >>):

   In file included from arch/sparc/include/asm/topology.h:4:0,
                    from include/linux/topology.h:35,
                    from include/linux/gfp.h:8,
                    from include/linux/kmod.h:22,
                    from include/linux/module.h:13,
                    from drivers/crypto/virtio/virtio_crypto_mgr.c:21:
   drivers/crypto/virtio/virtio_crypto_common.h: In function
'virtio_crypto_get_current_node':>> arch/sparc/include/asm/topology_64.h:44:44: error: implicit declaration
of function 'cpu_data' [-Werror=implicit-function-declaration]    #define topology_physical_package_id(cpu) (cpu_data(cpu).proc_id)
                                               ^
   drivers/crypto/virtio/virtio_crypto_common.h:116:9: note: in expansion of
macro 'topology_physical_package_id'
     return topology_physical_package_id(smp_processor_id());
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~>> arch/sparc/include/asm/topology_64.h:44:57: error: request for member
'proc_id' in something not a structure or union    #define topology_physical_package_id(cpu) (cpu_data(cpu).proc_id)
                                                            ^
   drivers/crypto/virtio/virtio_crypto_common.h:116:9: note: in expansion of
macro 'topology_physical_package_id'
     return topology_physical_package_id(smp_processor_id());
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/cpu_data +44 arch/sparc/include/asm/topology_64.h

f5e706ad include/asm-sparc/topology_64.h      Sam Ravnborg        2008-07-17  28
9d079337 arch/sparc/include/asm/topology_64.h David Miller        2009-01-11  29
#define cpumask_of_pcibus(bus)	\
9d079337 arch/sparc/include/asm/topology_64.h David Miller        2009-01-11  30
(pcibus_to_node(bus) == -1 ? \
e9b37512 arch/sparc/include/asm/topology_64.h Rusty Russell       2009-03-16  31
cpu_all_mask : \
9d079337 arch/sparc/include/asm/topology_64.h David Miller        2009-01-11  32
cpumask_of_node(pcibus_to_node(bus)))
f5e706ad include/asm-sparc/topology_64.h      Sam Ravnborg        2008-07-17  33
52708d69 arch/sparc/include/asm/topology_64.h Nitin Gupta         2015-11-02  34
int __node_distance(int, int);
52708d69 arch/sparc/include/asm/topology_64.h Nitin Gupta         2015-11-02  35
#define node_distance(a, b) __node_distance(a, b)
52708d69 arch/sparc/include/asm/topology_64.h Nitin Gupta         2015-11-02  36
f5e706ad include/asm-sparc/topology_64.h      Sam Ravnborg        2008-07-17  37
#else /* CONFIG_NUMA */
f5e706ad include/asm-sparc/topology_64.h      Sam Ravnborg        2008-07-17  38
f5e706ad include/asm-sparc/topology_64.h      Sam Ravnborg        2008-07-17  39
#include <asm-generic/topology.h>
f5e706ad include/asm-sparc/topology_64.h      Sam Ravnborg        2008-07-17  40
f5e706ad include/asm-sparc/topology_64.h      Sam Ravnborg        2008-07-17  41
#endif /* !(CONFIG_NUMA) */
f5e706ad include/asm-sparc/topology_64.h      Sam Ravnborg        2008-07-17  42
f5e706ad include/asm-sparc/topology_64.h      Sam Ravnborg        2008-07-17  43
#ifdef CONFIG_SMP
f5e706ad include/asm-sparc/topology_64.h      Sam Ravnborg        2008-07-17 @44
#define topology_physical_package_id(cpu)	(cpu_data(cpu).proc_id)
f5e706ad include/asm-sparc/topology_64.h      Sam Ravnborg        2008-07-17  45
#define topology_core_id(cpu)			(cpu_data(cpu).core_id)
acc455cf arch/sparc/include/asm/topology_64.h chris hyser         2015-04-22  46
#define topology_core_cpumask(cpu)		(&cpu_core_sib_map[cpu])
06931e62 arch/sparc/include/asm/topology_64.h Bartosz Golaszewski 2015-05-26  47
#define topology_sibling_cpumask(cpu)		(&per_cpu(cpu_sibling_map, cpu))
f5e706ad include/asm-sparc/topology_64.h      Sam Ravnborg        2008-07-17  48
#endif /* CONFIG_SMP */
f5e706ad include/asm-sparc/topology_64.h      Sam Ravnborg        2008-07-17  49
3905c54f arch/sparc/include/asm/topology_64.h Stephen Rothwell    2011-04-12  50
extern cpumask_t cpu_core_map[NR_CPUS];
acc455cf arch/sparc/include/asm/topology_64.h chris hyser         2015-04-22  51
extern cpumask_t cpu_core_sib_map[NR_CPUS];
3905c54f arch/sparc/include/asm/topology_64.h Stephen Rothwell    2011-04-12  52
static inline const struct cpumask *cpu_coregroup_mask(int cpu)

:::::: The code at line 44 was first introduced by commit
:::::: f5e706ad886b6a5eb59637830110b09ccebf01c5 sparc: join the remaining header
files

:::::: TO: Sam Ravnborg <sam at ravnborg.org>
:::::: CC: David S. Miller <davem at davemloft.net>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 47988 bytes
Desc: not available
URL:
<http://lists.linuxfoundation.org/pipermail/virtualization/attachments/20161204/42276357/attachment-0001.bin>

Gonglei (Arei)

2016-Dec-05 03:12 UTC

head link

[PATCH v5 1/1] crypto: add virtio-crypto driver

I don't think the root cause of those warnings are introduced by
virtio-crypto driver.

What's your opinion? Sam and David?

Thanks,
-Gonglei

> -----Original Message-----
> From: kbuild test robot [mailto:lkp at intel.com]
> Sent: Sunday, December 04, 2016 10:40 AM
> Subject: Re: [PATCH v5 1/1] crypto: add virtio-crypto driver
> 
> Hi Gonglei,
> 
> [auto build test ERROR on cryptodev/master]
> [also build test ERROR on v4.9-rc7 next-20161202]
> [if your patch is applied to the wrong git tree, please drop us a note to
help
> improve the system]
> 
> url:
>
https://github.com/0day-ci/linux/commits/Gonglei/crypto-add-virtio-crypto-dri
> ver/20161202-190424
> base:
> https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git
> master
> config: sparc64-allyesconfig (attached as .config)
> compiler: sparc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
> reproduce:
>         wget
>
https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cr
> oss -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # save the attached .config to linux build tree
>         make.cross ARCH=sparc64
> 
> All errors (new ones prefixed by >>):
> 
>    In file included from arch/sparc/include/asm/topology.h:4:0,
>                     from include/linux/topology.h:35,
>                     from include/linux/gfp.h:8,
>                     from include/linux/kmod.h:22,
>                     from include/linux/module.h:13,
>                     from drivers/crypto/virtio/virtio_crypto_mgr.c:21:
>    drivers/crypto/virtio/virtio_crypto_common.h: In function
> 'virtio_crypto_get_current_node':
> >> arch/sparc/include/asm/topology_64.h:44:44: error: implicit
declaration of
> function 'cpu_data' [-Werror=implicit-function-declaration]
>     #define topology_physical_package_id(cpu) (cpu_data(cpu).proc_id)
>                                                ^
>    drivers/crypto/virtio/virtio_crypto_common.h:116:9: note: in expansion
of
> macro 'topology_physical_package_id'
>      return topology_physical_package_id(smp_processor_id());
>             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >> arch/sparc/include/asm/topology_64.h:44:57: error: request for
member
> 'proc_id' in something not a structure or union
>     #define topology_physical_package_id(cpu) (cpu_data(cpu).proc_id)
>                                                             ^
>    drivers/crypto/virtio/virtio_crypto_common.h:116:9: note: in expansion
of
> macro 'topology_physical_package_id'
>      return topology_physical_package_id(smp_processor_id());
>             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    cc1: some warnings being treated as errors
> 
> vim +/cpu_data +44 arch/sparc/include/asm/topology_64.h
> 
> f5e706ad include/asm-sparc/topology_64.h      Sam Ravnborg
> 2008-07-17  28
> 9d079337 arch/sparc/include/asm/topology_64.h David Miller
> 2009-01-11  29  #define cpumask_of_pcibus(bus)	\
> 9d079337 arch/sparc/include/asm/topology_64.h David Miller
> 2009-01-11  30  	(pcibus_to_node(bus) == -1 ? \
> e9b37512 arch/sparc/include/asm/topology_64.h Rusty Russell
> 2009-03-16  31  	 cpu_all_mask : \
> 9d079337 arch/sparc/include/asm/topology_64.h David Miller
> 2009-01-11  32  	 cpumask_of_node(pcibus_to_node(bus)))
> f5e706ad include/asm-sparc/topology_64.h      Sam Ravnborg
> 2008-07-17  33
> 52708d69 arch/sparc/include/asm/topology_64.h Nitin Gupta
> 2015-11-02  34  int __node_distance(int, int);
> 52708d69 arch/sparc/include/asm/topology_64.h Nitin Gupta
> 2015-11-02  35  #define node_distance(a, b) __node_distance(a, b)
> 52708d69 arch/sparc/include/asm/topology_64.h Nitin Gupta
> 2015-11-02  36
> f5e706ad include/asm-sparc/topology_64.h      Sam Ravnborg
> 2008-07-17  37  #else /* CONFIG_NUMA */
> f5e706ad include/asm-sparc/topology_64.h      Sam Ravnborg
> 2008-07-17  38
> f5e706ad include/asm-sparc/topology_64.h      Sam Ravnborg
> 2008-07-17  39  #include <asm-generic/topology.h>
> f5e706ad include/asm-sparc/topology_64.h      Sam Ravnborg
> 2008-07-17  40
> f5e706ad include/asm-sparc/topology_64.h      Sam Ravnborg
> 2008-07-17  41  #endif /* !(CONFIG_NUMA) */
> f5e706ad include/asm-sparc/topology_64.h      Sam Ravnborg
> 2008-07-17  42
> f5e706ad include/asm-sparc/topology_64.h      Sam Ravnborg
> 2008-07-17  43  #ifdef CONFIG_SMP
> f5e706ad include/asm-sparc/topology_64.h      Sam Ravnborg
> 2008-07-17 @44  #define topology_physical_package_id(cpu)
> 	(cpu_data(cpu).proc_id)
> f5e706ad include/asm-sparc/topology_64.h      Sam Ravnborg
> 2008-07-17  45  #define topology_core_id(cpu)
> 	(cpu_data(cpu).core_id)
> acc455cf arch/sparc/include/asm/topology_64.h chris hyser
> 2015-04-22  46  #define topology_core_cpumask(cpu)
> 	(&cpu_core_sib_map[cpu])
> 06931e62 arch/sparc/include/asm/topology_64.h Bartosz Golaszewski
> 2015-05-26  47  #define topology_sibling_cpumask(cpu)
> 	(&per_cpu(cpu_sibling_map, cpu))
> f5e706ad include/asm-sparc/topology_64.h      Sam Ravnborg
> 2008-07-17  48  #endif /* CONFIG_SMP */
> f5e706ad include/asm-sparc/topology_64.h      Sam Ravnborg
> 2008-07-17  49
> 3905c54f arch/sparc/include/asm/topology_64.h Stephen Rothwell
> 2011-04-12  50  extern cpumask_t cpu_core_map[NR_CPUS];
> acc455cf arch/sparc/include/asm/topology_64.h chris hyser
> 2015-04-22  51  extern cpumask_t cpu_core_sib_map[NR_CPUS];
> 3905c54f arch/sparc/include/asm/topology_64.h Stephen Rothwell
> 2011-04-12  52  static inline const struct cpumask *cpu_coregroup_mask(int
> cpu)
> 
> :::::: The code at line 44 was first introduced by commit
> :::::: f5e706ad886b6a5eb59637830110b09ccebf01c5 sparc: join the remaining
> header files
> 
> :::::: TO: Sam Ravnborg <sam at ravnborg.org>
> :::::: CC: David S. Miller <davem at davemloft.net>
> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology
> Center
> https://lists.01.org/pipermail/kbuild-all                   Intel
> Corporation

Sam Ravnborg

2016-Dec-07 20:20 UTC

head link

[PATCH v5 1/1] crypto: add virtio-crypto driver

On Mon, Dec 05, 2016 at 03:12:52AM +0000, Gonglei (Arei)
wrote:> I don't think the root cause of those warnings are introduced by
virtio-crypto driver.
> 
> What's your opinion? Sam and David?
Root cause here is that arch/sparc/include/asm/topology_64.h
references cpu_data without including arch/sparc/include/asm/cpudata.h

I think other architectures pull in the dependency from
either smp.h or they have it topology.h.

The easy fix would be to include cpudata.h in
arch/sparc/include/asm/topology_64.h.
And that should also be a correct fix.

Could you include this in your patch-set and build test it?

	Sam

Possibly Parallel Threads

Search for more reasonably related threads

Linux Virtualization - Dec 2016 - [PATCH v5 1/1] crypto: add virtio-crypto driver

[PATCH v5 1/1] crypto: add virtio-crypto driver

[PATCH v5 1/1] crypto: add virtio-crypto driver

[PATCH v5 1/1] crypto: add virtio-crypto driver

Possibly Parallel Threads