similar to: [PATCH 04/17] vhost: prep vhost_dev_init users to handle failures

Hi Mike, url: https://github.com/0day-ci/linux/commits/Mike-Christie/vhost-fix-scsi-cmd-handling-and-cgroup-support/20201022-083844 base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next config: i386-randconfig-m021-20201101 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel

vDPA device currently relays the eventfd via vhost worker. This is inefficient due the latency of wakeup and scheduling, so this patch tries to introduce a use_worker attribute for the vhost device. When use_worker is not set with vhost_dev_init(), vhost won't try to allocate a worker thread and the vhost_poll will be processed directly in the wakeup function. This help for vDPA since it

On 2020/9/24 ??3:12, Mike Christie wrote: > On 9/21/20 9:02 PM, Jason Wang wrote: >> On 2020/9/22 ??2:23, Mike Christie wrote: >>> This adds a helper check if a vq has been setup. The next patches >>> will use this when we move the vhost scsi cmd preallocation from per >>> session to per vq. In the per vq case, we only want to allocate cmds >>> for vqs

On 2020/9/22 ??2:23, Mike Christie wrote: > We must free the vqs array in the open failure path, because > vhost_vdpa_release will not be called. > > Signed-off-by: Mike Christie <michael.christie at oracle.com> > --- > drivers/vhost/vdpa.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c > index

On 2020/10/30 ??4:47, Michael S. Tsirkin wrote: > On Tue, Oct 27, 2020 at 12:47:34AM -0500, Mike Christie wrote: >> On 10/25/20 10:51 PM, Jason Wang wrote: >>> On 2020/10/22 ??8:34, Mike Christie wrote: >>>> Each vhost-scsi device will need a evt and ctl queue, but the number >>>> of IO queues depends on whatever the user has configured in userspace.

On 2020/9/22 ??2:23, Mike Christie wrote: > vhost_work_flush doesn't do anything with the work arg. This patch drops > it and then renames vhost_work_flush to vhost_work_dev_flush to reflect > that the function flushes all the works in the dev and not just a > specific queue or work item. > > Signed-off-by: Mike Christie <michael.christie at oracle.com> Acked-by:

We used to have vhost_exceeds_weight() for vhost-net to: - prevent vhost kthread from hogging the cpu - balance the time spent between TX and RX This function could be useful for vsock and scsi as well. So move it to vhost.c. Device must specify a weight which counts the number of requests, or it can also specific a byte_weight which counts the number of bytes that has been processed.

Note: dropped some commits at the last moment, I did verify we get the same code in the end as what was in linux next for a while now. The following changes since commit 6995e2de6891c724bfeb2db33d7b87775f913ad1: Linux 6.4 (2023-06-25 16:29:58 -0700) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus for you to fetch changes

On Tue, Feb 04, 2020 at 11:30:11AM +0800, Jason Wang wrote: > On 2020/1/31 ??11:36, Tiwei Bie wrote: > > This patch introduces a vDPA based vhost backend. This > > backend is built on top of the same interface defined > > in virtio-vDPA and provides a generic vhost interface > > for userspace to accelerate the virtio devices in guest. > > > > This backend is

On 19.05.23 14:15, Christian Brauner wrote: > On Thu, May 18, 2023 at 10:25:11AM +0200, Christian Brauner wrote: >> On Wed, May 17, 2023 at 07:09:12PM -0500, Mike Christie wrote: >>> This patch allows the vhost and vhost_task code to use CLONE_THREAD, >>> CLONE_SIGHAND and CLONE_FILES. It's a RFC because I didn't do all the >>> normal testing,

On 2020/9/22 ??2:23, Mike Christie wrote: > This adds a helper check if a vq has been setup. The next patches > will use this when we move the vhost scsi cmd preallocation from per > session to per vq. In the per vq case, we only want to allocate cmds > for vqs that have actually been setup and not for all the possible > vqs. > > Signed-off-by: Mike Christie

On 2020/9/24 ??3:48, Eli Cohen wrote: > On Thu, Sep 24, 2020 at 11:21:03AM +0800, Jason Wang wrote: >> We need to free vqs during the err path after it has been allocated >> since vhost won't do that for us. >> >> Signed-off-by: Jason Wang <jasowang at redhat.com> >> --- >> drivers/vhost/vdpa.c | 11 ++++++++--- >> 1 file changed, 8

On Wed, Apr 01, 2020 at 10:13:29PM +0800, Jason Wang wrote: > > On 2020/4/1 ??9:02, Christian Borntraeger wrote: > > > > On 01.04.20 14:56, Christian Borntraeger wrote: > > > On 01.04.20 14:50, Jason Wang wrote: > > > > On 2020/4/1 ??7:21, Christian Borntraeger wrote: > > > > > On 26.03.20 15:01, Jason Wang wrote: > > > > >

On Wed, Apr 01, 2020 at 10:50:50PM +0800, Jason Wang wrote: > > On 2020/4/1 ??10:27, Michael S. Tsirkin wrote: > > On Wed, Apr 01, 2020 at 10:13:29PM +0800, Jason Wang wrote: > > > On 2020/4/1 ??9:02, Christian Borntraeger wrote: > > > > On 01.04.20 14:56, Christian Borntraeger wrote: > > > > > On 01.04.20 14:50, Jason Wang wrote: > > >

On 6/1/23 5:47 AM, Christian Brauner wrote: > On Thu, Jun 01, 2023 at 09:58:38AM +0200, Thorsten Leemhuis wrote: >> On 19.05.23 14:15, Christian Brauner wrote: >>> On Thu, May 18, 2023 at 10:25:11AM +0200, Christian Brauner wrote: >>>> On Wed, May 17, 2023 at 07:09:12PM -0500, Mike Christie wrote: >>>>> This patch allows the vhost and vhost_task code to

On 01.06.23 12:47, Christian Brauner wrote: > On Thu, Jun 01, 2023 at 09:58:38AM +0200, Thorsten Leemhuis wrote: >> On 19.05.23 14:15, Christian Brauner wrote: >>> On Thu, May 18, 2023 at 10:25:11AM +0200, Christian Brauner wrote: >>>> On Wed, May 17, 2023 at 07:09:12PM -0500, Mike Christie wrote: >>>>> This patch allows the vhost and vhost_task code to

On Mon, Jun 05, 2023 at 01:57:30PM -0500, Mike Christie wrote: >If userspace does VHOST_VSOCK_SET_GUEST_CID before VHOST_SET_OWNER we >can race where: >1. thread0 calls vhost_transport_send_pkt -> vhost_work_queue >2. thread1 does VHOST_SET_OWNER which calls vhost_worker_create. >3. vhost_worker_create will set the dev->worker pointer before setting >the worker->vtsk

The following changes since commit 8f3d9f354286745c751374f5f1fcafee6b3f3136: Linux 5.7-rc1 (2020-04-12 12:35:55 -0700) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus for you to fetch changes up to d085eb8ce727e581abf8145244eaa3339021be2f: vhost: disable for OABI (2020-04-20 10:19:22 -0400) Changes from v1: Dropped a

If userspace does VHOST_VSOCK_SET_GUEST_CID before VHOST_SET_OWNER we can race where: 1. thread0 calls vhost_transport_send_pkt -> vhost_work_queue 2. thread1 does VHOST_SET_OWNER which calls vhost_worker_create. 3. vhost_worker_create will set the dev->worker pointer before setting the worker->vtsk pointer. 4. thread0's vhost_work_queue will see the dev->worker pointer is set and

If userspace does VHOST_VSOCK_SET_GUEST_CID before VHOST_SET_OWNER we can race where: 1. thread0 calls vhost_transport_send_pkt -> vhost_work_queue 2. thread1 does VHOST_SET_OWNER which calls vhost_worker_create. 3. vhost_worker_create will set the dev->worker pointer before setting the worker->vtsk pointer. 4. thread0's vhost_work_queue will see the dev->worker pointer is set and