similar to: [PATCH 1/2] virtio-net: don't disable guest csum when disable LRO

On Mon, Sep 28, 2020 at 11:39:15AM +0800, xiangxia.m.yue at gmail.com wrote: > From: Tonghao Zhang <xiangxia.m.yue at gmail.com> > > Allow user configuring RXCSUM separately with ethtool -K, > reusing the existing virtnet_set_guest_offloads helper > that configures RXCSUM for XDP. This is conditional on > VIRTIO_NET_F_CTRL_GUEST_OFFLOADS. > > Cc: Michael S. Tsirkin

On Mon, Sep 28, 2020 at 11:39:15AM +0800, xiangxia.m.yue at gmail.com wrote: > From: Tonghao Zhang <xiangxia.m.yue at gmail.com> > > Allow user configuring RXCSUM separately with ethtool -K, > reusing the existing virtnet_set_guest_offloads helper > that configures RXCSUM for XDP. This is conditional on > VIRTIO_NET_F_CTRL_GUEST_OFFLOADS. > > Cc: Michael S. Tsirkin

On Tue, Sep 29, 2020 at 09:45:24AM +0800, Tonghao Zhang wrote: > On Tue, Sep 29, 2020 at 3:25 AM Michael S. Tsirkin <mst at redhat.com> wrote: > > > > On Mon, Sep 28, 2020 at 11:39:15AM +0800, xiangxia.m.yue at gmail.com wrote: > > > From: Tonghao Zhang <xiangxia.m.yue at gmail.com> > > > > > > Allow user configuring RXCSUM separately with

On Tue, Sep 29, 2020 at 09:45:24AM +0800, Tonghao Zhang wrote: > On Tue, Sep 29, 2020 at 3:25 AM Michael S. Tsirkin <mst at redhat.com> wrote: > > > > On Mon, Sep 28, 2020 at 11:39:15AM +0800, xiangxia.m.yue at gmail.com wrote: > > > From: Tonghao Zhang <xiangxia.m.yue at gmail.com> > > > > > > Allow user configuring RXCSUM separately with

On Tue, Sep 29, 2020 at 02:10:56PM +0800, Tonghao Zhang wrote: > On Tue, Sep 29, 2020 at 1:55 PM Michael S. Tsirkin <mst at redhat.com> wrote: > > > > On Tue, Sep 29, 2020 at 09:45:24AM +0800, Tonghao Zhang wrote: > > > On Tue, Sep 29, 2020 at 3:25 AM Michael S. Tsirkin <mst at redhat.com> wrote: > > > > > > > > On Mon, Sep 28, 2020 at

On Tue, Sep 29, 2020 at 02:10:56PM +0800, Tonghao Zhang wrote: > On Tue, Sep 29, 2020 at 1:55 PM Michael S. Tsirkin <mst at redhat.com> wrote: > > > > On Tue, Sep 29, 2020 at 09:45:24AM +0800, Tonghao Zhang wrote: > > > On Tue, Sep 29, 2020 at 3:25 AM Michael S. Tsirkin <mst at redhat.com> wrote: > > > > > > > > On Mon, Sep 28, 2020 at

On Mon, Sep 28, 2020 at 5:42 AM <xiangxia.m.yue at gmail.com> wrote: > > From: Tonghao Zhang <xiangxia.m.yue at gmail.com> > > Allow user configuring RXCSUM separately with ethtool -K, > reusing the existing virtnet_set_guest_offloads helper > that configures RXCSUM for XDP. This is conditional on > VIRTIO_NET_F_CTRL_GUEST_OFFLOADS. > > Cc: Michael S. Tsirkin

From: Tonghao Zhang <xiangxia.m.yue at gmail.com> Open vSwitch and Linux bridge will disable LRO of the interface when this interface added to them. Now when disable the LRO, the virtio-net csum is disable too. That drops the forwarding performance. Fixes: a02e8964eaf9 ("virtio-net: ethtool configurable LRO") Cc: Michael S. Tsirkin <mst at redhat.com> Cc: Jason Wang

From: Tonghao Zhang <xiangxia.m.yue at gmail.com> Open vSwitch and Linux bridge will disable LRO of the interface when this interface added to them. Now when disable the LRO, the virtio-net csum is disable too. That drops the forwarding performance. Fixes: a02e8964eaf9 ("virtio-net: ethtool configurable LRO") Cc: Michael S. Tsirkin <mst at redhat.com> Cc: Jason Wang

On Tue, Sep 29, 2020 at 3:21 AM Michael S. Tsirkin <mst at redhat.com> wrote: > > On Mon, Sep 28, 2020 at 11:39:14AM +0800, xiangxia.m.yue at gmail.com wrote: > > From: Tonghao Zhang <xiangxia.m.yue at gmail.com> > > > > Open vSwitch and Linux bridge will disable LRO of the interface > > when this interface added to them. Now when disable the LRO, the >

On Tue, Sep 29, 2020 at 3:21 AM Michael S. Tsirkin <mst at redhat.com> wrote: > > On Mon, Sep 28, 2020 at 11:39:14AM +0800, xiangxia.m.yue at gmail.com wrote: > > From: Tonghao Zhang <xiangxia.m.yue at gmail.com> > > > > Open vSwitch and Linux bridge will disable LRO of the interface > > when this interface added to them. Now when disable the LRO, the >

On Tue, Sep 29, 2020 at 2:23 PM Michael S. Tsirkin <mst at redhat.com> wrote: > > On Tue, Sep 29, 2020 at 09:58:06AM +0800, xiangxia.m.yue at gmail.com wrote: > > From: Tonghao Zhang <xiangxia.m.yue at gmail.com> > > > > Open vSwitch and Linux bridge will disable LRO of the interface > > when this interface added to them. Now when disable the LRO, the >

On Tue, Sep 29, 2020 at 2:23 PM Michael S. Tsirkin <mst at redhat.com> wrote: > > On Tue, Sep 29, 2020 at 09:58:06AM +0800, xiangxia.m.yue at gmail.com wrote: > > From: Tonghao Zhang <xiangxia.m.yue at gmail.com> > > > > Open vSwitch and Linux bridge will disable LRO of the interface > > when this interface added to them. Now when disable the LRO, the >

On Tue, Sep 29, 2020 at 9:23 AM Michael S. Tsirkin <mst at redhat.com> wrote: > > On Tue, Sep 29, 2020 at 02:59:03PM +0800, Tonghao Zhang wrote: > > On Tue, Sep 29, 2020 at 2:23 PM Michael S. Tsirkin <mst at redhat.com> wrote: > > > > > > On Tue, Sep 29, 2020 at 09:58:06AM +0800, xiangxia.m.yue at gmail.com wrote: > > > > From: Tonghao Zhang

On Tue, Sep 29, 2020 at 3:32 PM Willem de Bruijn <willemdebruijn.kernel at gmail.com> wrote: > > On Tue, Sep 29, 2020 at 4:00 AM <xiangxia.m.yue at gmail.com> wrote: > > > > From: Tonghao Zhang <xiangxia.m.yue at gmail.com> > > > > Open vSwitch and Linux bridge will disable LRO of the interface > > when this interface added to them. Now when

On Tue, Sep 29, 2020 at 2:22 PM Michael S. Tsirkin <mst at redhat.com> wrote: > > On Tue, Sep 29, 2020 at 02:10:56PM +0800, Tonghao Zhang wrote: > > On Tue, Sep 29, 2020 at 1:55 PM Michael S. Tsirkin <mst at redhat.com> wrote: > > > > > > On Tue, Sep 29, 2020 at 09:45:24AM +0800, Tonghao Zhang wrote: > > > > On Tue, Sep 29, 2020 at 3:25 AM

On Tue, Sep 29, 2020 at 1:55 PM Michael S. Tsirkin <mst at redhat.com> wrote: > > On Tue, Sep 29, 2020 at 09:45:24AM +0800, Tonghao Zhang wrote: > > On Tue, Sep 29, 2020 at 3:25 AM Michael S. Tsirkin <mst at redhat.com> wrote: > > > > > > On Mon, Sep 28, 2020 at 11:39:15AM +0800, xiangxia.m.yue at gmail.com wrote: > > > > From: Tonghao Zhang

On Tue, Sep 29, 2020 at 3:25 AM Michael S. Tsirkin <mst at redhat.com> wrote: > > On Mon, Sep 28, 2020 at 11:39:15AM +0800, xiangxia.m.yue at gmail.com wrote: > > From: Tonghao Zhang <xiangxia.m.yue at gmail.com> > > > > Allow user configuring RXCSUM separately with ethtool -K, > > reusing the existing virtnet_set_guest_offloads helper > > that

From: Tonghao Zhang <xiangxia.m.yue at gmail.com> Allow user configuring RXCSUM separately with ethtool -K, reusing the existing virtnet_set_guest_offloads helper that configures RXCSUM for XDP. This is conditional on VIRTIO_NET_F_CTRL_GUEST_OFFLOADS. Cc: Michael S. Tsirkin <mst at redhat.com> Cc: Jason Wang <jasowang at redhat.com> Signed-off-by: Tonghao Zhang

00fffe0ff0 DR7: 0000000000000400 > > Call Trace: > > ? preempt_count_add+0x58/0xb0 > > ? _raw_spin_lock_irqsave+0x36/0x70 > > ? _raw_spin_unlock_irqrestore+0x1a/0x40 > > ? __wake_up+0x70/0x190 > > virtnet_set_features+0x90/0xf0 [virtio_net] > > __netdev_update_features+0x271/0x980 > > ? nlmsg_notify+0x5b/0xa0 > >