similar to: [PATCH] crypto: virtio - don't use 'default m'

On Wed, Nov 29, 2017 at 09:41:18AM +0100, Corentin Labbe wrote: > The crypto engine could actually only enqueue hash and ablkcipher request. > This patch permit it to enqueue any type of crypto_async_request. > > Signed-off-by: Corentin Labbe <clabbe.montjoie at gmail.com> This is going the wrong way. We do not want to expose any of the base types such as crypto_alg,

On Wed, Nov 29, 2017 at 09:41:18AM +0100, Corentin Labbe wrote: > The crypto engine could actually only enqueue hash and ablkcipher request. > This patch permit it to enqueue any type of crypto_async_request. > > Signed-off-by: Corentin Labbe <clabbe.montjoie at gmail.com> This is going the wrong way. We do not want to expose any of the base types such as crypto_alg,

On 12/12/2016 11:05 PM, Michael S. Tsirkin wrote: > On Mon, Dec 12, 2016 at 06:54:07PM +0800, Herbert Xu wrote: >> On Mon, Dec 12, 2016 at 06:25:12AM +0000, Gonglei (Arei) wrote: >>> Hi, Michael & Herbert >>> >>> Because the virtio-crypto device emulation had been in QEMU 2.8, >>> would you please merge the virtio-crypto driver for 4.10 if no other

On Mon, Dec 12, 2016 at 06:25:12AM +0000, Gonglei (Arei) wrote: > Hi, Michael & Herbert > > Because the virtio-crypto device emulation had been in QEMU 2.8, > would you please merge the virtio-crypto driver for 4.10 if no other > comments? If so, Miachel pls ack and/or review the patch, then > Herbert will take it (I asked him last week). Thank you! > > Ps: Note on

On Mon, Dec 12, 2016 at 06:54:07PM +0800, Herbert Xu wrote: > On Mon, Dec 12, 2016 at 06:25:12AM +0000, Gonglei (Arei) wrote: > > Hi, Michael & Herbert > > > > Because the virtio-crypto device emulation had been in QEMU 2.8, > > would you please merge the virtio-crypto driver for 4.10 if no other > > comments? If so, Miachel pls ack and/or review the patch,

On Mon, Dec 12, 2016 at 06:54:07PM +0800, Herbert Xu wrote: > On Mon, Dec 12, 2016 at 06:25:12AM +0000, Gonglei (Arei) wrote: > > Hi, Michael & Herbert > > > > Because the virtio-crypto device emulation had been in QEMU 2.8, > > would you please merge the virtio-crypto driver for 4.10 if no other > > comments? If so, Miachel pls ack and/or review the patch,

On Tue, Dec 06, 2016 at 09:01:49AM +0000, Gonglei (Arei) wrote: > > Would you please review and/or ack the virtio_crypto_algs.c? > It is the realization of specified algs based on Linux Crypto Framework. I have no issues with it. If the virtio folks are happy with the interface with the host then I'll take this patch. Thanks, -- Email: Herbert Xu <herbert at

On Fri, Jan 26, 2018 at 08:15:28PM +0100, Corentin Labbe wrote: > Hello > > The current crypto_engine support only ahash and ablkcipher request. > My first patch which try to add skcipher was Nacked, it will add too many functions > and adding other algs(aead, asymetric_key) will make the situation worst. > > This patchset remove all algs specific stuff and now only process

On Fri, Dec 22, 2017 at 09:41:48AM +0100, Corentin Labbe wrote: > > It's you that was suggesting using crypto_async_request: > https://www.mail-archive.com/linux-kernel at vger.kernel.org/msg1474434.html > "The only wart with this scheme is that the drivers end up seeing > struct crypto_async_request and will need to convert that to the > respective request types but I

On Wed, Mar 07, 2018 at 12:53:15AM +0100, Peter Wu wrote: > virtio_crypto does not use function crypto_authenc_extractkeys, remove > this unnecessary dependency. Compiles fine and passes cryptodev-linux > cipher and speed tests from https://wiki.qemu.org/Features/VirtioCrypto > > Fixes: dbaf0624ffa5 ("crypto: add virtio-crypto driver") > Signed-off-by: Peter Wu

On Mon, Jul 23, 2018 at 04:43:46PM +0800, Jia-Ju Bai wrote: > __virtio_crypto_ablkcipher_do_req() is never called in atomic context. > > __virtio_crypto_ablkcipher_do_req() is only called by > virtio_crypto_ablkcipher_crypt_req(), which is only called by > virtcrypto_find_vqs() that is never called in atomic context. > > __virtio_crypto_ablkcipher_do_req() calls

On Wed, Jul 01, 2020 at 10:29:36PM +0200, Rikard Falkeborn wrote: > features[] and id_table[] are not modified and can be made const to > allow the compiler to put them in read-only memory. > > Before: > text data bss dec hex filename > 11534 2056 160 13750 35b6 drivers/crypto/virtio/virtio_crypto_core.o > > After: > text data

Hi: The following patch replaces a bash-specific substitution with equivalent POSIX /bin/sh substitutions. This allows a Xen-patched Linux to build when /bin/sh is a POSIX shell other than bash. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page:

Michael S. Tsirkin <mst at redhat.com> wrote: > Move everything dealing with legacy devices out to virtio_pci_legacy.c. > Expose common code APIs in virtio_pci.h > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> This breaks virtio_pci because you deleted the licence from it. -- >8 -- Subject: virtio_pci: Restore module licence and other attributes When the

Michael S. Tsirkin <mst at redhat.com> wrote: > Move everything dealing with legacy devices out to virtio_pci_legacy.c. > Expose common code APIs in virtio_pci.h > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> This breaks virtio_pci because you deleted the licence from it. -- >8 -- Subject: virtio_pci: Restore module licence and other attributes When the

hello hpa, please pull for the dash update git pull git://brane.itp.tuwien.ac.at/~mattems/klibc.git maks with this changes: Alexey Gladkov (1): Check return code for getgroups and fwrite Herbert Xu (17): Remove unnecessary truncation in _STPUTC Always call conv_escape_str in echocmd Fix \c spillage across echo commands Release 0.5.3. Make eval with empty

On Fri, Oct 31, 2014 at 10:28:00AM +1030, Rusty Russell wrote: > Herbert Xu <herbert at gondor.apana.org.au> writes: > > On Thu, Sep 18, 2014 at 08:37:45PM +0800, Amos Kong wrote: > >> From: Rusty Russell <rusty at rustcorp.com.au> > >> > >> The previous patch added one potential problem: we can still be > >> reading from a hwrng when

On Fri, Oct 31, 2014 at 10:28:00AM +1030, Rusty Russell wrote: > Herbert Xu <herbert at gondor.apana.org.au> writes: > > On Thu, Sep 18, 2014 at 08:37:45PM +0800, Amos Kong wrote: > >> From: Rusty Russell <rusty at rustcorp.com.au> > >> > >> The previous patch added one potential problem: we can still be > >> reading from a hwrng when

Hi Keir: [NET] front: Fix features on resume when csum is off When the netfront driver is resumed the features are renegotiated with the backend. However, I forgot take into account the status of the TX checksum setting. When TX checksum is disabled by the user, we cannot enable SG or TSO since both require checksum offload. This patch makes xennet check the checksum setting before

On Sun, Nov 02, 2014 at 11:06:13PM +0800, Amos Kong wrote: > On Fri, Oct 31, 2014 at 03:23:21PM +0800, Herbert Xu wrote: > > On Fri, Oct 31, 2014 at 10:28:00AM +1030, Rusty Russell wrote: > > > Herbert Xu <herbert at gondor.apana.org.au> writes: > > > > On Thu, Sep 18, 2014 at 08:37:45PM +0800, Amos Kong wrote: > > > >> From: Rusty Russell