similar to: [vhost:vhost 8/22] drivers/virtio/virtio_mem.c:1375:20: error: implicit declaration of function 'kzalloc'; did you mean 'vzalloc'?

On Tue, May 05, 2020 at 04:50:13PM +0200, David Hildenbrand wrote: > On 05.05.20 16:15, kbuild test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost > > head: da1742791d8c0c0a8e5471f181549c4726a5c5f9 > > commit: 7527631e900d464ed2d533f799cb0da2b29cc6f0 [8/22] virtio-mem: Paravirtualized memory hotplug > > config:

On Tue, May 05, 2020 at 04:50:13PM +0200, David Hildenbrand wrote: > On 05.05.20 16:15, kbuild test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost > > head: da1742791d8c0c0a8e5471f181549c4726a5c5f9 > > commit: 7527631e900d464ed2d533f799cb0da2b29cc6f0 [8/22] virtio-mem: Paravirtualized memory hotplug > > config:

On Tue, May 05, 2020 at 05:46:44PM +0200, David Hildenbrand wrote: > On 05.05.20 17:44, Michael S. Tsirkin wrote: > > On Tue, May 05, 2020 at 04:50:13PM +0200, David Hildenbrand wrote: > >> On 05.05.20 16:15, kbuild test robot wrote: > >>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost > >>> head:

On Tue, May 05, 2020 at 05:46:44PM +0200, David Hildenbrand wrote: > On 05.05.20 17:44, Michael S. Tsirkin wrote: > > On Tue, May 05, 2020 at 04:50:13PM +0200, David Hildenbrand wrote: > >> On 05.05.20 16:15, kbuild test robot wrote: > >>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost > >>> head:

On Tue, May 05, 2020 at 06:22:51PM +0200, David Hildenbrand wrote: > On 05.05.20 18:20, Michael S. Tsirkin wrote: > > On Tue, May 05, 2020 at 05:46:44PM +0200, David Hildenbrand wrote: > >> On 05.05.20 17:44, Michael S. Tsirkin wrote: > >>> On Tue, May 05, 2020 at 04:50:13PM +0200, David Hildenbrand wrote: > >>>> On 05.05.20 16:15, kbuild test robot

On 05.05.20 16:15, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost > head: da1742791d8c0c0a8e5471f181549c4726a5c5f9 > commit: 7527631e900d464ed2d533f799cb0da2b29cc6f0 [8/22] virtio-mem: Paravirtualized memory hotplug > config: x86_64-randconfig-b002-20200505 (attached as .config) > compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0

On 05.05.20 17:44, Michael S. Tsirkin wrote: > On Tue, May 05, 2020 at 04:50:13PM +0200, David Hildenbrand wrote: >> On 05.05.20 16:15, kbuild test robot wrote: >>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost >>> head: da1742791d8c0c0a8e5471f181549c4726a5c5f9 >>> commit: 7527631e900d464ed2d533f799cb0da2b29cc6f0 [8/22]

On 05.05.20 18:20, Michael S. Tsirkin wrote: > On Tue, May 05, 2020 at 05:46:44PM +0200, David Hildenbrand wrote: >> On 05.05.20 17:44, Michael S. Tsirkin wrote: >>> On Tue, May 05, 2020 at 04:50:13PM +0200, David Hildenbrand wrote: >>>> On 05.05.20 16:15, kbuild test robot wrote: >>>>> tree:

tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost head: f3861bc96a7e130943e1975e571ae62c0319b064 commit: 5f1f79bbc9e26fa9412fa9522f957bb8f030c442 [18/52] virtio-mem: Paravirtualized memory hotplug compiler: gcc-9 (Debian 9.3.0-13) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp at intel.com> cppcheck

Each virtio-mem device owns exactly one memory region. It is responsible for adding/removing memory from that memory region on request. When the device driver starts up, the requested amount of memory is queried and then plugged to Linux. On request, further memory can be plugged or unplugged. This patch only implements the plugging part. On x86-64, memory can currently be plugged in 4MB

Fixes: 676fa9ba893e ("virtio_mem: convert device block size into 64bit") Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/virtio/virtio_mem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c index 7b1bece8a331..50c689f25045 100644 --- a/drivers/virtio/virtio_mem.c +++

rc is initialized to -ENIVAL but that's never used. Drop it. Fixes: 5f1f79bbc9e2 ("virtio-mem: Paravirtualized memory hotplug") Reported-by: kernel test robot <lkp at intel.com> Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/virtio/virtio_mem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/virtio/virtio_mem.c

Virtio mem is modern-only. Use LE accessors for config space. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/virtio/virtio_mem.c | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c index f26f5f64ae82..c08512fcea90 100644 --- a/drivers/virtio/virtio_mem.c +++

If subblock size is large (e.g. 1G) 32 bit math involving it can overflow. Rather than try to catch all instances of that, let's tweak block size to 64 bit. It ripples through UAPI which is an ABI change, but it's not too late to make it, and it will allow supporting >4Gbyte blocks while might become necessary down the road. Fixes: 5f1f79bbc9e26 ("virtio-mem: Paravirtualized

If subblock size is large (e.g. 1G) 32 bit math involving it can overflow. Rather than try to catch all instances of that, let's tweak block size to 64 bit. It ripples through UAPI which is an ABI change, but it's not too late to make it, and it will allow supporting >4Gbyte blocks while might become necessary down the road. Fixes: 5f1f79bbc9e26 ("virtio-mem: Paravirtualized

This series is based on v5.7-rc4. The patches are located at: https://github.com/davidhildenbrand/linux.git virtio-mem-v4 This is basically a resend of v3 [1], now based on v5.7-rc4 and restested. One patch was reshuffled and two ACKs I missed to add were added. The rebase did not require any modifications to patches. Details about virtio-mem can be found in the cover letter of v2 [2]. A

This series is based on latest linux-next. The patches are located at: https://github.com/davidhildenbrand/linux.git virtio-mem-v3 Patch #1 - #10 where contained in v2 and only contain minor modifications (mostly smaller fixes). The remaining patches are new and contain smaller optimizations. Details about virtio-mem can be found in the cover letter of v2 [1]. A basic QEMU implementation was

This series is based on latest linux-next. The patches are located at: https://github.com/davidhildenbrand/linux.git virtio-mem-v3 Patch #1 - #10 where contained in v2 and only contain minor modifications (mostly smaller fixes). The remaining patches are new and contain smaller optimizations. Details about virtio-mem can be found in the cover letter of v2 [1]. A basic QEMU implementation was

This series is based on latest linux-next. The patches are located at: https://github.com/davidhildenbrand/linux.git virtio-mem-v2 I now have acks for all !virtio-mem changes. I'll be happy to get review feedback, testing reports, etc. for the virtio-mem changes. If there are no further comments, I guess this is good to go as a v1 soon. The basic idea of virtio-mem is to provide a

This series is based on latest linux-next. The patches are located at: https://github.com/davidhildenbrand/linux.git virtio-mem-rfc-v4 The basic idea of virtio-mem is to provide a flexible, cross-architecture memory hot(un)plug solution that avoids many limitations imposed by existing technologies, architectures, and interfaces. More details can be found below and in linked material. This