similar to: [RFC 1/2] vhost: IFC VF hardware operation layer

On 2019/10/22 ??12:31, Simon Horman wrote: > On Mon, Oct 21, 2019 at 05:55:33PM +0800, Zhu, Lingshan wrote: >> On 10/16/2019 5:53 PM, Simon Horman wrote: >>> Hi Zhu, >>> >>> thanks for your patch. >>> >>> On Wed, Oct 16, 2019 at 09:10:40AM +0800, Zhu Lingshan wrote: > ... > >>>> +static void ifcvf_read_dev_config(struct

On 2019/10/16 ??9:30, Zhu Lingshan wrote: > This commit introduced ifcvf_base layer, which handles IFC VF NIC > hardware operations and configurations. It's better to describe the difference between ifc vf and virtio in the commit log or is there a open doc for this? > > Signed-off-by: Zhu Lingshan <lingshan.zhu at intel.com> > --- >

On 2019/10/21 ??6:00, Zhu, Lingshan wrote: > > On 10/16/2019 4:40 PM, Jason Wang wrote: >> >> On 2019/10/16 ??9:30, Zhu Lingshan wrote: >>> This commit introduced ifcvf_base layer, which handles IFC VF NIC >>> hardware operations and configurations. >> >> >> It's better to describe the difference between ifc vf and virtio in >> the

On Tue, Nov 05, 2019 at 05:37:39PM +0800, Zhu Lingshan wrote: > This commit introduced ifcvf_base layer, which handles hardware > operations and configurations. > > Signed-off-by: Zhu Lingshan <lingshan.zhu at intel.com> > --- > drivers/vhost/ifcvf/ifcvf_base.c | 344 +++++++++++++++++++++++++++++++++++++++ > drivers/vhost/ifcvf/ifcvf_base.h | 132 +++++++++++++++ >

On Tue, Nov 05, 2019 at 05:37:39PM +0800, Zhu Lingshan wrote: > This commit introduced ifcvf_base layer, which handles hardware > operations and configurations. > > Signed-off-by: Zhu Lingshan <lingshan.zhu at intel.com> > --- > drivers/vhost/ifcvf/ifcvf_base.c | 344 +++++++++++++++++++++++++++++++++++++++ > drivers/vhost/ifcvf/ifcvf_base.h | 132 +++++++++++++++ >

On Tue, Nov 05, 2019 at 05:37:39PM +0800, Zhu Lingshan wrote: > This commit introduced ifcvf_base layer, which handles hardware > operations and configurations. > > Signed-off-by: Zhu Lingshan <lingshan.zhu at intel.com> > --- > drivers/vhost/ifcvf/ifcvf_base.c | 344 +++++++++++++++++++++++++++++++++++++++ > drivers/vhost/ifcvf/ifcvf_base.h | 132 +++++++++++++++ >

On 2019/11/5 ??5:37, Zhu Lingshan wrote: > This commit introduced ifcvf_base layer, which handles hardware > operations and configurations. It looks like the PCI layout is pretty similar to virtio. Can we reuse e.g virtio_pci_modern_probe() (or helpers in virtio_pci_modern.c) to do the probing? > > Signed-off-by: Zhu Lingshan <lingshan.zhu at intel.com> > --- >

On Wed, 16 Oct 2019 09:03:17 +0800 Zhu Lingshan <lingshan.zhu at intel.com> wrote: > + IFC_INFO(&dev->dev, "PCI capability mapping:\n" > + "common cfg: %p\n" > + "notify base: %p\n" > + "isr cfg: %p\n" > + "device cfg: %p\n" > + "multiplier: %u\n", > + hw->common_cfg, > +

On 2019/10/23 ??5:24, Zhu, Lingshan wrote: >>>>> >>>>> >>>>> set_config/get_config is missing. It looks to me they are not >>>>> hard, just implementing the access to dev_cfg. It's key to make >>>>> kernel virtio driver to work. >>>>> >>>>> And in the new version of virito-mdev, features

----- Original Message ----- > This commit introduced IFC operations for vdpa, which complys to > virtio_mdev and vhost_mdev interfaces, handles IFC VF > initialization, configuration and removal. > > Signed-off-by: Zhu Lingshan <lingshan.zhu at intel.com> > --- > drivers/vhost/ifcvf/ifcvf_main.c | 605 > +++++++++++++++++++++++++++++++++++++++ > 1 file changed,

On 2019/10/21 ??5:53, Zhu, Lingshan wrote: > > On 10/16/2019 6:19 PM, Jason Wang wrote: >> >> On 2019/10/16 ??9:30, Zhu Lingshan wrote: >>> This commit introduced IFC VF operations for vdpa, which complys to >>> vhost_mdev interfaces, handles IFC VF initialization, >>> configuration and removal. >>> >>> Signed-off-by: Zhu Lingshan

On 2019/10/16 ??9:30, Zhu Lingshan wrote: > This commit introduced IFC VF operations for vdpa, which complys to > vhost_mdev interfaces, handles IFC VF initialization, > configuration and removal. > > Signed-off-by: Zhu Lingshan <lingshan.zhu at intel.com> > --- > drivers/vhost/ifcvf/ifcvf_main.c | 541 +++++++++++++++++++++++++++++++++++++++ > 1 file changed, 541

On 2019/10/22 ??2:53, Zhu Lingshan wrote: > > On 10/21/2019 6:19 PM, Jason Wang wrote: >> >> On 2019/10/21 ??5:53, Zhu, Lingshan wrote: >>> >>> On 10/16/2019 6:19 PM, Jason Wang wrote: >>>> >>>> On 2019/10/16 ??9:30, Zhu Lingshan wrote: >>>>> This commit introduced IFC VF operations for vdpa, which complys to

On 2019/10/23 ??2:19, Zhu, Lingshan wrote: > > On 10/22/2019 9:05 PM, Jason Wang wrote: >> >> On 2019/10/22 ??2:53, Zhu Lingshan wrote: >>> >>> On 10/21/2019 6:19 PM, Jason Wang wrote: >>>> >>>> On 2019/10/21 ??5:53, Zhu, Lingshan wrote: >>>>> >>>>> On 10/16/2019 6:19 PM, Jason Wang wrote:

On Wed, 16 Oct 2019 09:03:17 +0800 Zhu Lingshan <lingshan.zhu at intel.com> wrote: > +int ifcvf_init_hw(struct ifcvf_hw *hw, struct pci_dev *dev) > +{ > + int ret; > + u8 pos; > + struct virtio_pci_cap cap; > + u32 i; > + u16 notify_off; For network code, the preferred declaration style is reverse christmas tree.

On 2019/10/16 ??9:30, Zhu Lingshan wrote: > + */ > +#define IFCVF_TRANSPORT_F_START 28 > +#define IFCVF_TRANSPORT_F_END 34 > + > +#define IFC_SUPPORTED_FEATURES \ > + ((1ULL << VIRTIO_NET_F_MAC) | \ > + (1ULL << VIRTIO_F_ANY_LAYOUT) | \ > + (1ULL << VIRTIO_F_VERSION_1) | \ > + (1ULL << VHOST_F_LOG_ALL) | \ Let's avoid using

On 2019/10/21 ??5:57, Zhu, Lingshan wrote: > > On 10/16/2019 4:45 PM, Jason Wang wrote: >> >> On 2019/10/16 ??9:30, Zhu Lingshan wrote: >>> + */ >>> +#define IFCVF_TRANSPORT_F_START 28 >>> +#define IFCVF_TRANSPORT_F_END?? 34 >>> + >>> +#define IFC_SUPPORTED_FEATURES \ >>> +??????? ((1ULL << VIRTIO_NET_F_MAC)??????????? |

This commit implements a new function ifcvf_get_driver_feature() which read driver_features from virtio registers. To be less ambiguous, ifcvf_set_features() is renamed to ifcvf_set_driver_features(), and ifcvf_get_features() is renamed to ifcvf_get_dev_features() which returns the provisioned vDPA device features. Signed-off-by: Zhu Lingshan <lingshan.zhu at intel.com> ---

This commit implements a new function ifcvf_get_driver_feature() which read driver_features from virtio registers. To be less ambiguous, ifcvf_set_features() is renamed to ifcvf_set_driver_features(), and ifcvf_get_features() is renamed to ifcvf_get_dev_features() which returns the provisioned vDPA device features. Signed-off-by: Zhu Lingshan <lingshan.zhu at intel.com> ---

Rather than former lazy-initialization mechanism, now the virtqueue operations and driver_features related ops access the virtio registers directly to take immediate actions. So ifcvf_start_datapath() should retire. ifcvf_add_status() is retierd because we should not change device status by a vendor driver's decision, this driver should only set device status which is from virito drivers upon