similar to: [PATCH] virtio_net: enable tx after resuming from suspend

On 2018?10?11? 18:22, ake wrote: > > On 2018?10?11? 18:44, Jason Wang wrote: >> >> On 2018?10?11? 15:51, Ake Koomsin wrote: >>> commit 713a98d90c5e ("virtio-net: serialize tx routine during reset") >>> disabled the virtio tx before going to suspend to avoid a use after free. >>> However, after resuming, it causes the virtio_net device to lose

On 2018?10?12? 12:30, ake wrote: > > On 2018?10?11? 22:06, Jason Wang wrote: >> >> On 2018?10?11? 18:22, ake wrote: >>> On 2018?10?11? 18:44, Jason Wang wrote: >>>> On 2018?10?11? 15:51, Ake Koomsin wrote: >>>>> commit 713a98d90c5e ("virtio-net: serialize tx routine during reset") >>>>> disabled the virtio tx before

On 2018?10?11? 15:51, Ake Koomsin wrote: > commit 713a98d90c5e ("virtio-net: serialize tx routine during reset") > disabled the virtio tx before going to suspend to avoid a use after free. > However, after resuming, it causes the virtio_net device to lose its > network connectivity. > > To solve the issue, we need to enable tx after resuming. > > Fixes commit

On 2015/3/15 16:40, Michael S. Tsirkin wrote: > On Sun, Mar 15, 2015 at 02:50:27PM +0800, Linhaifeng wrote: >> Hi,Michael >> >> I had tested the start_xmit function by the follow code found that the tx queue's state is stopped and can't send any packets anymore. > > Why don't you Cc all maintainers on this email? > Pls check the file MAINTAINERS for the

On 2015/3/15 16:40, Michael S. Tsirkin wrote: > On Sun, Mar 15, 2015 at 02:50:27PM +0800, Linhaifeng wrote: >> Hi,Michael >> >> I had tested the start_xmit function by the follow code found that the tx queue's state is stopped and can't send any packets anymore. > > Why don't you Cc all maintainers on this email? > Pls check the file MAINTAINERS for the

On Mon, Mar 16, 2015 at 05:24:07PM +0800, Linhaifeng wrote: > > > On 2015/3/15 16:40, Michael S. Tsirkin wrote: > > On Sun, Mar 15, 2015 at 02:50:27PM +0800, Linhaifeng wrote: > >> Hi,Michael > >> > >> I had tested the start_xmit function by the follow code found that the tx queue's state is stopped and can't send any packets anymore. > >

On Mon, Mar 16, 2015 at 05:24:07PM +0800, Linhaifeng wrote: > > > On 2015/3/15 16:40, Michael S. Tsirkin wrote: > > On Sun, Mar 15, 2015 at 02:50:27PM +0800, Linhaifeng wrote: > >> Hi,Michael > >> > >> I had tested the start_xmit function by the follow code found that the tx queue's state is stopped and can't send any packets anymore. > >

On Sun, Mar 15, 2015 at 02:50:27PM +0800, Linhaifeng wrote: > Hi,Michael > > I had tested the start_xmit function by the follow code found that the tx queue's state is stopped and can't send any packets anymore. Why don't you Cc all maintainers on this email? Pls check the file MAINTAINERS for the full list. I added Cc for now. > > static netdev_tx_t

On Sun, Mar 15, 2015 at 02:50:27PM +0800, Linhaifeng wrote: > Hi,Michael > > I had tested the start_xmit function by the follow code found that the tx queue's state is stopped and can't send any packets anymore. Why don't you Cc all maintainers on this email? Pls check the file MAINTAINERS for the full list. I added Cc for now. > > static netdev_tx_t

virtio net will never try to overflow the TX ring, so the only reason add_buf may fail is out of memory. Thus, we can not stop the device until some request completes - there's no guarantee anything at all is outstanding. Make the error message clearer as well: error here does not indicate queue full. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/net/virtio_net.c |

virtio net will never try to overflow the TX ring, so the only reason add_buf may fail is out of memory. Thus, we can not stop the device until some request completes - there's no guarantee anything at all is outstanding. Make the error message clearer as well: error here does not indicate queue full. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/net/virtio_net.c |

Dear list, I encounter an error when I try to use ddply to generate means as follows: fun3<-structure(list(sector = structure(list(gics_sector_name = c("Financials", "Financials", "Materials", "Materials")), .Names = "gics_sector_name", row.names = structure(c("UBSN VX Equity", "LLOY LN Equity", "AI FP Equity",

I am trying to connect a KVM-QEMU VM to OVS-DPDK vhostuser port. But, I am encountering a few errors. Since I am very new to libvrt and Linux I am not able to sort them out. Any guidance in this regard would be a great help. These are my System Logs: Mar 28 18:03:04 dpdk-OptiPlex-5040 libvirtd.service: 1529: debug : virCommandRunAsync:2429 : About to run LIBVIRT_LOG_OUTPUTS=3:stderr

Hi all, I've got a weird issue, and I'm trying to confirm if it's a bug, and if so, if there is a workaround until it is fixed. The situation is this: If I virsh reboot <domain> --mode acpi, it will actually reboot the domain cleanly (watching from the console allows me to see the full shutdown messages, followed by a bootup). However, after this point, virsh domstate

On newer hosts that support delayed tx interrupts, we probably don't have much to gain from orphaning packets early. Based on patch by Jason Wang. Note: this might degrade performance for hosts without event idx support. Should be addressed by the next patch. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/net/virtio_net.c | 133

On newer hosts that support delayed tx interrupts, we probably don't have much to gain from orphaning packets early. Based on patch by Jason Wang. Note: this might degrade performance for hosts without event idx support. Should be addressed by the next patch. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/net/virtio_net.c | 133

On 10/15/2014 05:53 AM, Michael S. Tsirkin wrote: > On newer hosts that support delayed tx interrupts, > we probably don't have much to gain from orphaning > packets early. > > Based on patch by Jason Wang. > > Note: this will likely degrade performance for hosts without event idx > support. Various fallback options are available, including > orphaning

On newer hosts that support delayed tx interrupts, we probably don't have much to gain from orphaning packets early. Note: this might degrade performance for hosts without event idx support. Should be addressed by the next patch. Cc: Rusty Russell <rusty at rustcorp.com.au> Cc: Michael S. Tsirkin <mst at redhat.com> Signed-off-by: Michael S. Tsirkin <mst at redhat.com>

On newer hosts that support delayed tx interrupts, we probably don't have much to gain from orphaning packets early. Note: this might degrade performance for hosts without event idx support. Should be addressed by the next patch. Cc: Rusty Russell <rusty at rustcorp.com.au> Cc: Michael S. Tsirkin <mst at redhat.com> Signed-off-by: Michael S. Tsirkin <mst at redhat.com>

On Wed, Oct 15, 2014 at 03:25:29PM +0800, Jason Wang wrote: > Orphan skb in ndo_start_xmit() breaks socket accounting and packet > queuing. This in fact breaks lots of things such as pktgen and several > TCP optimizations. And also make BQL can't be implemented for > virtio-net. > > This patch tries to solve this issue by enabling tx interrupt. To > avoid introducing