similar to: [PATCH 2/2] virtio/s390: fix race in ccw_io_helper()

On Wed, 12 Sep 2018 16:02:02 +0200 Halil Pasic <pasic at linux.ibm.com> wrote: > While ccw_io_helper() seems like intended to be exclusive in a sense that > it is supposed to facilitate I/O for at most one thread at any given > time, there is actually nothing ensuring that threads won't pile up at > vcdev->wait_q. If they all threads get woken up and see the status that

On Wed, 19 Sep 2018 18:56:45 +0200 Halil Pasic <pasic at linux.ibm.com> wrote: > On 09/19/2018 04:07 PM, Cornelia Huck wrote: > > Do you spot any other places where we may need to care about concurrent > > processing (like for the ->config area in the previous patch)? > > > > It is hard to tell, because: > * Synchronization external to the transport

On Wed, 19 Sep 2018 15:17:28 +0200 Halil Pasic <pasic at linux.ibm.com> wrote: > On 09/18/2018 08:45 PM, Cornelia Huck wrote: > > We basically have two options: > > - Have a way to queue I/O operations and then handle them in sequence. > > Creates complexity, and is likely overkill. (We already have a kind > > of serialization because we re-submit the channel

On Mon, 24 Sep 2018 16:27:30 +0200 Halil Pasic <pasic at linux.ibm.com> wrote: > On 09/24/2018 02:55 PM, Cornelia Huck wrote: > > On Fri, 21 Sep 2018 17:47:47 -0400 > > Farhan Ali <alifm at linux.ibm.com> wrote: > > > >> On 09/21/2018 09:28 AM, Halil Pasic wrote: > > > >>> Anyway I'm fine with swapping the old out and your

On Wed, 19 Sep 2018 00:52:14 +0200 Halil Pasic <pasic at linux.ibm.com> wrote: > On 09/18/2018 08:29 PM, Cornelia Huck wrote: > > On Wed, 12 Sep 2018 16:02:01 +0200 > > Halil Pasic <pasic at linux.ibm.com> wrote: > > > >> Currently we have a race on vcdev->config in virtio_ccw_get_config() and > >> in virtio_ccw_set_config(). > >>

On Wed, 12 Sep 2018 16:02:01 +0200 Halil Pasic <pasic at linux.ibm.com> wrote: > Currently we have a race on vcdev->config in virtio_ccw_get_config() and > in virtio_ccw_set_config(). > > This normally does not cause problems, as these are usually infrequent > operations. But occasionally sysfs attributes are directly dependent on > pieces of virio config and trigger a

The following changes since commit 8c0f9f5b309d627182d5da72a69246f58bde1026: Revert "uapi/linux/keyctl.h: don't use C++ reserved keyword as a struct member name" (2018-09-25 13:28:58 +0200) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kvms390/linux.git tags/virtio-ccw-20180926 for you to fetch changes up to

On Mon, 27 May 2019 13:57:06 +0200 Halil Pasic <pasic at linux.ibm.com> wrote: > On Mon, 27 May 2019 13:00:28 +0200 > Cornelia Huck <cohuck at redhat.com> wrote: > > > On Thu, 23 May 2019 18:22:07 +0200 > > Michael Mueller <mimu at linux.ibm.com> wrote: > > > > > From: Halil Pasic <pasic at linux.ibm.com> > > > > >

On 24.07.19 10:34, Cornelia Huck wrote: > On Wed, 24 Jul 2019 08:44:19 +0200 > Christian Borntraeger <borntraeger at de.ibm.com> wrote: > >> On 24.07.19 00:58, Halil Pasic wrote: >>> The access to airq_areas was racy ever since the adapter interrupts got >>> introduced to virtio-ccw, but since commit 39c7dcb15892 ("virtio/s390: >>> make airq

On Wed, 10 Apr 2019 19:48:49 +0200 Halil Pasic <pasic at linux.ibm.com> wrote: > On Wed, 10 Apr 2019 18:36:43 +0200 > Cornelia Huck <cohuck at redhat.com> wrote: > > > On Wed, 10 Apr 2019 17:12:54 +0200 > > Halil Pasic <pasic at linux.ibm.com> wrote: > > > > > On Wed, 10 Apr 2019 10:46:49 +0200 > > > Cornelia Huck <cohuck at

From: Halil Pasic <pasic at linux.ibm.com> [ Upstream commit 4f419eb14272e0698e8c55bb5f3f266cc2a21c81 ] The access to airq_areas was racy ever since the adapter interrupts got introduced to virtio-ccw, but since commit 39c7dcb15892 ("virtio/s390: make airq summary indicators DMA") this became an issue in practice as well. Namely before that commit the airq_info that got

From: Halil Pasic <pasic at linux.ibm.com> [ Upstream commit 4f419eb14272e0698e8c55bb5f3f266cc2a21c81 ] The access to airq_areas was racy ever since the adapter interrupts got introduced to virtio-ccw, but since commit 39c7dcb15892 ("virtio/s390: make airq summary indicators DMA") this became an issue in practice as well. Namely before that commit the airq_info that got

On Thu, 23 May 2019 18:22:07 +0200 Michael Mueller <mimu at linux.ibm.com> wrote: > From: Halil Pasic <pasic at linux.ibm.com> > > This will come in handy soon when we pull out the indicators from > virtio_ccw_device to a memory area that is shared with the hypervisor > (in particular for protected virtualization guests). > > Signed-off-by: Halil Pasic <pasic

On Thu, 23 May 2019 18:22:07 +0200 Michael Mueller <mimu at linux.ibm.com> wrote: > From: Halil Pasic <pasic at linux.ibm.com> > > This will come in handy soon when we pull out the indicators from > virtio_ccw_device to a memory area that is shared with the hypervisor > (in particular for protected virtualization guests). > > Signed-off-by: Halil Pasic <pasic

On Wed, 24 Jul 2019 08:44:19 +0200 Christian Borntraeger <borntraeger at de.ibm.com> wrote: > On 24.07.19 00:58, Halil Pasic wrote: > > The access to airq_areas was racy ever since the adapter interrupts got > > introduced to virtio-ccw, but since commit 39c7dcb15892 ("virtio/s390: > > make airq summary indicators DMA") this became an issue in practice as >

On Wed, 24 Jul 2019 08:44:19 +0200 Christian Borntraeger <borntraeger at de.ibm.com> wrote: > On 24.07.19 00:58, Halil Pasic wrote: > > The access to airq_areas was racy ever since the adapter interrupts got > > introduced to virtio-ccw, but since commit 39c7dcb15892 ("virtio/s390: > > make airq summary indicators DMA") this became an issue in practice as >

On Mon, 27 May 2019 13:00:28 +0200 Cornelia Huck <cohuck at redhat.com> wrote: > On Thu, 23 May 2019 18:22:07 +0200 > Michael Mueller <mimu at linux.ibm.com> wrote: > > > From: Halil Pasic <pasic at linux.ibm.com> > > > > This will come in handy soon when we pull out the indicators from > > virtio_ccw_device to a memory area that is shared with

On Tue, 25 Sep 2018 14:13:07 +0200 Halil Pasic <pasic at linux.ibm.com> wrote: > The trigger for the series is this bug report: > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1788432 > > Changelog: > v1 -> v2: > * improve on commit messages, add cc:stable > RFC -> v1: > * do mutual exclusion on a per device basis in ccw_io_helper() > > Halil

Can you consider adding stable tags to the (final version of the) fixes? On 09/21/2018 02:46 PM, Halil Pasic wrote: > The trigger for the series is this bug report: > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1788432 > > Changelog: > RFC -> v1: > * do mutual exclusion on a per device basis in ccw_io_helper() > > Halil Pasic (2): > virtio/s390: avoid

On Thu, 29 Nov 2018 15:56:48 +0100 Cornelia Huck <cohuck at redhat.com> wrote: > On Wed, 26 Sep 2018 18:48:28 +0200 > Cornelia Huck <cohuck at redhat.com> wrote: > > > The following changes since commit 8c0f9f5b309d627182d5da72a69246f58bde1026: > > > > Revert "uapi/linux/keyctl.h: don't use C++ reserved keyword as a struct member name"