similar to: [PATCH] virtio: mark vring_dma_dev() static

On Sunday, August 28, 2016 1:02:52 PM CEST Baoyou Xie wrote: > We get 1 warning when build kernel with W=1: > drivers/gpu/drm/nouveau/dispnv04/overlay.c:496:1: warning: no previous prototype for 'nouveau_overlay_init' [-Wmissing-prototypes] > > In fact, this function is declared in disp.h, so this patch > add missing header dependencies > > Signed-off-by: Baoyou Xie

On Tuesday 30 August 2016, Baoyou Xie wrote: > We get some warnings when building kernel with W=1: > drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgf117.c:222:1: warning: no previous prototype for 'gf117_grctx_generate_main' [-Wmissing-prototypes] > drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxnv50.c:255:1: warning: no previous prototype for 'nv50_grctx_fill'

On 30 August 2016 at 00:01, Sean Paul <seanpaul at google.com> wrote: > On Mon, Aug 29, 2016 at 9:02 AM, Baoyou Xie <baoyou.xie at linaro.org> wrote: > > We get 1 warning when build kernel with W=1: > > drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c:937:1: warning: no > previous prototype for 'gm107_grctx_generate_tpcid' [-Wmissing-prototypes] > >

On Tuesday 30 August 2016, Baoyou Xie wrote: > On 30 August 2016 at 00:01, Sean Paul <seanpaul at google.com> wrote: > > > On Mon, Aug 29, 2016 at 9:02 AM, Baoyou Xie <baoyou.xie at linaro.org> wrote: > > > We get 1 warning when build kernel with W=1: > > > drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c:937:1: warning: no > > previous prototype

On Mon, Aug 29, 2016 at 9:02 AM, Baoyou Xie <baoyou.xie at linaro.org> wrote: > We get 1 warning when build kernel with W=1: > drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c:937:1: warning: no previous prototype for 'gm107_grctx_generate_tpcid' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which it is > declared and don't need a

We get 1 warning when build kernel with W=1: drivers/gpu/drm/nouveau/dispnv04/overlay.c:496:1: warning: no previous prototype for 'nouveau_overlay_init' [-Wmissing-prototypes] In fact, this function is declared in disp.h, so this patch add missing header dependencies Signed-off-by: Baoyou Xie <baoyou.xie at linaro.org> --- drivers/gpu/drm/nouveau/dispnv04/overlay.c | 2 +- 1 file

We get 1 warning when build kernel with W=1: drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c:937:1: warning: no previous prototype for 'gm107_grctx_generate_tpcid' [-Wmissing-prototypes] In fact, this function is only used in the file in which it is declared and don't need a declaration, but can be made static. so this patch marks this function with 'static'. Signed-off-by:

We get 2 warnings when build kernel with W=1: drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c:75:1: warning: no previous prototype for 'nvkm_perfsig_find' [-Wmissing-prototypes] drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c:703:1: warning: no previous prototype for 'nvkm_perfsrc_new' [-Wmissing-prototypes] In fact, these functions are only used in the file in which they are declared

We get 2 warnings when biuld kernel with W=1: drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c:75:1: warning: no previous prototype for 'nvkm_perfsig_find' [-Wmissing-prototypes] drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c:703:1: warning: no previous prototype for 'nvkm_perfsrc_new' [-Wmissing-prototypes] In fact, these functions are only used in the file in which they are declared

We get 1 warning about global functions without a declaration in the nouveau nv10_fence driver when building with W=1: drivers/gpu/drm/nouveau/nv10_fence.c:70:1: warning: no previous prototype for 'nv10_fence_context_new' [-Wmissing-prototypes] In fact, this function is only used in the file in which it is declared and don't need a declaration, but can be made static. so this patch

We get 1 warning when biuld kernel with W=1: drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgf117.c:222:1: warning: no previous prototype for 'gf117_grctx_generate_main' [-Wmissing-prototypes] In fact, this function is only used in the file in which it is declared and don't need a declaration, but can be made static. so this patch marks this function with 'static'. Signed-off-by:

We get 1 warning about global functions without a declaration in the nouveau nouveau_display driver when building with W=1: drivers/gpu/drm/nouveau/nouveau_display.c:96:1: warning: no previous prototype for 'nouveau_display_scanoutpos_head' [-Wmissing-prototypes] In fact, this function is only used in the file in which it is declared and don't need a declaration, but can be made

We get 1 warning when build kernel with W=1: drivers/gpu/drm/nouveau/nvkm/engine/gr/gm107.c:312:1: warning: no previous prototype for 'gm107_gr_init' [-Wmissing-prototypes] In fact, this function is only used in the file in which it is declared and don't need a declaration, but can be made static. so this patch marks this function with 'static'. Signed-off-by: Baoyou Xie

We get 1 warning when biuld kernel with W=1: drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c:937:1: warning: no previous prototype for 'gm107_grctx_generate_tpcid' [-Wmissing-prototypes] In fact, this function is only used in the file in which it is declared and don't need a declaration, but can be made static. so this patch marks this function with 'static'. Signed-off-by:

We get 1 warning when build kernel with W=1: drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgf117.c:222:1: warning: no previous prototype for 'gf117_grctx_generate_main' [-Wmissing-prototypes] In fact, this function is only used in the file in which it is declared and don't need a declaration, but can be made static. so this patch marks this function with 'static'. Signed-off-by:

After removing the reset function, the freeze and restore functions are now unused when CONFIG_PM_SLEEP is disabled: drivers/net/virtio_net.c:1881:12: error: 'virtnet_restore_up' defined but not used [-Werror=unused-function] static int virtnet_restore_up(struct virtio_device *vdev) drivers/net/virtio_net.c:1859:13: error: 'virtnet_freeze_down' defined but not used

After removing the reset function, the freeze and restore functions are now unused when CONFIG_PM_SLEEP is disabled: drivers/net/virtio_net.c:1881:12: error: 'virtnet_restore_up' defined but not used [-Werror=unused-function] static int virtnet_restore_up(struct virtio_device *vdev) drivers/net/virtio_net.c:1859:13: error: 'virtnet_freeze_down' defined but not used

2016-10-24 9:13 GMT+02:00 Baoyou Xie <baoyou.xie at linaro.org>: > > > On 23 October 2016 at 01:32, Karol Herbst <karolherbst at gmail.com> wrote: >> >> I think it would be better to squash those commits: >> 1. for the includes >> 2. for static declerations >> > OK, I have resent new patch that squash those commits. > thanks, this is much

On 23 October 2016 at 01:32, Karol Herbst <karolherbst at gmail.com> wrote: > I think it would be better to squash those commits: > 1. for the includes > 2. for static declerations > > OK, I have resent new patch that squash those commits. > 2016-10-22 11:41 GMT+02:00 Baoyou Xie <baoyou.xie at linaro.org>: > > We get 2 warnings when building kernel with W=1:

We get a few warnings when building kernel with W=1: drivers/gpu/drm/nouveau/nvkm/subdev/bios/fan.c:29:1: warning: no previous prototype for 'nvbios_fan_table' [-Wmissing-prototypes] drivers/gpu/drm/nouveau/nvkm/subdev/clk/gt215.c:184:1: warning: no previous prototype for 'gt215_clk_info' [-Wmissing-prototypes] drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgt215.c:153:1: warning: no