similar to: [PATCH net-next] virtio_net: replace netdev_alloc_skb_ip_align() with napi_alloc_skb()

This gives small but noticeable rx performance improvement (2-3%) and will allow exploiting future napi improvement. Signed-off-by: Paolo Abeni <pabeni at redhat.com> -- v2: replace also netdev_alloc_skb_ip_align() invocation in add_recvbuf_small(), suggested by Venkatesh Srinivas --- drivers/net/virtio_net.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

This gives small but noticeable rx performance improvement (2-3%) and will allow exploiting future napi improvement. Signed-off-by: Paolo Abeni <pabeni at redhat.com> -- v2: replace also netdev_alloc_skb_ip_align() invocation in add_recvbuf_small(), suggested by Venkatesh Srinivas --- drivers/net/virtio_net.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

On Thu, Mar 17, 2016 at 7:44 AM, Paolo Abeni <pabeni at redhat.com> wrote: > > This gives small but noticeable rx performance improvement (2-3%) > and will allow exploiting future napi improvement. > > Signed-off-by: Paolo Abeni <pabeni at redhat.com> > --- Worked in my tests, though the performance win was in the noise (+0.6% - +1% bandwidth). What tests did you see

Similar to commit a2ac99905f1e ("vhost-net: set packet weight of tx polling to 2 * vq size"), we need a packet-based limit for handler_rx, too - elsewhere, under rx flood with small packets, tx can be delayed for a very long time, even without busypolling. The pkt limit applied to handle_rx must be the same applied by handle_tx, or we will get unfair scheduling between rx and tx. Tying

On Thu, 30 Mar 2023 12:48:22 +0200, Paolo Abeni <pabeni at redhat.com> wrote: > On Tue, 2023-03-28 at 20:04 +0800, Xuan Zhuo wrote: > > @@ -949,15 +1042,11 @@ static struct sk_buff *receive_small(struct net_device *dev, > > { > > struct sk_buff *skb; > > struct bpf_prog *xdp_prog; > > - unsigned int xdp_headroom = (unsigned long)ctx; > > - unsigned

Hi, On Tue, 2023-03-07 at 09:49 +0800, Xuan Zhuo wrote: > On Mon, 6 Mar 2023 12:58:22 -0500, "Michael S. Tsirkin" <mst at redhat.com> wrote: > > On Mon, Mar 06, 2023 at 12:15:33PM +0800, Xuan Zhuo wrote: > > > If the queue of xdp xmit is not an independent queue, then when the xdp > > > xmit used all the desc, the xmit from the __dev_queue_xmit() may

On Tue, 2023-07-25 at 16:07 +0300, Gavin Li wrote: > Add interrupt_coalesce config in send_queue and receive_queue to cache user > config. > > Send per virtqueue interrupt moderation config to underlying device in > order to have more efficient interrupt moderation and cpu utilization of > guest VM. > > Additionally, address all the VQs when updating the global

On Thu, 2016-03-10 at 09:28 -0500, Aaron Conole wrote: > This patch checks the feature bit for the VIRTIO_NET_F_MTU feature. If it > exists, read the advised MTU and use it. > > No proper error handling is provided for the case where a user changes the > negotiated MTU. A future commit will add proper error handling. Instead, a > warning is emitted if the guest changes the

On Thu, 2016-03-10 at 09:28 -0500, Aaron Conole wrote: > This patch checks the feature bit for the VIRTIO_NET_F_MTU feature. If it > exists, read the advised MTU and use it. > > No proper error handling is provided for the case where a user changes the > negotiated MTU. A future commit will add proper error handling. Instead, a > warning is emitted if the guest changes the

The following changes since commit e1f33be9186363da7955bcb5f0b03e6685544c50: vhost: fix error path in vhost_init_used() (2016-03-02 17:01:49 +0200) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus for you to fetch changes up to c67f5db82027ba6d2ea4ac9176bc45996a03ae6a: virtio_net: replace netdev_alloc_skb_ip_align() with

The following changes since commit e1f33be9186363da7955bcb5f0b03e6685544c50: vhost: fix error path in vhost_init_used() (2016-03-02 17:01:49 +0200) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus for you to fetch changes up to c67f5db82027ba6d2ea4ac9176bc45996a03ae6a: virtio_net: replace netdev_alloc_skb_ip_align() with

Now that ->sendpage() has been removed, MSG_SENDPAGE_NOTLAST can be cleaned up. Things were converted to use MSG_MORE instead, but the protocol sendpage stubs still convert MSG_SENDPAGE_NOTLAST to MSG_MORE, which is now unnecessary. Signed-off-by: David Howells <dhowells at redhat.com> cc: "David S. Miller" <davem at davemloft.net> cc: Eric Dumazet <edumazet at

Hi, On Tue, 2023-03-28 at 20:04 +0800, Xuan Zhuo wrote: > The purpose of this patch is to simplify the receive_mergeable(). > Separate all the logic of XDP into a function. > > Signed-off-by: Xuan Zhuo <xuanzhuo at linux.alibaba.com> > --- > drivers/net/virtio_net.c | 128 +++++++++++++++++++++++---------------- > 1 file changed, 76 insertions(+), 52 deletions(-) >

On Wed, Mar 19, 2014 at 10:48 AM, Venkatesh Srinivas <venkateshs at google.com> wrote: >> And I rewrote it substantially, mainly to take >> VIRTIO_RING_F_INDIRECT_DESC into account. >> >> As QEMU sets the vq size for PCI to 128, Venkatash's patch wouldn't >> have made a change. This version does (since QEMU also offers >>

On Wed, Mar 19, 2014 at 10:48 AM, Venkatesh Srinivas <venkateshs at google.com> wrote: >> And I rewrote it substantially, mainly to take >> VIRTIO_RING_F_INDIRECT_DESC into account. >> >> As QEMU sets the vq size for PCI to 128, Venkatash's patch wouldn't >> have made a change. This version does (since QEMU also offers >>

On 2018?03?01? 18:35, Jesper Dangaard Brouer wrote: > On Thu, 1 Mar 2018 17:23:37 +0800 > Jason Wang <jasowang at redhat.com> wrote: > >> On 2018?03?01? 17:10, Jesper Dangaard Brouer wrote: >>> On Thu, 1 Mar 2018 11:19:03 +0800 >>> Jason Wang <jasowang at redhat.com> wrote: >>> >>>> This series tries to re-enable XDP_REDIRECT

On 2018?03?01? 18:35, Jesper Dangaard Brouer wrote: > On Thu, 1 Mar 2018 17:23:37 +0800 > Jason Wang <jasowang at redhat.com> wrote: > >> On 2018?03?01? 17:10, Jesper Dangaard Brouer wrote: >>> On Thu, 1 Mar 2018 11:19:03 +0800 >>> Jason Wang <jasowang at redhat.com> wrote: >>> >>>> This series tries to re-enable XDP_REDIRECT

tytso at mit.edu writes: > On Mon, Mar 17, 2014 at 11:12:15AM +1030, Rusty Russell wrote: >> >> Note that with indirect descriptors (which is supported by Almost >> Everyone), we can actually use the full index, so this value is a bit >> pessimistic. But it's OK as a starting point. > > So is this something that can go upstream with perhaps a slight >

tytso at mit.edu writes: > On Mon, Mar 17, 2014 at 11:12:15AM +1030, Rusty Russell wrote: >> >> Note that with indirect descriptors (which is supported by Almost >> Everyone), we can actually use the full index, so this value is a bit >> pessimistic. But it's OK as a starting point. > > So is this something that can go upstream with perhaps a slight >

On Mon, Nov 30, 2015 at 11:15:23AM +0200, Michael S. Tsirkin wrote: > We know vring num is a power of 2, so use & > to mask the high bits. > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > --- The generated code switches from DIV -> masking, source is clearer as well. Tested-by: Venkatesh Srinivas <venkateshs at google.com> -- vs;