similar to: [PATCH v3 2/6] virtio: balloon might not be a legacy device

We added transitional device support to balloon driver, so we don't need to black-list it in core anymore. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/virtio/virtio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c index 5ce2aa4..5fa67b5 100644 --- a/drivers/virtio/virtio.c +++

We added transitional device support to balloon driver, so we don't need to black-list it in core anymore. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/virtio/virtio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c index 5ce2aa4..5fa67b5 100644 --- a/drivers/virtio/virtio.c +++

transports need to be able to detect legacy-only devices (ATM balloon only) to use legacy path to drive them. Add a core API to do just that. The implementation just blacklists balloon: not too pretty, but let's not over-engineer. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/linux/virtio.h | 2 ++ drivers/virtio/virtio.c | 6 ++++++ 2 files changed, 8

transports need to be able to detect legacy-only devices (ATM balloon only) to use legacy path to drive them. Add a core API to do just that. The implementation just blacklists balloon: not too pretty, but let's not over-engineer. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/linux/virtio.h | 2 ++ drivers/virtio/virtio.c | 6 ++++++ 2 files changed, 8

transports need to be able to detect legacy-only devices (ATM balloon only) to use legacy path to drive them. Add a core API to do just that. The implementation just blacklists balloon: not too pretty, but let's not over-engineer. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> Acked-by: Cornelia Huck <cornelia.huck at de.ibm.com> --- include/linux/virtio.h | 2 ++

virtio_device_is_legacy_only is now unused, drop it from core. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/linux/virtio.h | 2 -- drivers/virtio/virtio.c | 6 ------ 2 files changed, 8 deletions(-) diff --git a/include/linux/virtio.h b/include/linux/virtio.h index 28f0e65..8f4d4bf 100644 --- a/include/linux/virtio.h +++ b/include/linux/virtio.h @@ -108,8 +108,6 @@

virtio_device_is_legacy_only is now unused, drop it from core. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/linux/virtio.h | 2 -- drivers/virtio/virtio.c | 6 ------ 2 files changed, 8 deletions(-) diff --git a/include/linux/virtio.h b/include/linux/virtio.h index 28f0e65..8f4d4bf 100644 --- a/include/linux/virtio.h +++ b/include/linux/virtio.h @@ -108,8 +108,6 @@

Virtio 1.0 doesn't include a modern balloon device. At some point we'll likely define an incompatible interface with a different ID. But for now, it's not a big change to support a transitional balloon device: this has the advantage of supporting existing drivers, transparently. The only issue is with the stats buffer, which has misaligned fields. Seems easy to fix by prepending a 6

Virtio 1.0 doesn't include a modern balloon device. At some point we'll likely define an incompatible interface with a different ID. But for now, it's not a big change to support a transitional balloon device: this has the advantage of supporting existing drivers, transparently. The only issue is with the stats buffer, which has misaligned fields. Seems easy to fix by prepending a 6

Currently shutdown is nop for virtio devices, but the core code could remove things behind us such as MSI-X handler etc. For example in the case of virtio-scsi-pci, the device may still try to send interupts, which will be on IRQ lines seeing MSI-X disabled. Those interrupts will be unhandled, and may cause flood. Remove the device in "shutdown" callback to allow device drivers clean up

Currently shutdown is nop for virtio devices, but the core code could remove things behind us such as MSI-X handler etc. For example in the case of virtio-scsi-pci, the device may still try to send interupts, which will be on IRQ lines seeing MSI-X disabled. Those interrupts will be unhandled, and may cause flood. Remove the device in "shutdown" callback to allow device drivers clean up

virtio_device_is_legacy_only is now unused, drop it from core. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/linux/virtio.h | 2 -- drivers/virtio/virtio.c | 6 ------ 2 files changed, 8 deletions(-) diff --git a/include/linux/virtio.h b/include/linux/virtio.h index 28f0e65..8f4d4bf 100644 --- a/include/linux/virtio.h +++ b/include/linux/virtio.h @@ -108,8 +108,6 @@

virtio_device_is_legacy_only is now unused, drop it from core. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/linux/virtio.h | 2 -- drivers/virtio/virtio.c | 6 ------ 2 files changed, 8 deletions(-) diff --git a/include/linux/virtio.h b/include/linux/virtio.h index 28f0e65..8f4d4bf 100644 --- a/include/linux/virtio.h +++ b/include/linux/virtio.h @@ -108,8 +108,6 @@

On Wed, Mar 11, 2015 at 04:09:17PM +0800, Fam Zheng wrote: > Currently shutdown is nop for virtio devices, but the core code could > remove things behind us such as MSI-X handler etc. For example in the > case of virtio-scsi-pci, the device may still try to send interupts, > which will be on IRQ lines seeing MSI-X disabled. Those interrupts will > be unhandled, and may cause flood.

On Wed, Mar 11, 2015 at 04:09:17PM +0800, Fam Zheng wrote: > Currently shutdown is nop for virtio devices, but the core code could > remove things behind us such as MSI-X handler etc. For example in the > case of virtio-scsi-pci, the device may still try to send interupts, > which will be on IRQ lines seeing MSI-X disabled. Those interrupts will > be unhandled, and may cause flood.

On Wed, Mar 11, 2015 at 06:11:35PM +0800, Fam Zheng wrote: > On Wed, 03/11 10:06, Michael S. Tsirkin wrote: > > On Wed, Mar 11, 2015 at 04:09:17PM +0800, Fam Zheng wrote: > > > Currently shutdown is nop for virtio devices, but the core code could > > > remove things behind us such as MSI-X handler etc. For example in the > > > case of virtio-scsi-pci, the device

On Wed, Mar 11, 2015 at 06:11:35PM +0800, Fam Zheng wrote: > On Wed, 03/11 10:06, Michael S. Tsirkin wrote: > > On Wed, Mar 11, 2015 at 04:09:17PM +0800, Fam Zheng wrote: > > > Currently shutdown is nop for virtio devices, but the core code could > > > remove things behind us such as MSI-X handler etc. For example in the > > > case of virtio-scsi-pci, the device

transports need to be able to detect legacy-only devices (ATM balloon only) to use legacy path to drive them. Add a core API to do just that. The implementation just blacklists balloon: not too pretty, but let's not over-engineer. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> Acked-by: Cornelia Huck <cornelia.huck at de.ibm.com> --- include/linux/virtio.h | 2 ++

transports need to be able to detect legacy-only devices (ATM balloon only) to use legacy path to drive them. Add a core API to do just that. The implementation just blacklists balloon: not too pretty, but let's not over-engineer. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> Acked-by: Cornelia Huck <cornelia.huck at de.ibm.com> --- include/linux/virtio.h | 2 ++

On Wed, 03/11 10:06, Michael S. Tsirkin wrote: > On Wed, Mar 11, 2015 at 04:09:17PM +0800, Fam Zheng wrote: > > Currently shutdown is nop for virtio devices, but the core code could > > remove things behind us such as MSI-X handler etc. For example in the > > case of virtio-scsi-pci, the device may still try to send interupts, > > which will be on IRQ lines seeing MSI-X