similar to: [PATCH 5/5] installers: fix a MinGW redefinition warning

On Wed, Feb 24, 2016 at 8:02 AM, Pete Batard via Syslinux <syslinux at zytor.com> wrote: > I get a redefinition warning on _GNU_SOURCE when compiling with MinGW, and > while I could see that this #define was introduced in e4fc44 [1], but the > reason to introduce it is not mentioned, and I can't really see a good > reason to have it, especially as MSVC will happily compile

Hi, As I am embedding part of the Syslinux code in Rufus [1], I have encountered various issues that I would like to see addressed, so that I can keep most of my code in sync with the official mainline. Some of these fixes have to do with being more friendly with MSVC compilation, and other are fixes for actual Syslinux issues, that Rufus users have encountered. For convenience, the

The variable 'ok' is never used and generates a warning. Remove it. Also ntfssect.c is designed to be compiled in non Unicode mode when using MSVC compilers, so remove all ambiguity about it (LPCTSTR -> LPCSTR, use of 'A' API calls) so that it doesn't break when compiled in Unicode mode, which is what Rufus uses with MSVC. -------------- next part --------------

Hello, Happy New Year! These patches make syslinux/linux support ext2/3/4, and it doesn't require the root privilege, I'd like to add a separate e2fs/syslinux, if that is more appropriate, it should be easy to do that. I put these patches on github so that you can easily get them in case you'd like to test them. (The repo's name is sys_tmp, which avoids confusing others, I will

More MSVC compatibility fixes, for packed structures. NB: In case you are aware of the issues that may come with MS vs GCC packing, so far, I have not seen evidence of detrimental impact from using ms_struct packing in MSVC (vs gcc_struct, which is explicitly specified for MinGW), with regards to the sections of code I am using in Rufus. -------------- next part --------------

From: Raphael S. Carvalho <raphael.scarv at gmail.com> v2: Extract ADV_SIZE automatically from libinstaller/setadv.h. Calc the size of ldlinux.sys from ldlinux.bin, and check if it exceeds the limit. ldlinux.sys must fit between the bootsector and two copies of ADV whose size may vary. Thus, the size of ldlinux.sys can be at most: 65536 - 2 * ADV_SIZE - 512 (limit). Certain file systems

On 2016.03.07 03:27, Shao Miller via Syslinux wrote: > - Casting to a uintptr_t is ugly (and not C89, not that Syslinux cares > about that) Yeah, I'd have liked to avoid that too, but some compilers will complain about pointer arithmetic logic, unless you specifically use uintptr_t. But, considering your other very valid point, let me see if I can work something better here, that

On Mon, 16 Sep, at 09:49:01AM, H. Peter Anvin wrote: > We probably will need to increase out to 4K because of newer drives. Raphael, is there any way we could extract the ADV_SIZE value from libinstaller/setadv.h and pass it to ldlinux_limit.pl? That would allow things to keep working in future when we do upgrade to 4K. -- Matt Fleming, Intel Open Source Technology Center

Hi Shao, You're right, "a=b=<immediate value>;" wasn't the actual issue. On 2016.03.06 20:34, Shao Miller via Syslinux wrote: > If this change is simply due to a mental note about an incident where a > compiler once complained about this type of thing The problem was due to the following warning when compiling for 64-bit using using the latest WDK (7600.16385.1),

On Sun, Mar 6, 2016 at 8:21 PM, Shao Miller via Syslinux <syslinux at zytor.com> wrote: > On 3/6/2016 17:03, Pete Batard via Syslinux wrote: >> >> The problem was due to the following warning when compiling for 64-bit >> using using the latest WDK (7600.16385.1), with warning level 3 (/W3): >> >> 1>c:\rufus\src\syslinux\libinstaller\syslxmod.c(44) :

On Mon, Sep 16, 2013 at 11:08 AM, Matt Fleming <matt at console-pimps.org> wrote: > Peter, does this look OK to you? > > Raphael, I can't work out why ADV_SIZE is a constant in this file? Matt, ADV_SIZE is currently a constant value, but it may change in the future. So it would need some care. Regards, Raphael S. Carvalho

Hi Shao, On 2016.02.24 23:43, Shao Miller via Syslinux wrote: > Did you happen to notice anything unusual when compiling with MinGW > under Linux, once 'ok' was removed? I seem to recall warnings about > unused results, but not of unused objects. Maybe that's an incorrect > recollection or maybe it's ancient history, however. I got no warnings with the patch on

This patch changes only strings, no program code. It is would be nice if it goes in the 6.04 release. Reported-by: Ady <ady-sf at hotmail.com> How this patch was prepared, how the editting for this patch was done Where is auxiliary written with double l? git grep -i auxilliary Which files are effect git grep -li auxilliary Changing the those files with the streaming editor sed

Hi: I've been seeing intermittent build failures with the extlinux target, and I believe I've tracked it down to a VPATH issue. See this make -d log: Finished prerequisites of target file `extlinux'. Prerequisite `extlinux.o' is newer than target `extlinux'. Prerequisite `setadv.o' is newer than target `extlinux'. Prerequisite

On 2016.03.06 13:13, Gene Cumm wrote: > Did Visual Studio actually complain about this one? WDK compiler (which I also use) if I recall correctly. At any rate, some older compilers do not like double initializations like this one, and I don't think this change should be much of a contention point, since it doesn't introduce any liability. Regards, /Pete

The _BSD_SOURCE was deprecated since glibc-2.20. _DEFAULT_SOURCE can be used instead of _BSD_SOURCE. However, there is no need to include _BSD_SOURCE because the sources only have inline functions and calls memcmp/cpy functions. Signed-off-by: Chanho Park <chanho61.park at samsung.com> --- dos/getsetsl.c | 1 - libinstaller/fs.c | 1 - libinstaller/syslxmod.c | 1 - 3 files

libfat and libinstaller compile fine using the Windows Driver Kit's compiler, except for a few warnings that are addressed with this patch. Regards, /Pete -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: 0001-lib-fix-compilation-warnings-from-MS-s-WDK.patch URL:

On Thu, Sep 18, 2014 at 12:34 AM, Chanho Park <chanho61.park at samsung.com> wrote: > The _BSD_SOURCE was deprecated since glibc-2.20. _DEFAULT_SOURCE can be > used instead of _BSD_SOURCE. However, there is no need to include > _BSD_SOURCE because the sources only have inline functions and calls > memcmp/cpy functions. Testing this myself on my build boxes, I see no issue. The

I am trying to build an RPM starting from the TAR archive. The relevant error is: make[1]: Entering directory `/tmp1/Software/rpmbuild/BUILD/syslinux-5.00/libinstaller' perl bin2c.pl syslinux_bootsect < ../core/ldlinux.bss > bootsect_bin.c perl bin2c.pl syslinux_ldlinux 512 < ../core/ldlinux.sys > ldlinux_bin.c perl bin2c.pl syslinux_mbr < ../mbr/mbr.bin > mbr_bin.c perl

This set of patches add some support for sector size >512. Currently it fixes extlinux, MBR for GPT and ext partitions. Other code is unaffected. This set of patches has been tested on a read Dell machine running a beta firmware.