similar to: nut-2.6.5:rhino.c:190: bad if test ?

The if() statement always evaluated to true. Detected by "cppcheck", not tested on real hardware. Signed-off-by: Thomas Jarosch <thomas.jarosch at intra2net.com> --- drivers/rhino.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/rhino.c b/drivers/rhino.c index ca66169..e478bcb 100644 --- a/drivers/rhino.c +++ b/drivers/rhino.c @@ -187,7 +187,7

Hello there, I just ran the sourceforge tool cppcheck over the source code of the new Linux kernel 2.6.32.4 It said 1. [./btrfs/free-space-cache.c:600]: (style) Redundant condition. It is safe to deallocate a NULL pointer The source code is                 if (info->bitmap)                         kfree(info->bitmap); I agree with cppcheck. Suggest delete the if test. 2.

Hello there, I just ran the static analysis checker "cppcheck" over the source code of icecast version 2.3.3 Amongst many other things, it said [log.c:301]: (warning) Logical conjunction always evaluates to false: log_id < 0 && log_id>= 25. Source code is ??? if (log_id < 0 && log_id>= LOG_MAXLOGS) ??????? return; Suggest replace && with ||.

Hello there, dovecot-2.2.32/src/doveadm/doveadm-mail-fetch.c:130]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses. Source code is if ((ret = doveadm_print_istream(input) < 0)) Maybe better code if ((ret = doveadm_print_istream(input)) < 0) Some duplicates: [dovecot-2.2.32/src/doveadm/doveadm-mail-fetch.c:220]: (style) Suspicious

=================================================================== "Change is such hard work." Billy Crystal =================================================================== Release Announcements ===================== This is is the latest stable release of Samba 3.6. Major enhancements in Samba 3.6.7 include: o Fix resolving our own "Domain Local" groups

=================================================================== "Change is such hard work." Billy Crystal =================================================================== Release Announcements ===================== This is is the latest stable release of Samba 3.6. Major enhancements in Samba 3.6.7 include: o Fix resolving our own "Domain Local" groups

Hello there, dovecot-2.2.33/src/lib/str-find.c:86]: (warning) Calling 'sizeof' on 'sizeof' Source code is ctx = p_malloc(pool, MALLOC_ADD(sizeof(struct str_find_context), MALLOC_MULTIPLY(sizeof(ctx->goodtab[0]), key_len))); Regards David Binderman

On Jun 19, 2019, at 11:56 AM, Silvino Benevides Magalhaes wrote: > > Unfortunately I do not use the latest versions of NUT, the driver I created, solis, was changed, not by me, and now does not work on my nobreak, which I used to create the driver. > > greetings > > Silvino B. Magalhaes Silvino, We have had several changes to solis over the years to add new models

I use Centos 7.6.1810 in my server with nut-2.7.2-4.el7.x86_64 which contains Solis version 0.60 08/18/2005, my last version. My hardware related by upsc is Microsol Solis 1.5, the same used to develop the driver. It's an ancient nobreak, but i still works, by the way, an excellent hardware, using the third set of batteries. If you need more information, please let me know. Greeting, Silvino.

A user reported a bug where we do sizeof(*ptr * count) instead of sizeof(*ptr) * count. Fix this. Reported-by: David Binderman <dcb314@hotmail.com> Signed-off-by: Josef Bacik <jbacik@fusionio.com> --- fs/btrfs/send.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c index ff40f1c..7c8964b 100644 --- a/fs/btrfs/send.c +++

Dear nut-upsdev, I writed one small function to test if batteries was really bad (using solis driver). Isn't so acurated but it's what we need. Just wait 100% batteries charge, turn off input, wait some time (10% from previst autonomy) and turn on input again. Looking startAutonomy - stopAutonomy we can know the basic batteries state. To scheduler the tests I have one new parameter on

On 6/19/19 5:59 AM, Charles Lepple wrote: >> >> “The 62-nut-usbups.rules file looks pretty standard. Do you know if the changes to 42-usb-hd-pm.rules are needed? It seems like none of the USB devices would have the right permissions if 62-nut-usbups.rules isn't sufficient (though this happened in Debian once).” >> >> My means of testing wasn’t the most rigorous,

FYI Arnaud ---------- Forwarded message ---------- From: Silvino Benevides Magalhaes <sbm2yk at gmail.com> Date: 2009/10/14 Subject: Re: about solis and rhino To: Arnaud Quette <aquette.dev at gmail.com> Hi Arnaud, I was on holiday, so I only answer you now. About rhino, I received a document contains the its protocol and a little box with rhino firmware to testing driver

==================================================================== "Laughter is inner jogging." Norman Cousins ==================================================================== Release Announcements ===================== This is is the latest stable release of Samba 3.6. Major enhancements in Samba 3.6.8 include: o Fix crash bug in smbd caused by a blocking lock

==================================================================== "Laughter is inner jogging." Norman Cousins ==================================================================== Release Announcements ===================== This is is the latest stable release of Samba 3.6. Major enhancements in Samba 3.6.8 include: o Fix crash bug in smbd caused by a blocking lock

Skipped content of type multipart/alternative-------------- next part -------------- A non-text attachment was scrubbed... Name: microsol2_nut-2.0.3.patch Type: text/x-patch Size: 83845 bytes Desc: not available Url : http://lists.alioth.debian.org/pipermail/nut-upsdev/attachments/20060706/94d79f30/microsol2_nut-2.0.3-0001.bin

Skipped content of type multipart/alternative-------------- next part -------------- A non-text attachment was scrubbed... Name: nut-patch.zip Type: application/zip Size: 18721 bytes Desc: not available Url : http://lists.alioth.debian.org/pipermail/nut-upsdev/attachments/20060706/c4c32226/nut-patch.zip

Hi, First of all I'd like to congratulate everyone engaged in this great project. I've been following this list since late 2014, when I acquired an APC UPS model BZ1200BR. APC bought a Brazilian company named Microsol, which NUT package had drivers for Solis and Rhino models. Since that time, I started developing a new driver for the models below, as a way to support my own device, but

So, I forwarded the request for highlighting trailing whitespaces to phabricator upstream (https://secure.phabricator.com/T11879), and upstream folks suggest we enable the Lint feature in Arcanist ( https://secure.phabricator.com/book/phabricator/article/arcanist_lint/). This will enforce the check when `arc diff` is run (reviewers wouldn't see the warnings though). There are two linters we

Hi Chris, et. al, I''ve recently come across cppcheck (static analyser for C code) and ran it on the current btrfs directory from Linus''s repo and it''s reported the following potential issues: linux-2.6$ cppcheck -q fs/btrfs/ [fs/btrfs/compression.c:343]: (error) Data is allocated but not initialized: cb [fs/btrfs/compression.c:583]: (error) Data is allocated but not