Skipped content of type multipart/alternative-------------- next part -------------- A non-text attachment was scrubbed... Name: nut-patch.zip Type: application/zip Size: 18721 bytes Desc: not available Url : http://lists.alioth.debian.org/pipermail/nut-upsdev/attachments/20060706/c4c32226/nut-patch.zip
Hi Silvino, 2006/7/6, Silvino B. Magalhaes <sbm2yk@gmail.com>:> > Hi nut-upsdev, > > I'm sending an attached patch file over nut-2.0.3 including a new driver > for Microsol ups rhino and an update for Microsol solis driver. It was > tested > on x86 and x86_64 archs. > >just in time, since I'm finishing 2.0.4-pre1. I'll release it tomorrow, and I'll check to include your patch. Question: does it also applies to trunk? Arnaud -- Linux / Unix Expert - MGE UPS SYSTEMS - R&D Dpt Network UPS Tools (NUT) Project Leader - http://www.networkupstools.org/ Debian Developer - http://people.debian.org/~aquette/ OpenSource Developer - http://arnaud.quette.free.fr/ -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.alioth.debian.org/pipermail/nut-upsdev/attachments/20060706/7658a953/attachment.html
On 7/6/06, Arnaud Quette <aquette.dev@gmail.com> wrote:> Question: does it also applies to trunk?I actually just tried applying it to the SVN trunk. Silvino: one of the changes since 2.0.3 is that upslog() has been renamed to upslog_with_errno() to better reflect the fact that the error message depends on the errno variable. You may want to check the code, and see if you meant to use upslogx(), which does not use errno. (send_command() may not actually set errno as the result of calling a C library function, so I think it might make more sense to use upslogx(). However, I am not familiar with the sorts of errors you might expect in send_command().) -- - Charles Lepple
> I'm sending an attached patch file over nut-2.0.3 including a new driver > for Microsol ups rhino and an update for Microsol solis driver. It was > tested on x86 and x86_64 archs.I looked at the patch and found that it by default uses the Portuguese language. While I understand (as a non-native english speaker myself) your reasons to prefer your mothertongue, I don't think it is a good idea here. The NUT drivers are not meant to be very interactive with the user. If they have to be, it is usually to aid the user in case of debugging problems in the configuration. Having to translate the messages from the driver may put some people off. Likewise, I think you should keep comments and variable names in the source files english only, since quite a few people from the NUT development team will not be able to comprehend them otherwise. Kind regards, Arjen -- Eindhoven - The Netherlands Key fingerprint - 66 4E 03 2C 9D B5 CB 9B 7A FE 7E C1 EE 88 BC 57