similar to: Enabled HTTPS for reviews.llvm.org (Arcanist certificate reinstallation required)

Thanks for the catch Dead! I'll send out patches to update .arcconfig files to use https. On Thu, Jul 14, 2016 at 3:22 PM Dean Michael Berris <dberris at google.com> wrote: > Thanks Eric, > > If you're like me who started doing this and found some weird errors, you > may have to do the following instead: > > $ arc install-certificate

Hi Ben, (+llvm-dev since the email I'm replying to wasn't sent there) 2017-11-21 17:18 GMT+01:00 Ben Hamilton via cfe-dev <cfe-dev at lists.llvm.org> : > OK. I confirmed that Stephan's process to send out cross-repo diffs from > the monorepo is not affected by my proposal. > > I'm a bit late to the party, and I might just not have comprehended this correctly.

Files '.arcconfig' still contain reference to http://llvm-reviews.chandlerc.com/, so arcanist doesn't work. Thanks, --Serge 2014-04-06 3:11 GMT+07:00 Manuel Klimek <klimek at google.com>: > On Sat, Apr 5, 2014 at 8:42 PM, Manuel Klimek <klimek at google.com> wrote: > >> Short update - the sending to the *-commits lists doesn't work yet - I'm >>

Forgot to mention: > Also, how would arcanist pick up two callsigns here? Wouldn't it just pick the from the closest surrounding .arcconfig? The review request will belong to a single repository, as you noticed (from the closest .arcconfig to where the arc command was invoked). However, when commits land, they will be imported under either one (rL for LLVM diffs) or two (rL + rC for e.g.

Hello, on a fresh install (i.e. newly-cloned arcanist and llvm-project), I get this. Any ideas? Thanks! arc install-certificate CONNECT Connecting to "https://reviews.llvm.org/api/"... Usage Exception: Failed to connect to server (https://reviews.llvm.org/api/): [HTTP/500] Internal Server Error As received by the server, this request had a nonzero content length but no POST data.

I thought so, initially. But I'm able to log in to reviews.llvm.org. Also, I assume install-certificate is before any of these considerations? On Wed, Apr 8, 2020 at 6:53 PM David Blaikie <dblaikie at gmail.com> wrote: > Hmm - I'm running a pretty old version & seems to be working for me: > > $ arc version > > arcanist 3b6b523c2b236e3724a1e115f126cb6fd05fa128 (18

I've gone through Code Reviews with Phabriactor[1], Arcanist Quick Start[2] and Arcanist User Guide arc diff[3]. But I'm unable to setup reviewers my editor pops up and there is a "Reviewers:" line and but I'm unable email addresses directly. It seems it wants reviewers passed on the command line or some how in .arcconfig. But I haven't been able to find any

Short update - the sending to the *-commits lists doesn't work yet - I'm currently working on fixing that (basically getting reviews at reviews.llvm.orgsubscribed to the list) On Sat, Apr 5, 2014 at 8:37 PM, Renato Golin <renato.golin at linaro.org>wrote: > Nice work! It's a lot faster now, thanks! > > --renato > > PS: I'm not really bothered with a redirect

It seems like this has already been set up for all the projects except for libunwind. Can we create a Differential repository for it as well? I'll be happy to update its .arcconfig once that's done. On Mon, Nov 27, 2017 at 9:02 AM Ben Hamilton via llvm-dev < llvm-dev at lists.llvm.org> wrote: > Forgot to mention: > > > > Also, how would arcanist pick up two callsigns

Hi, I recently tried reviewing/committing some of my code on Phabricator/Arcanist for the first time and I noticed that the docs [1] ask for feedback, so here it is! Phabricator functions reasonably well and it is a lot easier to write comments and respond to comments on particular parts of code as opposed to the old way of copy and pasting patches into e-mails sent to llvm-commits. Two minors

+llvm-dev, so we get wider input :) Given how unfortunate reviews that are started without cc'ing the right list are (basically folks need to re-send the review from scratch), I support this idea. Ben, couldn't rL still be available for all projects? (and be the main project for LLVM). On Tue, Nov 21, 2017 at 5:18 PM Ben Hamilton via cfe-dev < cfe-dev at lists.llvm.org> wrote:

On Thu, Nov 23, 2017 at 12:58 AM Ben Hamilton <benhamilton at google.com> wrote: > Absolutely — I should have mentioned that we would keep the main rL > project and continue to use it. > Your original email said "Moving forward, only LLVM commits will be identified with the prefix rL (as in https://reviews.llvm.org/rL12345) — each project will get its own unique prefix, which

Hi, I tried to commit the Differential revision D3021 with the "arc commit" command. While it showed that the command succeeded and the Differential revision was closed, I can't find the revision anywhere in the SVN repository or the GIT mirror. Did I forget something? I tried a manual commit a few days ago and it worked. I've put the output of the "arc

> On Jan 7, 2016, at 9:57 AM, Mehdi Amini via llvm-dev <llvm-dev at lists.llvm.org> wrote: > >> >> On Jan 7, 2016, at 9:45 AM, David Blaikie via llvm-dev <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>> wrote: >> >> >> >> On Sun, Dec 27, 2015 at 10:59 PM, Manuel Klimek via llvm-dev <llvm-dev at lists.llvm.org

On Sun, Dec 27, 2015 at 10:59 PM, Manuel Klimek via llvm-dev < llvm-dev at lists.llvm.org> wrote: > Hi Dan, thanks for the feedback. > > On Mon, Dec 28, 2015 at 6:24 AM Dan Liew <dan at su-root.co.uk> wrote: > >> Hi, >> >> I recently tried reviewing/committing some of my code on >> Phabricator/Arcanist for the first time and I noticed that the docs

On 10 January 2018 at 21:06, Petr Hosek via llvm-dev <llvm-dev at lists.llvm.org> wrote: > It seems like this has already been set up for all the projects except for > libunwind. Can we create a Differential repository for it as well? I'll be > happy to update its .arcconfig once that's done. Additionally, it might be worth considering if this change means the guidance

> On 8 Jan 2016, at 15:43, Krzysztof Parzyszek via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > On 1/8/2016 9:39 AM, Joerg Sonnenberger via llvm-dev wrote: >> >> Huh? Under "Leap into action" on the bottom of the page, there is "Close >> revision". > > Hmm. Indeed. I don't know why I didn't notice it before. Oh well,

On Fri, Jan 08, 2016 at 09:29:01AM -0600, Krzysztof Parzyszek via llvm-dev wrote: > On 1/7/2016 1:08 PM, Matthias Braun via llvm-dev wrote: > > > >One thing that bit me a few times is the fact that the Differential > >Revision: line must be the last (non-empty) line in the commit message. > >If you add things like “This fixes …” behind it then it won’t get >

Hi, > Interesting, I don't read it that way :) I personally don't use arc to > commit. Sure the docs don't explicitly state that it's the only way. I just took that to be implied because the instructions for requesting a review provide multiple methods but the instructions for committing only mention using a single method. > Again, there is no one correct way. You can

Hi, One takeaway for me from the recent Phabricator vs Github PR discussions was that arc (arcanist) can be a pain to set up and may pose a hurdle for some contributors. I think those points could be addressed relatively easily by adding a llvm-patch script (or an even better name) that allows users to create and apply patches from reviews.llvm.org using Phabricators API. In my experience, the