similar to: [LLVMdev] [PATCH] OpenCL half support

I've got comments on the code change. The test cases look ok, but I haven't fully checked the math on the half-values. I checked with reference to trunk top-of-tree at revision 156617. I have not compiled the code. lib/AsmParser/LLLexer.cpp Adds support to parse format: 0xH<hexdigits> Tha 0xH format should be described in LangRef.html alongside 0xK<hex> and

On Jul 13, 2011, at 4:26 AM, Anton Lokhmotov wrote: > Hi Chris, > > We have updated the half patch for TOT. Could you review please? Sorry for the delay, some thoughts: +++ b/include/llvm/Bitcode/LLVMBitCodes.h @@ -110,10 +110,12 @@ namespace bitc { TYPE_CODE_METADATA = 16, // METADATA TYPE_CODE_X86_MMX = 17, // X86 MMX + + TYPE_CODE_HALF = 18, // IEEE

On May 20, 2011, at 6:48 AM, Anton Lokhmotov wrote: > Hi Chris, > >> Sorry for dropping this. Can you resend your current patch? Lets just >> start and iterate on the llvm patch first. > Please find the LLVM patch attached. Hi Anton, This looks like a great start, but it needs a lot of testcases showing that these things constant fold, handle conversions correctly, and

On Mar 21, 2011, at 1:59 PM, Zhang, Chihong wrote: > Hi Chris, > > It is important for embedded/mobile computation to have efficient fp16 support, otherwise those users will suffer from the merging problem with their local LLVM with native fp16 type they add (locally). So we should either add full fp16 support as a basic floating point type or enhance the LLVM infrastructure to make

Could someone please commit the attached patches? /* Approved by: - Anton Korobeynikov: http://lists.cs.uiuc.edu/pipermail/llvmdev/2012-May/049849.html - Micah Villmow: http://lists.cs.uiuc.edu/pipermail/llvmdev/2012-May/049848.html - David Neto: http://lists.cs.uiuc.edu/pipermail/llvmdev/2012-May/049705.html */ Many thanks, Anton. -----Original Message----- From: Anton Lokhmotov

Hi Chris, It is important for embedded/mobile computation to have efficient fp16 support, otherwise those users will suffer from the merging problem with their local LLVM with native fp16 type they add (locally). So we should either add full fp16 support as a basic floating point type or enhance the LLVM infrastructure to make floating point type as scalable as int type. -Chihong -----Original

On Mar 21, 2011, at 3:44 AM, Anton Lokhmotov wrote: >> Adding half float to LLVM IR is *only* reasonable if you have hardware >> that supports half float, or if you want to add softfloat operations >> for these. > Yes, our graphics hardware natively supports some fp16 arithmetic > operations. Ok. >> Just like C compilers need to know sizeof(long), sizeof(void*) and

On Feb 23, 2011, at 10:01 AM, Anton Lokhmotov wrote: > Please find attached Clang/LLVM patches for supporting 'half' - the > half-precision floating-point type, which in particular is used in OpenCL C. > Please review. > > Background and motivation. Whilst the half type is defined by IEEE 754-2008 > as storage only (i.e. no arithmetic is supposed to be performed on

> Anton, would it be possible to add information to the documentation > here: > http://llvm.org/docs/BitCodeFormat.html Sure! Any further comments? Many thanks, Anton. -------------- next part -------------- A non-text attachment was scrubbed... Name: half-doc.patch Type: application/octet-stream Size: 657 bytes Desc: not available URL:

looks good here. > -----Original Message----- > From: llvmdev-bounces at cs.uiuc.edu [mailto:llvmdev-bounces at cs.uiuc.edu] > On Behalf Of Anton Lokhmotov > Sent: Thursday, May 17, 2012 4:51 AM > To: 'David Neto' > Cc: llvmdev at cs.uiuc.edu > Subject: Re: [LLVMdev] [PATCH] OpenCL half support > > Hi David, > > Many thanks for the comments! > >

Anton, would it be possible to add information to the documentation here: http://llvm.org/docs/BitCodeFormat.html > -----Original Message----- > From: llvmdev-bounces at cs.uiuc.edu [mailto:llvmdev-bounces at cs.uiuc.edu] > On Behalf Of Villmow, Micah > Sent: Thursday, May 17, 2012 9:04 AM > To: Anton.Lokhmotov at arm.com; 'David Neto' > Cc: llvmdev at cs.uiuc.edu >

> -----Original Message----- > From: llvmdev-bounces at cs.uiuc.edu [mailto:llvmdev-bounces at cs.uiuc.edu] > On Behalf Of Chris Lattner > Sent: Friday, March 18, 2011 1:15 PM > To: Anton.Lokhmotov at arm.com > Cc: llvmdev at cs.uiuc.edu > Subject: Re: [LLVMdev] [PATCH] OpenCL half support > > > On Mar 17, 2011, at 10:17 AM, Anton Lokhmotov wrote: > > > Hi

2008/12/31 Chris Lattner <clattner at apple.com> > On Dec 30, 2008, at 2:54 PM, Talin wrote: > > OK changes made and new patch attached. > > +++ utils/unittest/Makefile (revision 0) > > ... > +# This has to come after Makefile.common, since it doesn't allow us to > +# override the VPATH value unless we set PROJECT_NAME, which we don't want > +# to do.

<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> <html> <head> <meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type"> </head> <body bgcolor="#ffffff" text="#000000"> <br> <br> Villmow, Micah wrote: <blockquote

On Mar 17, 2011, at 10:17 AM, Anton Lokhmotov wrote: > Hi Chris, > > So what do you think about this proposal? If you agree, it would be good to > include the patch into the 2.9 release (to avoid breaking compatibility > later). Hi Anton, I'm sorry I don't have the patch anymore. Please resend. It is too late for new features in 2.9 though. >> The last paragraph

> Maybe worth pointing out that there are architectures that natively support > 16bit floating point in llvm. PTX, the new backend of which has just been > added to 2.9 can handle fp16 -> fp32 conversion in hardware. FWIW: there are already intrinsics for such conversions (currently only used in ARM backend). There is no need for new type if you want just to convert stuff. -- With

Hi Anton, Sorry for dropping this. Can you resend your current patch? Lets just start and iterate on the llvm patch first. -Chris On Mar 22, 2011, at 10:40 AM, Anton Lokhmotov wrote: > Chris Lattner wrote: >> I'm sorry I don't have the patch anymore. Please resend. > Attached. (Copying to cfe-dev, as the patch is dual Clang/LLVM.) > > Anton Korobeynikov wrote:

Hi David, Many thanks for the comments! > Tha 0xH format should be described in LangRef.html alongside > 0xK<hex> and 0xM<hex> Done. > Declaration of "int shiftcount" should be moved to smallest nesting > possible, right after "if ( const ConstantFP ..." at line 710 > > (The code makes a lot more sense with a good comment on the

> I can work around this by removing the two references to __eprintf > from lib/System/Win32/DynamicLibrary.inc, but... why are they there in > the first place, and why don't I have __eprintf on my system? > > I see that these references were introduced here: > > http://llvm.org/viewvc/llvm-project?view=rev&revision=52037 > > but I don't understand what they

I put in two slightly different fixes that I believe should cover the problem: http://llvm.org/viewvc/llvm-project?view=rev&revision=156837 http://llvm.org/viewvc/llvm-project?view=rev&revision=156838 Let me know if your experience disagrees. I'll try and get these into 3.1 if Bill lets me after the buildbots give a check mark. - Daniel On Tue, May 15, 2012 at 5:38 AM, Keno