similar to: [LLVMdev] Checking llvm-config status code

On Aug 29, 2010, at 11:01 AM, Yuri Gribov wrote: > Hi all, > > Will anyone object to (my) adding llvm-config error code check in > Makefile.rules? I had errors in target definition which called early > abort of llvm-config in Makefile. These went undetected and caused > tons of following errors in other modules (because llvm-config failed > to generate appropriate cmdline

Hm, it turns out that only GNU make has $(error...). Does anyone know how we can simulate it in generic make? For GNU it's easy but ugly: LlvmConfigResult := $(shell $(LLVM_CONFIG) --libs $(LINK_COMPONENTS) || echo Error) ifeq ($(LlvmConfigResult),Error) $(error llvm-config failed) endif LLVMLibsOptions += $(LlvmConfigResult) -Yuri

Hi Takumi, > Any feedbacks are welcome. > Have fun! This seems to be pretty useful addition to LLVM on windows! And it seems the only painless way to make plugins working, yay! For me the patch looks pretty good. One minor thing: could you please rename SharedDir => SharedLibDir Thanks! -- With best regards, Anton Korobeynikov Faculty of Mathematics and Mechanics, Saint Petersburg

Good summer, all! This patch enables ENABLE_SHARED=1 to build DLL based LLVM toolchain. I have checked this on Cygwin-1.5, Cygwin-1.7, mingw(msysgit) and mingw-cross-fedora12. I can separate this patch into some parts; cleanups, adding definitions and adding rules. Any feedbacks are welcome. Have fun! ...Takumi * Pros - reduction of linking time of toolchain. - capability of -load

> Is this just a textual/syntactic thing?  If so, you should add a bit to MCAsmInfo to indicate that this is the behavior, and MCAsmPrinter should be changed to emit labels in this syntax. Thanks! This should be enough. -Yuri

My internet is finally back. Could someone verify and submit this patch? I have verified build, tests and unittests on X86. On Sun, Sep 19, 2010 at 9:16 AM, Yuri Gribov <tetra2005 at googlemail.com> wrote: >> Is this just a textual/syntactic thing?  If so, you should add a bit to MCAsmInfo to indicate that this is the behavior, and MCAsmPrinter should be changed to emit labels in this

On Thu, Jan 14, 2016 at 3:43 AM, Paul Pluzhnikov <ppluzhnikov at google.com> wrote: > On Wed, Jan 13, 2016 at 4:17 PM, Kostya Serebryany <kcc at google.com> wrote: >> Inviting Paul to the party (he wrote the libstdc++ sort checker). >> >> On Tue, Jan 12, 2016 at 11:09 PM, Yury Gribov <y.gribov at samsung.com> wrote: >>> >>> On 01/13/2016

Ah, so LLVM already requires GNU make. Fine, than I'll submit the patch in the evening. - Yuri Gribov

Inviting Paul to the party (he wrote the libstdc++ sort checker <https://gcc.gnu.org/svn/gcc/branches/google/gcc-4_9/libstdc++-v3/include/bits/stl_algo.h> ). On Tue, Jan 12, 2016 at 11:09 PM, Yury Gribov <y.gribov at samsung.com> wrote: > On 01/13/2016 10:08 AM, Yury Gribov wrote: > >> On 01/13/2016 09:57 AM, Kostya Serebryany wrote: >> >>> On Tue, Jan 12,

On 01/13/2016 09:57 AM, Kostya Serebryany wrote: > On Tue, Jan 12, 2016 at 10:28 PM, Yury Gribov <y.gribov at samsung.com> wrote: > >> On 01/13/2016 03:10 AM, Kostya Serebryany wrote: >> >>> FTR, here is one way to implement this in the library: >>> >>> https://gcc.gnu.org/svn/gcc/branches/google/gcc-4_9/libstdc++-v3/include/bits/stl_algo.h

On Wed, Dec 18, 2019 at 3:38 AM Iurii Gribov via llvm-dev < llvm-dev at lists.llvm.org> wrote: > (Readding Hal) > > > Are you suggesting that we should be more aggressive by default (i.e. > without -fvisibility=hidden or any new options)? > > I believe that will be too aggressive for class LTO visibility. > > It is common to override a virtual functions across

On 01/13/2016 03:10 AM, Kostya Serebryany wrote: > FTR, here is one way to implement this in the library: > https://gcc.gnu.org/svn/gcc/branches/google/gcc-4_9/libstdc++-v3/include/bits/stl_algo.h > Search for "check sort predicate for strict weak ordering" Nice, although this wouldn't catch violations of transitivity (which is probably the most important type of bug).

Ok guys, Here is the patch (I also had to update lib/CompilerDriver/Makefile because it tries to run llvm-config without building it!). I checked that build works and errors in llvm-config are properly detected. Could someone verify and commit it? I do not have write access to svn (how can I get one BTW?). -Yuri Gribov -------------- next part -------------- A non-text attachment was

Hi all, I am emitting code for assembler which wants non-standard text for labels (not just "LABEL:"). One way would be to override all methods of AsmPrinter which call MCStreamer::EmitLabel but this is too painful. I can think of two solutions: 1) add AsmPrinter::EmitLabel which calls Streamer by default but may be overriden in target AsmPrinters 2) Register my own instance of

Yuri, > Hm, it turns out that only GNU make has $(error...). Does anyone know > how we can simulate it in generic make? $(error) is implemented since 3.78. LLVM requires 3.79. ...Takumi

(+correct cfe-dev list) On Tue, Jan 12, 2016 at 2:57 PM, Alexey Samsonov <vonosmas at gmail.com> wrote: > Hi Yuri, > > On Mon, Jan 11, 2016 at 9:53 AM, Yury Gribov via llvm-dev < > llvm-dev at lists.llvm.org> wrote: > >> Hi all, >> >> UndefinedBehaviorSanitizer currently does not check for undefined >> behaviors which result from improper usage

On Thu, Dec 18, 2014 at 11:05 PM, Yury Gribov <y.gribov at samsung.com> wrote: > > On 12/19/2014 01:14 AM, Nick Lewycky wrote: > >> On 12/16/2014 02:43 AM, Yury Gribov wrote: >> >>> On 12/15/2014 10:24 PM, Ismail Pazarbasi wrote: >>> >>>> s.d = 42.0; >>>> if (s.l > 100) // fire here >>>> >>>

Anton, Thanks for your comment. 2nd patch attached. - s/SharedDir/SharedLibDir/g - move prefix=cyg sunk into if(cygwin or mingw) arigato gozaimasu...Takumi * Additional issues - You may build LLVMHello.dll but I don't modify lib/Transforms/Makefile. Because making LLVMHello.dll requires the library LLVM.dll, but it oughta be on the way to making libs at building

Chris, I want to emit code for target which uses non-standard assembler which wants labels to look like LAB nop instead of LAB: I can not do this because labels are emitted by MCAsmStreamer::EmitLabel which can not be overriden. Best regards, Yuri

On 12/16/2014 02:43 AM, Yury Gribov wrote: > On 12/15/2014 10:24 PM, Ismail Pazarbasi wrote: >> s.d = 42.0; >> if (s.l > 100) // fire here > > Note that code like this is frequently used to convert integers to > floats so you'll get tons of false positives. True positives. The fix is to use memcpy instead. Emitting error for > accessing differently