Hi all, Will anyone object to (my) adding llvm-config error code check in Makefile.rules? I had errors in target definition which called early abort of llvm-config in Makefile. These went undetected and caused tons of following errors in other modules (because llvm-config failed to generate appropriate cmdline strings for g++). - Yuri
On Aug 29, 2010, at 11:01 AM, Yuri Gribov wrote:> Hi all, > > Will anyone object to (my) adding llvm-config error code check in > Makefile.rules? I had errors in target definition which called early > abort of llvm-config in Makefile. These went undetected and caused > tons of following errors in other modules (because llvm-config failed > to generate appropriate cmdline strings for g++).Seems reasonable to me, depending on what the impact is. -Chris
Hm, it turns out that only GNU make has $(error...). Does anyone know how we can simulate it in generic make? For GNU it's easy but ugly: LlvmConfigResult := $(shell $(LLVM_CONFIG) --libs $(LINK_COMPONENTS) || echo Error) ifeq ($(LlvmConfigResult),Error) $(error llvm-config failed) endif LLVMLibsOptions += $(LlvmConfigResult) -Yuri