similar to: [LLVMdev] Win32 COFF Support patch 5 (the final patch in the saga!)

On Mon, Jul 26, 2010 at 12:04 PM, Aaron Gray <aaronngray.lists at gmail.com> wrote: > You probably want to add Cygwin and MinGW32 Triples as well :- >    case Triple::Win32: > +  case Triple::Cygwin: > +  case Triple::MinGW32: >      return new WindowsX86AsmBackend (T); > Aaron Can someone test this on those platforms? That change would effect quite a few people. -

On 26 July 2010 04:35, Michael Spencer <bigcheesegs at gmail.com> wrote: > Attached is the 5th and final patch of the beginning of COFF support > for MC. It simply makes the X86 backend use it on Win32 targets and > tests it. > > You probably want to add Cygwin and MinGW32 Triples as well :- case Triple::Win32: + case Triple::Cygwin: + case Triple::MinGW32: return

On 26 July 2010 18:08, Michael Spencer <bigcheesegs at gmail.com> wrote: > On Mon, Jul 26, 2010 at 12:04 PM, Aaron Gray <aaronngray.lists at gmail.com> > wrote: > > You probably want to add Cygwin and MinGW32 Triples as well :- > > case Triple::Win32: > > + case Triple::Cygwin: > > + case Triple::MinGW32: > > return new

Daniel somehow replied to one of my previous commits on llvm-commits instead of this thread. On Mon, Jul 26, 2010 at 12:41 AM, Daniel Dunbar <daniel at zuster.org> wrote: > Hi Michael, > > Two minor notes: > -- >> diff --git a/lib/Target/X86/X86AsmBackend.cpp b/lib/Target/X86/X86AsmBackend.cpp >> index 2cf65c1..02ac2be 100644 >> ---

On Mon, Jul 26, 2010 at 7:25 PM, Michael Spencer <bigcheesegs at gmail.com> wrote: > Daniel somehow replied to one of my previous commits on llvm-commits > instead of this thread. > > On Mon, Jul 26, 2010 at 12:41 AM, Daniel Dunbar <daniel at zuster.org> wrote: >> Hi Michael, >> >> Two minor notes: >> -- >>> diff --git

On Fri, Jul 30, 2010 at 1:28 PM, Daniel Dunbar <daniel at zuster.org> wrote: > On Mon, Jul 26, 2010 at 7:25 PM, Michael Spencer <bigcheesegs at gmail.com> wrote: >> Daniel somehow replied to one of my previous commits on llvm-commits >> instead of this thread. >> >> On Mon, Jul 26, 2010 at 12:41 AM, Daniel Dunbar <daniel at zuster.org> wrote:

On Fri, Jul 30, 2010 at 11:05 AM, Michael Spencer <bigcheesegs at gmail.com> wrote: > On Fri, Jul 30, 2010 at 1:28 PM, Daniel Dunbar <daniel at zuster.org> wrote: >> On Mon, Jul 26, 2010 at 7:25 PM, Michael Spencer <bigcheesegs at gmail.com> wrote: >>> Daniel somehow replied to one of my previous commits on llvm-commits >>> instead of this thread.

On Fri, Jul 30, 2010 at 7:54 PM, Michael Spencer <bigcheesegs at gmail.com> wrote: > On Fri, Jul 30, 2010 at 2:34 PM, Daniel Dunbar <daniel at zuster.org> wrote: >> On Fri, Jul 30, 2010 at 11:05 AM, Michael Spencer <bigcheesegs at gmail.com> wrote: >>> I tried setting these to false, but the resulting executable (made >>> with link.exe) crashed. I

On Fri, Jul 30, 2010 at 2:34 PM, Daniel Dunbar <daniel at zuster.org> wrote: > On Fri, Jul 30, 2010 at 11:05 AM, Michael Spencer <bigcheesegs at gmail.com> wrote: >> I tried setting these to false, but the resulting executable (made >> with link.exe) crashed. I looked at the differences in the object >> file, but couldn't figure out what was causing it. I'm

On Mon, Jun 21, 2010 at 9:37 AM, Aaron Gray <aaronngray.lists at gmail.com> wrote: > > Whats going on with having both write_uint32_le() > in WinCOFFObjectWriter::DefineSection() and WriteLE32() in > WinCOFFObjectWriter::WriteFileHeader() ? > Aaron Thanks, missed that one. Nathan used write_uint32_le in WinCOFF.h, and I guess accidentally used it in WinCOFFObjectWriter.cpp.

I have updated my patch based on Chris'es feedback. I removed the dbgout_calls macro, but left others in place for now. If there are no objections, I would like to commit this tomorrow evening (~7PM GMT-7). I have compiled and tested it on MSVC, with Michaels testing code and it looks good. Once this is committed, Michaels patch can be applied. -Nathan -------------- next part --------------

On 28 May 2010 05:59, Nathan Jeffords <blunted2night at gmail.com> wrote: > For those that are interested, I have attached the latest version of my > Win32 COFF support patch. There is no new functionality, I just fixed some > compiler errors due to recent changes in the MC library. > > Nathan, Sorry about this but... On Cygwin with GCC-4.2.4 :- In file included from

On 2 May 2010 19:32, Nathan Jeffords <blunted2night at gmail.com> wrote: > Thanks for both of your feedback, I will attempt to make it fit LLVM coding > standards better before I resubmit my work. You can send me early drafts to run past GCC, send me something that works. As far as the hooks I put in, they are really only there so I could build > the object exporter outside of

write_uint32_le is used to write into a arbitrary data buffer, where as WriteLE32 is used to write into the object file. On Mon, Jun 21, 2010 at 9:01 AM, Michael Spencer <bigcheesegs at gmail.com>wrote: > On Mon, Jun 21, 2010 at 9:37 AM, Aaron Gray <aaronngray.lists at gmail.com> > wrote: > > > > Whats going on with having both write_uint32_le() > > in

On Sun, May 2, 2010 at 1:47 PM, Aaron Gray <aaronngray.lists at googlemail.com>wrote: > On 2 May 2010 19:32, Nathan Jeffords <blunted2night at gmail.com> wrote: > >> Thanks for both of your feedback, I will attempt to make it fit LLVM >> coding standards better before I resubmit my work. > > > You can send me early drafts to run past GCC, send me something

I just finished the initial split up of WinCOFF.h into llvm/Support/COFF.h and lib/MC/WinCOFFObjectWriter.cpp. This includes almost the minimum changes required to split them up. WinCOFFObjectWriter now needs some refactoring to make things more consistent and less verbose. There also seem to be quite a few memory leaks that need to be resolved.

On Wed, Jun 23, 2010 at 12:22 AM, Michael Spencer <bigcheesegs at gmail.com> wrote: > I'm now going to make the stub patches that Daniel requested. Added llvm/Support/COFF.h and merged in COFF constants from llvm/MC/MCSectionCOFF.h. Zeroth patch is done. http://github.com/Bigcheese/llvm-mirror/commit/2d88aa08a072bb5f8d687b67d1476f23d37a87d4 A svn-style patch against svn HEAD is

On Tue, Sep 28, 2010 at 7:39 PM, Michael Spencer <bigcheesegs at gmail.com> wrote: > On Sun, Sep 26, 2010 at 5:27 PM, Nathan Jeffords > <blunted2night at gmail.com> wrote: >> Hi guys, >> While trying to get dwarf debugging information to work with Win32 COFF >> targets, I came across a couple of issues with the current implementation >>

On Sun, Sep 26, 2010 at 6:47 PM, Nathan Jeffords <blunted2night at gmail.com> wrote: > On Sun, Sep 26, 2010 at 3:28 PM, Michael Spencer <bigcheesegs at gmail.com> > wrote: >> >> On Sun, Sep 26, 2010 at 5:27 PM, Nathan Jeffords >> <blunted2night at gmail.com> wrote: >> > Hi guys, >> > While trying to get dwarf debugging information to work

On Sun, Sep 26, 2010 at 3:28 PM, Michael Spencer <bigcheesegs at gmail.com>wrote: > On Sun, Sep 26, 2010 at 5:27 PM, Nathan Jeffords > <blunted2night at gmail.com> wrote: > > Hi guys, > > While trying to get dwarf debugging information to work with Win32 COFF > > targets, I came across a couple of issues with the current implementation > > of