similar to: [LLVMdev] [PATCH] Circular Buffered Debug Stream

On Tuesday 15 December 2009 15:21, David Greene wrote: > Please review and let me know what needs to change before I start > merging stuff in. I left in quite a few unnecessary headers from previous incarnations (streambuf, etc.). I will fix those. Please comment on the rest. -Dave

On Dec 15, 2009, at 2:53 PM, David Greene wrote: > On Tuesday 15 December 2009 15:21, David Greene wrote: > >> Please review and let me know what needs to change before I start >> merging stuff in. > > I left in quite a few unnecessary headers from previous incarnations > (streambuf, etc.). I will fix those. Please comment on the rest. Hi David, Please send complete

On Tuesday 15 December 2009 23:02, Chris Lattner wrote: > On Dec 15, 2009, at 6:33 PM, David Greene wrote: > > On Tuesday 15 December 2009 20:11, Chris Lattner wrote: > >> Please send complete and minimal patches to avoid wasting reviewer's > >> time, > > > > What do you want, complete or minimal? I don't want to pre-send 50 > > or so patches

On Dec 15, 2009, at 6:33 PM, David Greene wrote: > On Tuesday 15 December 2009 20:11, Chris Lattner wrote: > >> Please send complete and minimal patches to avoid wasting reviewer's >> time, > > What do you want, complete or minimal? I don't want to pre-send 50 > or so patches (one per source file) that simply change errs() to dbgs(). > Thus I thought I

On Tuesday 15 December 2009 20:11, Chris Lattner wrote: > Please send complete and minimal patches to avoid wasting reviewer's > time, What do you want, complete or minimal? I don't want to pre-send 50 or so patches (one per source file) that simply change errs() to dbgs(). Thus I thought I would send a patch representative of what will happen. What, specifically, do you want

On Friday 18 December 2009 12:28, Chris Lattner wrote: > This is looking a lot better, here are some more comments: > > + /// current_pos - Return the current position within the stream, > > + /// not counting the bytes currently in the buffer. > > + virtual uint64_t current_pos() { > > I didn't notice this earlier, but is there any reason for current_pos

On Friday 18 December 2009 20:20, David Greene wrote: > I wanted something to signify in the output where the debug dump starts. > That's for that case where some stuff might still get output through > errs(). I anticipate that while I'll change most uses of errs() to dbgs(), > we probably don't want to change all of them. > > I agree the naming here is poor.

On Dec 21, 2009, at 8:05 AM, David Greene wrote: > On Friday 18 December 2009 20:20, David Greene wrote: > >> I wanted something to signify in the output where the debug dump starts. >> That's for that case where some stuff might still get output through >> errs(). I anticipate that while I'll change most uses of errs() to dbgs(), >> we probably don't

On Monday 21 December 2009 13:40, Chris Lattner wrote: > >> Now that I understand the model :) I don't see why you need to fiddle > >> with the underlying buffering of TheStream. In the dbgs() use case, > >> the underlying stream will be errs() which is already unbuffered. > > > > Might circular_raw_ostream be used with other streams at some point? >

On Dec 18, 2009, at 11:53 AM, David Greene wrote: > On Friday 18 December 2009 12:28, Chris Lattner wrote: > >> This is looking a lot better, here are some more comments: >>> + /// current_pos - Return the current position within the >>> stream, >>> + /// not counting the bytes currently in the buffer. >>> + virtual uint64_t current_pos()

On Friday 18 December 2009 19:47, Chris Lattner wrote: > On Dec 18, 2009, at 3:46 PM, David Greene wrote: > > + /// circular_raw_ostream - A raw_ostream that saves its output in a > > + /// circular buffer. > > A better description would be "which *can* save its data to a circular > buffer, or can pass it through directly to an underlying stream if > specified

On Dec 18, 2009, at 3:46 PM, David Greene wrote: > > + /// circular_raw_ostream - A raw_ostream that saves its output in a > + /// circular buffer. A better description would be "which *can* save its data to a circular buffer, or can pass it through directly to an underlying stream if specified with a buffer of zero." When it is buffering, what causes it to flush? Your

On Wednesday 16 December 2009 13:35, David Greene wrote: > > Please make BufferSize an 'unsigned' and default it to 8192. Please use > > PRESERVE_STREAM instead of 'false'. Here's an updated version of the circular buffer. Ok to check in? -Dave Index: include/llvm/Support/circular_raw_ostream.h

On Dec 17, 2009, at 3:41 PM, David Greene wrote: > On Wednesday 16 December 2009 13:35, David Greene wrote: > >>> Please make BufferSize an 'unsigned' and default it to 8192. Please use >>> PRESERVE_STREAM instead of 'false'. > > Here's an updated version of the circular buffer. Ok to check in? This is looking a lot better, here are some more

On Friday 18 December 2009 17:27, David Greene wrote: > > Here's the updated patch. > > Well, that didn't go through right. Here it is again. Argh! Stupid bug fixed. :) Index: include/llvm/Support/circular_raw_ostream.h =================================================================== --- include/llvm/Support/circular_raw_ostream.h (revision 0) +++

On Dec 16, 2009, at 8:12 AM, David Greene wrote: >>> >>> What, specifically, do you want reviewed before I start checking in? >>> I'll be happy to prepare a patch that shows just that. >> >> I want a patch that does one thing (e.g. implements dbgs(), > > Ok, let's start with that. Here's the patch to add the circular raw_ostream. This

On Friday 18 December 2009 17:22, David Greene wrote: > On Friday 18 December 2009 13:56, David Greene wrote: > > On Friday 18 December 2009 13:53, David Greene wrote: > > > > > + void releaseStream() { > > > > > + // Delete the stream if needed. Otherwise, transfer the > > > > > buffer + // settings from this raw_ostream back to

On Friday 18 December 2009 13:56, David Greene wrote: > On Friday 18 December 2009 13:53, David Greene wrote: > > > > + void releaseStream() { > > > > + // Delete the stream if needed. Otherwise, transfer the buffer > > > > + // settings from this raw_ostream back to the underlying > > > > stream. + if (!TheStream) > > >

On Friday 18 December 2009 13:53, David Greene wrote: > > > + void releaseStream() { > > > + // Delete the stream if needed. Otherwise, transfer the buffer > > > + // settings from this raw_ostream back to the underlying stream. > > > + if (!TheStream) > > > + return; > > > + if (DeleteStream) > > > +

On Monday 21 December 2009 14:20, David Greene wrote: > Attached an updated patch. Ping? -Dave