similar to: [LLVMdev] svn pre-commit hook: help needed

On Tue, Feb 17, 2009 at 02:21:23PM -0800, Scott Michel wrote: > Anyone out there interested in helping out with a subversion pre-commit hook > to: > > - remove trailing whitespace, > - expand tabs to spaces, > - detect 80-col violations, > > as well as detect other style guideline breakage? > > I just ran into the trailing whitespace problem: Eclipse and other

On Feb 18, 2009, at 1:41 AM, Julien Lerouge wrote: > Yet another _fun_ way of doing this is to setup a buildbot slave just > for that. The slave can fix minor stuff like tabs and trailing > whitespaces on its own (checking the changes back in), and yell for > things like 80-col violations and whatnot where the changes would > not be > so trivial. If you're going to change

For the complete truth in advertising, this was pretty much a trial balloon to gauge reaction. I'm not a big fan of rejecting commits for style violations, but the dev guide has certain guidelines regarding formatting and style. And we're all supposed to be good citizens... My biggest nit, however, was contemplating a commit where 80%+ was trailing whitespace trimming. Yeah, my editor

Anyone out there interested in helping out with a subversion pre-commit hook to: - remove trailing whitespace, - expand tabs to spaces, - detect 80-col violations, as well as detect other style guideline breakage? I just ran into the trailing whitespace problem: Eclipse and other editors like to trim excess whitespace from source. However, when one commits a patch with trailing whitespace

On Wed, Jul 30, 2008 at 03:06:54PM -0700, Julien Lerouge wrote: > On Wed, Jul 30, 2008 at 11:32:18AM -0700, Bill Wendling wrote: > > On Jul 30, 2008, at 11:17 AM, Julien Lerouge wrote: > >> ../../../llvm-gcc4.2-src/gcc/libgcc2.c:2095: error: conflicting types > >> for 'VirtualProtect' > >> > >>

On Wed, Jul 30, 2008 at 11:32:18AM -0700, Bill Wendling wrote: > On Jul 30, 2008, at 11:17 AM, Julien Lerouge wrote: >> ../../../llvm-gcc4.2-src/gcc/libgcc2.c:2095: error: conflicting types >> for 'VirtualProtect' >> >> c:/cygwin/home/jlerouge/buildbot/llvm/lib/../include/winbase.h:1998: >> error: previous declaration of 'VirtualProtect' was here

Hi is anybody using the svn pre-commit hook from http://www.reductivelabs.com/trac/puppet/wiki/VersionControlPuppet with 0.24.1 . It was working fine with 0.23.1 and I like it to test stupid typos before checking in. However after updating to 0.24.1 I get the following error for the site.pp: Could not parse for environment development: No file(s) found for import of

On Feb 17, 2009, at 2:21 PM, Scott Michel wrote: > - remove trailing whitespace, > - expand tabs to spaces, I'd argue for not changing anything, just fail it.

On Tue, Feb 17, 2009 at 2:35 PM, Mike Stump <mrs at apple.com> wrote: > On Feb 17, 2009, at 2:21 PM, Scott Michel wrote: > > - remove trailing whitespace, > > - expand tabs to spaces, > > I'd argue for not changing anything, just fail it. > Trimming whitespace is innocuous, at best. Expanding tabs to spaces, I might be inclined to agree is a 'fail' since

On Feb 17, 2009, at 2:46 PM, Scott Michel wrote: > Trimming whitespace is innocuous, at best. Unless you're doing a testcase that wants to verify a feature.

On Feb 20, 2009, at 12:45 PM, Misha Brukman wrote: > I've been fixing things on a directory-by-directory basis as I come > across style violations while browsing the code. I'm not in favor > of a single global change to fix everything everywhere; I think > this can be done gradually over time and the diff will be easier to > read if it's smaller, so you can

It would appear that commits no longer trigger emails; for Rcpp at least we are two commits (made earlier today) ahead of what was emailed. Maybe the mail agent needs to be restarted? Many thanks for taking care of r-forge. It is appreciated. Dirk -- Dirk Eddelbuettel | edd at debian.org | http://dirk.eddelbuettel.com

Hi Mailman daemon wasn't running, not sure yet why. The good news is that it appears that mailman is running through the built up queue, so everyone should get the mails they should have received Best regards Martin On 15 September 2013 at 13:30, Dirk Eddelbuettel wrote: | | It would appear that commits no longer trigger emails; for Rcpp at least we | are two commits (made earlier

On a related note, I wrote a few scripts to detect and correct some types of such style errors, see llvm/utils/lint/* . I also added a function to llvm/utils/vim/vimrc to delete trailing whitespace and highlight existing trailing whitespace -- if anyone's an Emacs-lisp hacker, please add it to the emacs config file as well. Sure, this doesn't enforce anything, but I'm hoping folks

On Fri, Jan 08, 2010 at 05:04:17PM -0800, Chris Lattner wrote: > On Jan 8, 2010, at 5:01 PM, Julien Lerouge wrote: > >Hello, > > > >The CodeExtractor contains a std::set<BasicBlock*> to keep track > >of the > >blocks to extract. Iterators on this set are not deterministic, and so > >the functions that are generated are not (the order of the >

On Dec 23, 2009, at 6:26 PM, Julien Lerouge wrote: > Hello folks, > > The makefile for 177.mesa says that for a small problem size, it will > get 100 frames. But in the spec sources I have, the test folder only > contains numbers for 10 frames: > > $ speccpu2000/benchspec/CFP2000/177.mesa/data $ wc -l test/input/ > numbers > 10 test/input/numbers > >

Hi everyone, I''m using a svn pre-commit hook to check manifests for syntax errors. I''ve recently upgraded puppet from 0.22.4 to 0.23.2 and the hook stopped working. I use the following command to parse .pp files: /usr/local/bin/puppet --confdir=/tmp --vardir=/tmp --parseonly --ignoreimport /tmp/$$.pp Now, I make a decision based on the exit code. If 0 then commit, else exit

On Jan 8, 2010, at 5:01 PM, Julien Lerouge wrote: > Hello, > > The CodeExtractor contains a std::set<BasicBlock*> to keep track of > the > blocks to extract. Iterators on this set are not deterministic, and so > the functions that are generated are not (the order of the > inputs/outputs can change). > > The attached patch uses a SetVector instead. Ok to apply ?

I know someone completed this but I''m not sure the hows and whats of it. Can someone put up a doc or email about this?

On Wed, Feb 25, 2009 at 10:26:02AM -0800, Chris Lattner wrote: > > On Feb 24, 2009, at 10:03 PM, Julien Lerouge wrote: > > > On Tue, Feb 24, 2009 at 06:24:17PM -0800, Julien Lerouge wrote: > >> I haven't tested with objdir != srcdir. > > > > Ok, that was broken. Attached is a smaller diff that should work in > > all > > cases. > > This