On Tue, Feb 17, 2009 at 2:35 PM, Mike Stump <mrs at apple.com> wrote:> On Feb 17, 2009, at 2:21 PM, Scott Michel wrote: > > - remove trailing whitespace, > > - expand tabs to spaces, > > I'd argue for not changing anything, just fail it. >Trimming whitespace is innocuous, at best. Expanding tabs to spaces, I might be inclined to agree is a 'fail' since weird formatting can result. 80-col violations are absolutely a 'fail'. -scooter -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20090217/1d7dfed3/attachment.html>
On Feb 17, 2009, at 2:46 PM, Scott Michel wrote:> On Tue, Feb 17, 2009 at 2:35 PM, Mike Stump <mrs at apple.com> wrote: > On Feb 17, 2009, at 2:21 PM, Scott Michel wrote: > > - remove trailing whitespace, > > - expand tabs to spaces, > > I'd argue for not changing anything, just fail it. > > Trimming whitespace is innocuous, at best. Expanding tabs to spaces, > I might be inclined to agree is a 'fail' since weird formatting can > result. 80-col violations are absolutely a 'fail'.I'd recommend just making everything be a fail. -Chris -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20090217/e67b292f/attachment.html>
On Feb 17, 2009, at 2:46 PM, Scott Michel wrote:> Trimming whitespace is innocuous, at best.Unless you're doing a testcase that wants to verify a feature.
All I'm hoping for is a clean diff. Fail commits for trailing whitespace if they're source? Easy to detect .ll files. On Tue, Feb 17, 2009 at 2:52 PM, Mike Stump <mrs at apple.com> wrote:> On Feb 17, 2009, at 2:46 PM, Scott Michel wrote: > > Trimming whitespace is innocuous, at best. > > Unless you're doing a testcase that wants to verify a feature. > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20090217/b1a422d2/attachment.html>