similar to: [LLVMdev] svn pre-commit hook: help needed

On Tue, Feb 17, 2009 at 02:21:23PM -0800, Scott Michel wrote: > Anyone out there interested in helping out with a subversion pre-commit hook > to: > > - remove trailing whitespace, > - expand tabs to spaces, > - detect 80-col violations, > > as well as detect other style guideline breakage? > > I just ran into the trailing whitespace problem: Eclipse and other

On Feb 18, 2009, at 1:41 AM, Julien Lerouge wrote: > Yet another _fun_ way of doing this is to setup a buildbot slave just > for that. The slave can fix minor stuff like tabs and trailing > whitespaces on its own (checking the changes back in), and yell for > things like 80-col violations and whatnot where the changes would > not be > so trivial. If you're going to change

On Feb 17, 2009, at 2:21 PM, Scott Michel wrote: > - remove trailing whitespace, > - expand tabs to spaces, I'd argue for not changing anything, just fail it.

On Tue, Feb 17, 2009 at 2:35 PM, Mike Stump <mrs at apple.com> wrote: > On Feb 17, 2009, at 2:21 PM, Scott Michel wrote: > > - remove trailing whitespace, > > - expand tabs to spaces, > > I'd argue for not changing anything, just fail it. > Trimming whitespace is innocuous, at best. Expanding tabs to spaces, I might be inclined to agree is a 'fail' since

For the complete truth in advertising, this was pretty much a trial balloon to gauge reaction. I'm not a big fan of rejecting commits for style violations, but the dev guide has certain guidelines regarding formatting and style. And we're all supposed to be good citizens... My biggest nit, however, was contemplating a commit where 80%+ was trailing whitespace trimming. Yeah, my editor

On a related note, I wrote a few scripts to detect and correct some types of such style errors, see llvm/utils/lint/* . I also added a function to llvm/utils/vim/vimrc to delete trailing whitespace and highlight existing trailing whitespace -- if anyone's an Emacs-lisp hacker, please add it to the emacs config file as well. Sure, this doesn't enforce anything, but I'm hoping folks

On Feb 20, 2009, at 12:45 PM, Misha Brukman wrote: > I've been fixing things on a directory-by-directory basis as I come > across style violations while browsing the code. I'm not in favor > of a single global change to fix everything everywhere; I think > this can be done gradually over time and the diff will be easier to > read if it's smaller, so you can

> On Feb 18, 2009, at 1:41 AM, Julien Lerouge wrote: > > > Yet another _fun_ way of doing this is to setup a buildbot slave just > > for that. The slave can fix minor stuff like tabs and trailing > > whitespaces on its own (checking the changes back in), and yell for > > things like 80-col violations and whatnot where the changes would > > not be > > so

On Feb 17, 2009, at 2:46 PM, Scott Michel wrote: > Trimming whitespace is innocuous, at best. Unless you're doing a testcase that wants to verify a feature.

On Wed, Jul 30, 2008 at 11:32:18AM -0700, Bill Wendling wrote: > On Jul 30, 2008, at 11:17 AM, Julien Lerouge wrote: >> ../../../llvm-gcc4.2-src/gcc/libgcc2.c:2095: error: conflicting types >> for 'VirtualProtect' >> >> c:/cygwin/home/jlerouge/buildbot/llvm/lib/../include/winbase.h:1998: >> error: previous declaration of 'VirtualProtect' was here

Hello folks, I have a small piece of C code written like this: typedef struct { char a; int b; int c; } foo; foo myFoo[5] = {{0}}; With llvm-gcc 2.5, I get the following IR: %struct.foo = type { i8, i32, i32 } @myFoo = global [5 x %struct.foo] zeroinitializer, align 32 With the current 2.6, I get this: %0 = type { i8, [11 x i8] }

Up to now, the tests have been running with whitespace stripped out. Newlines and tabs are insignificant in HTML, so I figured why bother with them? Now I realize why: they''re significant in pre tags and they also make your code look pretty! I''ve been working to get SRC output to roughly match Tetxile2''s as far as tabs and newlines go. It''s tough and

Hello folks, The makefile for 177.mesa says that for a small problem size, it will get 100 frames. But in the spec sources I have, the test folder only contains numbers for 10 frames: $ speccpu2000/benchspec/CFP2000/177.mesa/data $ wc -l test/input/numbers 10 test/input/numbers Generating 100 frames causes undefined behaviour because the program is doing unchecked fscanf on that

On Feb 24, 2009, at 10:03 PM, Julien Lerouge wrote: > On Tue, Feb 24, 2009 at 06:24:17PM -0800, Julien Lerouge wrote: >> I haven't tested with objdir != srcdir. > > Ok, that was broken. Attached is a smaller diff that should work in > all > cases. This sounds really cool Julien! Two questions: 1) does it preserve the checking that the existing tcl stuff does, which

Hello, The CodeExtractor contains a std::set<BasicBlock*> to keep track of the blocks to extract. Iterators on this set are not deterministic, and so the functions that are generated are not (the order of the inputs/outputs can change). The attached patch uses a SetVector instead. Ok to apply ? Thanks, Julien -- Julien Lerouge PGP Key Id: 0xB1964A62 PGP Fingerprint: 392D 4BAD DB8B CE7F

Hello, I have the following sequence of passes (using --debug-pass=Structure): ... ModulePass Manager FunctionPass Manager Preliminary module verification Dominator Tree Construction Module Verifier MyModulePass0 MyAnalysis Basic CallGraph Construction MyModulePass1 MyAnalysis MyModulePass2 Basic CallGraph Construction Call Graph SCC Pass

Hello, The attached patch adds the jcheck target equivalent to make check, but that can run with a -j flag ($ make jcheck -jX). It does not interfere with the regular check, but rather builds on top of the check-one target: it first generates a list of tests to run using RunLLVMTests, and then run those tests according to the supplied -j flag, invoking the check-one target for each one of them.

On 05.06.2012 02:56, reed kotler wrote: > Just as an example, I picked totally at random, one c++ program to run > the google code style checker. > > There are clearly some valid points it found. I think it would good to > start to adapt this tool > or write a new tool to do style checking and to start to better > formalize the llvm rules. > > I ran it against

Hi, I am trying to find someone who has a building/working pre pr4572 revision of llvm-gcc working on Cygwin and/or MinGW32. Many thanks in advance, Aaron -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20090805/bbbfe6df/attachment.html>

Just as an example, I picked totally at random, one c++ program to run the google code style checker. There are clearly some valid points it found. I think it would good to start to adapt this tool or write a new tool to do style checking and to start to better formalize the llvm rules. I ran it against Target/Target.cpp Target.cpp:0: No copyright message found. You should have a line: