similar to: [LLVMdev] Warning in VirtualMem.cpp

ISSUE: The constant "3791650815" is too large to fit in a 32-bit signed integer. ACTION: Use the unsigned 32-bit integer constant "3791650815U" instead. -- Casey Carter Casey at Carter.net ccarter at uiuc.edu AIM: cartec69 -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: patch URL:

Statistic.cpp uses std::stable_sort without including <algorithm>. -- Casey Carter Casey at Carter.net ccarter at uiuc.edu AIM: cartec69 -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: patch URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20021027/4d75abdc/attachment.ksh>

Timer.cpp uses std::greater without including <functional>. -- Casey Carter Casey at Carter.net ccarter at uiuc.edu AIM: cartec69 -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: patch URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20021027/b70e3ac4/attachment.ksh>

PreSelection.cpp uses the form "++(ConstantExpr*)->op_begin()" in a couple of places: gcc2 considers this to be an illegal use of a constant reference (the temporary iterator) as an lvalue. Fix is to use "(ConstantExpr*)->op_begin() + 1" instead. -- Casey Carter Casey at Carter.net ccarter at uiuc.edu AIM: cartec69 -------------- next part -------------- An

Issue: GraphWriter includes <ostream>, which my gcc2 apparently thinks is <ostream.h>. Fix: Make a new <Support/ostream> that handles this discrepancy, ala <Support/hash_set>. -- Casey Carter Casey at Carter.net ccarter at uiuc.edu AIM: cartec69 -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: patch URL:

ISSUE: This code: %bob = type { int } int %alias() { %pbob1 = alloca %bob %pbob2 = getelementptr %bob* %pbob1 ;pbob2 aliases pbob1 %pbobel = getelementptr %bob* %pbob2, long 0, ubyte 0 %rval = load int* %pbobel ret int %rval } Crashes when run through opt -instcombine. InstCombiner visits instructions in reverse declaration order, but

Issue: STLExtras.h includes a class mapped_iterator that uses std::iterator_traits<> without including <iterator>. Fix: have STLExtras.h include Support/iterator. -- Casey Carter Casey at Carter.net ccarter at uiuc.edu AIM: cartec69 -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: patch URL:

DSGraph.h has a prototype in it with a std::string& parameter, but does not include <string>. -- Casey Carter Casey at Carter.net ccarter at uiuc.edu AIM: cartec69 -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: patch URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20021027/a98ab220/attachment.ksh>

The machinery around the bison call in the Makefile does not work for me. From the source file gram.yc, my bison (version 1.28) generates files gram.yc.tab.h and gram.yc.tab.c instead of gram.tab.cc and gram.tab.hc. My fix is to use the -o option to tell bison what to name the outputs. -- Casey Carter Casey at Carter.net ccarter at uiuc.edu AIM: cartec69 -------------- next part

ISSUE: line 474 of InstrSelectionSupport.cpp is a conditional expression of the form (<expr> ? (ConstantSInt*) : (ConstantUInt*)), which is an unholy mixture of pointer types. ACTION: Apply static_cast<Value*> to the two pointers, as the source intends. -- Casey Carter Casey at Carter.net ccarter at uiuc.edu AIM: cartec69 -------------- next part -------------- An embedded and

ISSUE: In Interpreter::getCurrentExecutablePath(), dladdr() is a Solarisism. Luckily, getCurrentExecutablePath isn't being currently used anywhere in lli. ACTION: Wrap the method contents with #ifdef __sun__ ... #else return ""; #endif. If this functionality is actually desired, it would be more portable to hack up main() to join getcwd() with basename(argv[0]) to find the

ISSUE: INT64_MAX undefined in InstrSelectionSupport.cpp and InstructionCombining.cpp. I'm not completely sure where INT64_MAX comes from on Solaris, but C99 says that INT64_MAX is defined in stdint.h, but, for C++, only if __STDC_LIMIT_MACROS is #defined. Solaris (at least in CSIL) unfortunately does not have stdint.h, but it does have the old inttypes.h - and so does Linux. ACTION: In

ISSUE: In CommandLine.h, gcc 2.96 thinks that the apply() template function, when called as: apply("Some text string", x) should be expanded to applicator<const char[n]>("Some text string", x) instead of applicator<char[n]>("Some text string", x). ACTION: Duplicate the template specialization for applicator<char[n]> as applicator<const

ISSUE: In Interpreter::executeInstruction(), _sys_siglistp is a Solarisism. ACTION: Replace _sys_siglistp[signo] with strsignal(signo) which is more portable, maybe POSIX? PATCH: Apply from llvm top-level directory with "patch -p0." -- Casey Carter Casey at Carter.net ccarter at uiuc.edu AIM: cartec69 -------------- next part -------------- An embedded and charset-unspecified text

ISSUE: getTimeRecord in lib/VMCore/Pass.cpp uses timeval and gettimeofday() without including sys/time.h. ACTION: Include sys/time.h. PATCH: Apply from llvm top-level directory with "patch -p0." -- Casey Carter Casey at Carter.net ccarter at uiuc.edu AIM: cartec69 -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: patch URL:

ISSUE: ExternalFunctions.cpp::lookupFunction() calls dlsym(RTLD_DEFAULT, ...). In glibc, dlfcn.h does not make RTLD_DEFAULT visible unless _GNU_SOURCE is #defined. Unlike the evil money-grubbing non-free software pigs at sun, the FSF is trying not to pollute the C namespace. ;) ACTION: Hack the Makefile to #define _GNU_SOURCE while compiling in tools/lli. Yes, I know that this is ugly.

ISSUE: Linux doesn't have any steenking SIGEMT signal, as referred to in lib/Support/Signals.cpp. ACTION: Wrap the use with a #ifdef SIGEMT / #endif. PATCH: Apply from llvm top-level directory with "patch -p0". -- Casey Carter Casey at Carter.net ccarter at uiuc.edu AIM: cartec69 -------------- next part -------------- An embedded and charset-unspecified text was scrubbed...

ISSUE: DSOs in Linux are created by "g++ -shared" instead of "g++ -G". ACTION: Compile with "g++ -shared" instead of "g++ -G", i.e., use the alternate definition of "MakeSO" in Makefile.common. PATCH: Apply from llvm top-level directory with "patch -p0". -- Casey Carter Casey at Carter.net ccarter at uiuc.edu AIM: cartec69

ISSUE: By default, symbols are not exported from an executable unless they are linked against a DSO. What this means is that dlopen()ed DSOs cannot link to symbols in the main executable unless that executable was linked with --export-dynamic. ACTION: Ensure that opt is linked with "-Wl,--export-dynamic" on the G++ command line by defining "ExportSymbols" in

ISSUE: Changing definitions in Makefile.common by hand from Solaris to Linux values offends me. ACTION: As a quick fix to this (i.e., w/o autoconf) I have separated out the different settings into new files Makefile.$(PLATFORM) in the top-level directory of llvm. A dirty hack to Makefile.common automatically includes the proper arch-specific file by setting PLATFORM to the output of uname.