similar to: Opus CMake build support for Apple frameworks

Hi Marcus, When building shared libraries for macOS / iOS /tvOS, by default `.dylib` shared libraries will be generated. With this patch `BUILD_FRAMEWORK` is exposed as an option allowing the user to specify that a `.framework` bundle should be built instead of a standalone `.dylib` file. Enabling the option sets the necessary target properties to instruct CMake to do this. The Ogg CMake build

Hi Simon, CMake 3.14 add support for crosscompiling iOS, tvOS and watchOS https://cmake.org/cmake/help/v3.14/manual/cmake-toolchains.7.html#cross-compiling-for-ios-tvos-or-watchos Can you clarify what your patch does? //Marcus cmake-toolchains(7) — CMake 3.14.7 Documentation<https://cmake.org/cmake/help/v3.14/manual/cmake-toolchains.7.html#cross-compiling-for-ios-tvos-or-watchos> The

Hi Simon, Please create a pull request here: https://github.com/xnorpx/opus/pulls Also please add a buildconfig here that exercise the BUILD_FRAMEWORK option: https://github.com/xnorpx/opus/blob/master/.github/workflows/build.yml [https://avatars2.githubusercontent.com/u/302709?s=400&v=4]<https://github.com/xnorpx/opus/blob/master/.github/workflows/build.yml>

Hi all, With some downtime it's time for some CMake fixes. Most critically is the SSE fixes to avoid crashes that is described in 154 and 132 in github. Patch 5 should address this and also adding APPROX-FLOAT option. Hopefully this can give some gains for those of us running on Windows servers.j I went through the pull request and picked out a few that will ease up integration for

Did the patch 5 split / AVX fix work get merged at all, I didn't see any more mails about it? Thanks! On Tue, 14 Jan 2020 at 21:34, Marcus Asteborg <xnorpx at outlook.com> wrote: > Awesome thanks! Good comments. > > Please apply patch 1-4 and I prepare another iteration on patch 5 for you > too look at. > > //Marcus > ------------------------------ > *From:*

Hi, Would you be interested in a patch to add CMake support to Opusfile? Opus already seems to have it, but I had to roll my own for Opusfile. I've attached a patch if you're interested, I've been using for a while now and it does what I need, it may not be exhaustive enough for wider distribution though. Hope it helps, Simon -------------- next part -------------- An HTML attachment

Here is the file which should manifest the issue. Simon Jackson Software Developer Sonocent Ltd. Tel: 0113 815 0223 www.sonocent.com <http://www.sonocent.com/> @AudioNotetaker <https://twitter.com/AudioNotetaker> > On 5 Nov 2015, at 21:29, Timothy B. Terriberry <tterribe at xiph.org> wrote: > > Simon Jackson wrote: >> packets split over page boundaries. I can

Hi, I seem to have found a bug with seeking in opusfile in some situations, though this might be better directed to the ogg list. I?ve included a short description below and a test case C program that describes it more detail (comments) and reproduces the issue when used with a file which contains packets that have been split over a page boundary (less common than I thought). The test program is

Hi Marcus, There seems to be a conflict between the autotools-created config.h.in and the same file added by your patch. Any way you can use use a different name? Cheers, Jean-Marc On 04/02/2019 01:39 AM, Marcus Asteborg wrote: > Hi, > > > Here is a proposal for adding CMake in addition of Autotools. > > > See the attached patch for changes or the pull request here:

Hi Christian Adam, Thanks for pointing this out, I made the necessary changes to account for this. So the behavior is as follows: * If no CMAKE_BUILD_TYPE is set and no CFLAGS are set it will default to Release. i.e ( cmake .. ) * If a developer want full control then use export CFLAGS in leave CMAKE_BUILD_TYPE empty. * If a developer want to test CFLAGS in combination with

Hi, Here is a proposal for adding CMake in addition of Autotools. See attached patch for changes or the pull request here: https://github.com/xiph/opus/pull/100 The CMake scripts are parsing the filelist from Autotools, so only one file list needs to be maintained. With this change the checked in Visual Studio solution can be removed and no longer need to be maintained and updated when

Thanks, it applies now. I think you'd also want to add some (all?) of these files to EXTRA_DIST in Makefile.am, otherwise your cmake files won't be included in release tarballs, which are generate using "make dist". To test, you should try running run "make dist" to generate a tarball yourself. From there, you try building the contents with your cmake files and see if

Hi, It looks like cmake currently defaults to no optimization, which I think is a bit unexpected for most users. I don't know how to do that in cmake, but it would be good to default to a "release" build with optimizations. Can you have a patch to do that? Also, is there a way to manually add flags to the compiler (like setting CFLAGS with autotools)? Cheers, Jean-Marc On

Hi Mark, Thanks for the feedback. By default CMake is building the static library in debug, to get other things one has to explicit turn it on. To build in release mode for CMake you use the following flag: -DCMAKE_BUILD_TYPE=Release https://cmake.org/cmake/help/latest/variable/CMAKE_BUILD_TYPE.html CMAKE_BUILD_TYPE — CMake 3.14.1

Hi, Here is a proposal for adding CMake in addition of Autotools. See the attached patch for changes or the pull request here: https://github.com/xiph/opus/pull/100 The CMake scripts are parsing the filelist from Autotools, so only one file list needs to be maintained. With this change the checked in Visual Studio solution can be removed and no longer need to be maintained and updated when

Hi, Thanks for the quick feedback I have changed the name to avoid conflict. Attached is the updated patch. //Marcus ________________________________ From: Jean-Marc Valin <jmvalin at jmvalin.ca> Sent: Tuesday, April 2, 2019 00:07 To: Marcus Asteborg; opus at xiph.org Subject: Re: [opus] CMake support for Opus proposal (in addition to Autotools) Hi Marcus, There seems to be a conflict

I tried the new cmake-based build system to build Opus on Linux and macOS. I'm not familiar with cmake but based on instructions I found online I used it as follows: - mkdir build - cd build - cmake -DCMAKE_INSTALL_PREFIX:PATH=<install-path> .. - make - ctest - make install Although the "make" command completed, it reported that optimizations were disabled:

Right that I had completely missed, I have added the files and verified that it builds with CMake from the tar on Linux (out of the git repo) I am parsing the package_version file from the tarball if it exists so it should maintain the version info. //Marcus ________________________________ From: Jean-Marc Valin <jmvalin at jmvalin.ca> Sent: Tuesday, April 2, 2019 11:38 To: Marcus

On Wed, Apr 10, 2019 at 5:30 PM Marcus Asteborg <xnorpx at outlook.com> wrote: > Hi Mark, > > Thanks for the feedback. > > By default CMake is building the static library in debug, to get other > things one has to explicit turn it on. > > Hi, By default CMake uses the "empty" build, which is used in combination with the environment variables CFLAGS and

Hi Ralph, Gentle reminder.. Regards, Rhishi -----Original Message----- From: Rhishikesh Agashe Sent: Friday, September 20, 2013 11:02 To: 'Ralph Giles' Subject: RE: [opus] Need info on optimizing Opus code for a particular core/processor Hi Ralph, Can you let me know how to submit my code for review? What is the procedure? Also, could you create an account for the same let me know