similar to: [PATCH] virt-v2v: Catch invalid initrd path

On Tuesday, October 08, 2013 10:05:17 AM Matthew Booth wrote: > Feel free to remove ^$path. However, for robustness I ditch the leading > ^ from your replacement. The difference will be down to a different > version of file included in the libguestfs appliance on SUSE. I think I've addressed all the concerns you raised in the following patch. Can you take a look and let me know if

The following series of patches adds support for converting SUSE guests through virt-v2v. These changes should not impact non-SUSE guest conversions. Mike Latimer (4): Add perl-Bootloader support to grub packages Add conversion support for SUSE guests Add SUSE to capabilities db and conf Add SUSE support documentation lib/Sys/VirtConvert/Converter/Linux.pm | 480

In preparation for an upcoming patch which adds support for SUSE guest conversions, it makes sense to have an intermediate steps that changes the RedHat.pm converter into a more generic Linux converter. The SUSE changes will then be limited in scope to only what is required for SUSE support. This series of patches accomplishes the following: - Renames RedHat.pm to Linux.pm - Modifies Linux.pm

Mike, This is great. I have a couple of minor comments inline, but this looks good. I do have a major concern, though, which is this is basically a fork of RedHat.pm. There are well over 1,000 identical lines of code between the 2 modules. Many of the differences are relatively minor, and could be handled with additional cases. I've also fixed a couple of bits in RedHat.pm since you forked

This is a new conversion module to convert SUSE Linux and openSUSE guests. The converter is based on the RedHat module, and should offer the same functionality on both SUSE and RedHat hosts. There are a few additional messages in this module, such as reporting of packages when installing through zypper or the local virt-v2v repo. These messages don't necessarily flow unless verbose switches

This is a proposed patch which changes the RedHat.pm converter to Linux.pm, and adds support for SUSE guest conversion. This is first approach recommended by Matt Booth in: https://www.redhat.com/archives/libguestfs/2013-September/msg00076.html Some aspects of this patch still need additional testing, and a couple of changes are not foolproof (such as the lack of grub2 support in the menu.lst

On Friday, October 11, 2013 04:57:32 PM Mike Latimer wrote: > I think I've addressed all the concerns you raised in the following patch. > Can you take a look and let me know if I've created any new ones? ;) Other than the concern about being a little too obsessed about the 79 character line length. ;) This version of the patch has all the unecessary cleanup removed, and only

This change is part of an ongoing effort to remove use of $desc and inspect the OS directly as required during conversion. --- lib/Sys/VirtConvert/Connection/LibVirtTarget.pm | 4 +- lib/Sys/VirtConvert/Connection/RHEVTarget.pm | 41 +++++++++--------- lib/Sys/VirtConvert/Converter.pm | 35 ++++++++++++---- lib/Sys/VirtConvert/Converter/RedHat.pm | 45

The SUSE converter itself, based on the RedHat converter. This supports converting SLES 10/11 and openSUSE 10/11/12/13. --- MANIFEST | 1 + lib/Sys/VirtConvert/Converter/SUSE.pm | 2527 +++++++++++++++++++++++++++++++++ 2 files changed, 2528 insertions(+) diff --git a/MANIFEST b/MANIFEST index 3724fde..615ec32 100644 --- a/MANIFEST +++ b/MANIFEST @@ -17,6 +17,7

On Friday, October 04, 2013 09:38:58 AM Matthew Booth wrote: > It's specifically an error if we're attempting to configure virtio, and > there's no detected virtio kernel. It shouldn't have been possible to > get here in that state, hence it's a programmer error. The code below > attempts to install *any* kernel in the case that we aren't configuring >

Matt, Thanks for the extensive comments. I'll go through them in detail, but it won't be until next week. For the time being, here's a quick take on some of the main issues: > I do have a major concern, though, which is this is basically a fork of > RedHat.pm. There are well over 1,000 identical lines of code between the > 2 modules. Many of the differences are relatively

This patch fixes an incorrect integer comparison that results in the following error: Argument "/files/boot/grub/menu.lst/title[1]/kernel" isn't numeric in numeric gt (>) at /usr/share/perl5/vendor_perl/Sys/VirtConvert/Converter/RedHat.pm line 206. This problem is not fatal, but it can result in duplicate entries in menu.lst. --- lib/Sys/VirtConvert/Converter/RedHat.pm | 2

Thanks, Mike. ACK to all of these, and pushed. As it happens, I'd already started breaking some of this stuff out myself when I found this patchset :/ Rather than redo it, I've kept what I'd already done and rebased on top of it. I also did some testing and fixed a couple of bugs: "/files$grub->{grub_conf}*/kernel/root" should have been "/files

From: "Richard W.M. Jones" <rjones at redhat.com> This is the default since libguestfs 1.6. It does not need to be explicitly set. See also https://bugzilla.redhat.com/show_bug.cgi?id=799798#c6 --- lib/Sys/VirtConvert/GuestfsHandle.pm | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/lib/Sys/VirtConvert/GuestfsHandle.pm

'distro' isn't used anywhere for Windows guests. However, if it's set, it's required to be matched in virt-v2v.conf. Rather than have to update the config again, just don't set it for Windows guests. --- lib/Sys/VirtConvert/Converter.pm | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/lib/Sys/VirtConvert/Converter.pm

The $vmdk value is a directory name in ESX.pm, although the later codes replace '/' with '_', the volume name isn't still friendly, for example, it looks like this: # virsh vol-list pool-dir Name Path ----------------------------------------- esx4.1-rhel6.2-x86_64_esx4.1-rhel6.2-x86_64

--- lib/Sys/VirtConvert/Converter/Windows.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Sys/VirtConvert/Converter/Windows.pm b/lib/Sys/VirtConvert/Converter/Windows.pm index 765ed9f..59d273f 100644 --- a/lib/Sys/VirtConvert/Converter/Windows.pm +++ b/lib/Sys/VirtConvert/Converter/Windows.pm @@ -338,7 +338,7 @@ sub _prepare_virtio_drivers

Although not fatal, _unconfigure_xenpv should report a warning and return if firstboot is not available (during Windows conversions). --- lib/Sys/VirtConvert/Converter/Windows.pm | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/lib/Sys/VirtConvert/Converter/Windows.pm b/lib/Sys/VirtConvert/Converter/Windows.pm index 59d273f..ce8b474 100644 --- a/lib/Sys/VirtConvert/Converter/Windows.pm

Hi! I'm trying to convert some Xen guests running Centos 5.8 to KVM on Centos 6.3. Hopefully this is the right place to ask this question, if not, let me know and I'll go there instead! :) My setup: Centos 5.8 Host running Xen with a Centos 5.8 guest, and I want to transfer this guest to a different Centos 6.3 host running KVM. I am able to tweak the target server all I want, but the

During a Windows conversion, _prepare_virtio_drivers aborts the conversion completely if the configured virtio driver path does not exist. If the path exists but is empty, the conversion completes correctly by defaulting to the non-virtio drivers. This patch treats a missing directory just like missing drivers, by reporting a message, then defaulting to non-virtio drivers. ---