Mike Latimer
2013-Sep-03 23:43 UTC
[Libguestfs] [PATCH] virt-v2v: Fix 'isn't numeric in numeric gt' error in grub check (RHBZ#974441)
This patch fixes an incorrect integer comparison that results in the following error: Argument "/files/boot/grub/menu.lst/title[1]/kernel" isn't numeric in numeric gt (>) at /usr/share/perl5/vendor_perl/Sys/VirtConvert/Converter/RedHat.pm line 206. This problem is not fatal, but it can result in duplicate entries in menu.lst. --- lib/Sys/VirtConvert/Converter/RedHat.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Sys/VirtConvert/Converter/RedHat.pm b/lib/Sys/VirtConvert/Converter/RedHat.pm index 36345e7..f1d3b98 100644 --- a/lib/Sys/VirtConvert/Converter/RedHat.pm +++ b/lib/Sys/VirtConvert/Converter/RedHat.pm @@ -247,7 +247,7 @@ sub check my $grub_path = $1; # Nothing to do if the kernel already has a grub entry - return if $g->aug_match("/files$grub_conf/title/kernel[. = '$grub_path']")> 0;+ return if $g->aug_match("/files$grub_conf/title/kernel[. = '$grub_path']") ne ''; my $kernel Sys::VirtConvert::Converter::RedHat::_inspect_linux_kernel($g, $path); -- 1.8.1.4