similar to: [PATCH] tests: change noinst to check

Make the tests 'check_DATA' so they only get built when running the tests. This saves a couple of seconds on the build time. --- ocaml/Makefile.am | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ocaml/Makefile.am b/ocaml/Makefile.am index e781363..a535b43 100644 --- a/ocaml/Makefile.am +++ b/ocaml/Makefile.am @@ -142,9 +142,9 @@ endif TESTS = run-bindtests

Current master fails to build if certain systemd functionality is not available at build time, daemon/journal.c has OPTGROUP_SD_JOURNAL_NOT_AVAILABLE at the end of the file. Is this a typo, what should be done in that case?

We would like to have a more flexible way to run tests, including running them on an installed copy of libguestfs, running them in parallel, and being able to express dependencies and ordering between tests and data files properly. Therefore introduce a test harness (test-harness) program which can run tests either from the locally built copy, or from an installed copy of the tests (in

This has got to the stage where it actually works, both for running the tests in-tree and installed. The 'test-harness' script has become rather over-complex in the process however. Rich.

We would like to have a more flexible way to run tests, including running them on an installed copy of libguestfs, running them in parallel, and being able to express dependencies and ordering between tests and data files properly. Therefore introduce a test harness (test-harness) program which can run tests either from the locally built copy, or from an installed copy of the tests (in

We would like to have a more flexible way to run tests, including running them on an installed copy of libguestfs, running them in parallel, and being able to express dependencies and ordering between tests and data files properly. Therefore introduce a test harness (test-harness) program which can run tests either from the locally built copy, or from an installed copy of the tests (in

Fix typo in OPTGROUP_JOURNAL_NOT_AVAILABLE Define empty journal_finalize, called by mount.c Signed-off-by: Olaf Hering <olaf@aepfle.de> --- daemon/journal.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/daemon/journal.c b/daemon/journal.c index 0cb50e3..97e1874 100644 --- a/daemon/journal.c +++ b/daemon/journal.c @@ -216,6 +216,11 @@

After the upgrade from 1.20.9 to .10 my libguestfs package fails to build because qemu-img is not installed. Since qemu is not a hard requirement to build a package I wonder how to fix the tests/data rules so that the targets which call qemu-img depend on "make test" or whatever requires the generated files. Olaf

Hi, I've created a shared library from including this code (with g++ -I/usr/local/lib/R/include -I/usr/local/include -c Rtest.cpp; g++ -shared -L/usr/local/lib -o Rtest.so Rtest.cpp): void check_data (SEXP data) { int l=length (data); } But when I try to load it in R I get this error message: unable to load shared library ... ... undefined symbol: _Z9Rf_lengthP7SEXPREC How can I solve

Add makefile variables to enable silent rules for simple command invocations, such as ocamlc, ocamlopt, javac, and erlc. This reduces the log output when building with silent rules, still showing the full command lines otherwise. --- erlang/Makefile.am | 2 +- java/Makefile.am | 6 +++--- ocaml/Makefile.am | 14 +++++++------- subdir-rules.mk | 20 +++++++++++++++++--- 4 files changed,

In case the appliance is disabled at configure, then all the phony guests will not be built during the 'make check' time. Since the tests already handle an empty windows.vmdk fine (in case ntfs-3g is not available), then just create it empty in this case. Reported by: Martin Kletzander. --- v2v/Makefile.am | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/v2v/Makefile.am

Changes: tools/blktap: remove unneeded pointer dereferencing in convert_dev_name_to_num tools/blktap: constify string arrays in convert_dev_name_to_num tools/blktap: fix params and physical-device parsing tools/blktap: remove unneeded pointer dereferencing from img2qcow.c tools/blktap: remove unneeded pointer dereferencing from qcow2raw.c tools/blktap2: fix build errors caused by Werror in

'make distcheck' calls us out for leaving files behind after 'make distclean' that were not present in the tarball. Either these files are expensive enough that end users should not be required to regenerate them (so they should be distributed), or they should be cleaned when a user asks to get back to the pristine tarball state. Automake suggests this hierarchy of cleaning:

On 4/23/20 2:13 PM, Richard W.M. Jones wrote: > Compiling nbdkit from source when an older nbdkit is installed would > fail because certain symbols such as .get_ready are not defined in the > (installed) <nbdkit-plugin.h>: > > ../../src/libguestfs.org/nbdkit/nbdkit.go:541:8: plugin.get_ready undefined (type _Ctype_struct_nbdkit_plugin has no field or method get_ready) >

By adding common CLEANFILES and DISTCLEANFILES variables to common-rules.mk, we can remove these from most other Makefiles, and also clean files more consistently. Note that bin_PROGRAMS are already cleaned by 'make clean', so I removed cases where these were unnecessarily added to CLEANFILES. --- .gitignore | 1 + Makefile.am | 6

You have to use: ../libguestfs/run ./configure ../libguestfs/run make Use of the second ../libguestfs/run against make is unfortunate but I believe it's unavoidable due to the way that ocamlfind works. --- .gitignore | 1 + ocaml/Makefile.am | 19 ++++++++++++++++++- run.in | 2 ++ 3 files changed, 21 insertions(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore

When compiling when an older nbdkit is installed, the build would fail because certain symbols such as .get_ready were not defined: ../../src/libguestfs.org/nbdkit/nbdkit.go:541:8: plugin.get_ready undefined (type _Ctype_struct_nbdkit_plugin has no field or method get_ready) This happens because we were using the installed <nbdkit-plugin.h> rather than the local copy. We don't want

Compiling nbdkit from source when an older nbdkit is installed would fail because certain symbols such as .get_ready are not defined in the (installed) <nbdkit-plugin.h>: ../../src/libguestfs.org/nbdkit/nbdkit.go:541:8: plugin.get_ready undefined (type _Ctype_struct_nbdkit_plugin has no field or method get_ready) Of course we should be compiling against the local include/nbdkit-plugin.h

These changes allow virt-v2v to be compiled against the build directory of a non-installed libguestfs. Note that some small changes are also required to common and virt-v2v itself. I will post those separately. Rich.

# HG changeset patch # User Olaf Hering <olaf@aepfle.de> # Date 1331924173 -3600 # Node ID bf1d5778ffd10858b402068b9473e410791ebd07 # Parent 72e6530b29463f0913af365f5d085d94ff75627c tools: specify datadir for qemu-xen build to fix firmware loading qemu-xen does currently not find the firmware files, such as vgabios-cirrus.bin. The reason is that qemu-xen uses the default prefix /usr/local.