similar to: [PATCH] vhost/scsi: use vmalloc for order-10 allocation

Hello. On 09/17/2013 11:21 AM, Michael S. Tsirkin wrote: > As vhost scsi device struct is large, if the device is > created on a busy system, kzalloc() might fail, so this patch does a > fallback to vzalloc(). > As vmalloc() adds overhead on data-path, add __GFP_REPEAT > to kzalloc() flags to do this fallback only when really needed. > Reported-by: Dan Aloni <alonid at

On Sun, Aug 18, 2013 at 12:18:38PM +0300, Michael S. Tsirkin wrote: > On Sun, Aug 18, 2013 at 11:48:56AM +0300, Dan Aloni wrote: > > On 3.10.7 and x86_64, as a result of sizeof(struct vhost_scsi) being > > 2152960 bytes the allocation failed once on my development machine. > > > > Saw it would be prudent to split the bulk of it, which is the vqs array > > into

On Sun, Aug 18, 2013 at 12:18:38PM +0300, Michael S. Tsirkin wrote: > On Sun, Aug 18, 2013 at 11:48:56AM +0300, Dan Aloni wrote: > > On 3.10.7 and x86_64, as a result of sizeof(struct vhost_scsi) being > > 2152960 bytes the allocation failed once on my development machine. > > > > Saw it would be prudent to split the bulk of it, which is the vqs array > > into

Now that we have kvfree, use it in vhost-scsi instead of the open-coded version. Cc: Nicholas Bellinger <nab at linux-iscsi.org> Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- I have this queued for -rc2. Nicholas could you review ack pls? drivers/vhost/scsi.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/vhost/scsi.c

Now that we have kvfree, use it in vhost-scsi instead of the open-coded version. Cc: Nicholas Bellinger <nab at linux-iscsi.org> Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- I have this queued for -rc2. Nicholas could you review ack pls? drivers/vhost/scsi.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/vhost/scsi.c

Signed-off-by: Joe Perches <joe at perches.com> --- drivers/video/arcfb.c | 5 ++--- drivers/video/broadsheetfb.c | 4 +--- drivers/video/hecubafb.c | 5 ++--- drivers/video/metronomefb.c | 4 +--- drivers/video/xen-fbfront.c | 3 +-- 5 files changed, 7 insertions(+), 14 deletions(-) diff --git a/drivers/video/arcfb.c b/drivers/video/arcfb.c index

Signed-off-by: Joe Perches <joe at perches.com> --- drivers/video/arcfb.c | 5 ++--- drivers/video/broadsheetfb.c | 4 +--- drivers/video/hecubafb.c | 5 ++--- drivers/video/metronomefb.c | 4 +--- drivers/video/xen-fbfront.c | 3 +-- 5 files changed, 7 insertions(+), 14 deletions(-) diff --git a/drivers/video/arcfb.c b/drivers/video/arcfb.c index

Resubmittal of patches from November 2010 and a few new ones. Joe Perches (15): s390: Convert vmalloc/memset to vzalloc x86: Convert vmalloc/memset to vzalloc atm: Convert vmalloc/memset to vzalloc drbd: Convert vmalloc/memset to vzalloc char: Convert vmalloc/memset to vzalloc isdn: Convert vmalloc/memset to vzalloc md: Convert vmalloc/memset to vzalloc media: Convert

Resubmittal of patches from November 2010 and a few new ones. Joe Perches (15): s390: Convert vmalloc/memset to vzalloc x86: Convert vmalloc/memset to vzalloc atm: Convert vmalloc/memset to vzalloc drbd: Convert vmalloc/memset to vzalloc char: Convert vmalloc/memset to vzalloc isdn: Convert vmalloc/memset to vzalloc md: Convert vmalloc/memset to vzalloc media: Convert

Resubmittal of patches from November 2010 and a few new ones. Joe Perches (15): s390: Convert vmalloc/memset to vzalloc x86: Convert vmalloc/memset to vzalloc atm: Convert vmalloc/memset to vzalloc drbd: Convert vmalloc/memset to vzalloc char: Convert vmalloc/memset to vzalloc isdn: Convert vmalloc/memset to vzalloc md: Convert vmalloc/memset to vzalloc media: Convert

On Tue, May 05, 2020 at 05:46:44PM +0200, David Hildenbrand wrote: > On 05.05.20 17:44, Michael S. Tsirkin wrote: > > On Tue, May 05, 2020 at 04:50:13PM +0200, David Hildenbrand wrote: > >> On 05.05.20 16:15, kbuild test robot wrote: > >>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost > >>> head:

On Tue, May 05, 2020 at 05:46:44PM +0200, David Hildenbrand wrote: > On 05.05.20 17:44, Michael S. Tsirkin wrote: > > On Tue, May 05, 2020 at 04:50:13PM +0200, David Hildenbrand wrote: > >> On 05.05.20 16:15, kbuild test robot wrote: > >>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost > >>> head:

On Wed, 18 Apr 2018, Eric Dumazet wrote: > > > On 04/18/2018 07:34 AM, Mikulas Patocka wrote: > > The patch 74d332c13b21 changes alloc_netdev_mqs to use vzalloc if kzalloc > > fails (later patches change it to kvzalloc). > > > > The problem with this is that if the vzalloc function is actually used, > > virtio_net doesn't work (because it expects

On Wed, 18 Apr 2018, Eric Dumazet wrote: > > > On 04/18/2018 07:34 AM, Mikulas Patocka wrote: > > The patch 74d332c13b21 changes alloc_netdev_mqs to use vzalloc if kzalloc > > fails (later patches change it to kvzalloc). > > > > The problem with this is that if the vzalloc function is actually used, > > virtio_net doesn't work (because it expects

On Tue, May 05, 2020 at 04:50:13PM +0200, David Hildenbrand wrote: > On 05.05.20 16:15, kbuild test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost > > head: da1742791d8c0c0a8e5471f181549c4726a5c5f9 > > commit: 7527631e900d464ed2d533f799cb0da2b29cc6f0 [8/22] virtio-mem: Paravirtualized memory hotplug > > config:

On Tue, May 05, 2020 at 04:50:13PM +0200, David Hildenbrand wrote: > On 05.05.20 16:15, kbuild test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost > > head: da1742791d8c0c0a8e5471f181549c4726a5c5f9 > > commit: 7527631e900d464ed2d533f799cb0da2b29cc6f0 [8/22] virtio-mem: Paravirtualized memory hotplug > > config:

Am 15.07.2015 13:28, schrieb Michael S. Tsirkin: > On Wed, Jul 15, 2015 at 02:16:59PM +0300, Dan Carpenter wrote: >> There is only one caller for vhost_kvzalloc() and it expects NULL on >> allocation failure. Most people would probably expect that so let's >> change ERR_PTR(-ENOMEM) to NULL. >> >> Fixes: 4de7255f7d2b ('vhost: extend memory regions

Am 15.07.2015 13:28, schrieb Michael S. Tsirkin: > On Wed, Jul 15, 2015 at 02:16:59PM +0300, Dan Carpenter wrote: >> There is only one caller for vhost_kvzalloc() and it expects NULL on >> allocation failure. Most people would probably expect that so let's >> change ERR_PTR(-ENOMEM) to NULL. >> >> Fixes: 4de7255f7d2b ('vhost: extend memory regions

tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost head: da1742791d8c0c0a8e5471f181549c4726a5c5f9 commit: 7527631e900d464ed2d533f799cb0da2b29cc6f0 [8/22] virtio-mem: Paravirtualized memory hotplug config: x86_64-randconfig-b002-20200505 (attached as .config) compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0 reproduce: git checkout

tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost head: da1742791d8c0c0a8e5471f181549c4726a5c5f9 commit: 7527631e900d464ed2d533f799cb0da2b29cc6f0 [8/22] virtio-mem: Paravirtualized memory hotplug config: x86_64-randconfig-b002-20200505 (attached as .config) compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0 reproduce: git checkout