similar to: SYSAPPEND not replacing spaces

To remind you once again. ISOLINUX >= 6.00 built with GCC >= 5.0.0 causes a broken boot. This relates specifically to the use of the vesamenu.c32, menu.c32 works without problemos. This "code" is already in 6.03, therefore this is not a fix for it! Revert "SYSAPPEND: Fix space stripping" This reverts commit 3106dcd http://repo.or.cz/w/syslinux.git/commit/3106dcd Fixes

On 03.07.2015 12:28, Gene Cumm wrote: > On Fri, Jul 3, 2015 at 12:50 AM, poma via Syslinux <syslinux at zytor.com> wrote: > >> - "unsigned char c;" does not solve the problem >> >> - "c >= 0 && c <= ' '" solves the problem for the current git > > Could you try the following patch? Feel free to only apply the change

On 07/01/2015 01:35 AM, poma via Syslinux wrote: > > diff --git a/com32/elflink/ldlinux/readconfig.c b/com32/elflink/ldlinux/readconfig.c > index 381b43f..dcdf91b 100644 > --- a/com32/elflink/ldlinux/readconfig.c > +++ b/com32/elflink/ldlinux/readconfig.c > @@ -330,7 +330,7 @@ static char *copy_sysappend_string(char *dst, const char *src) > char c; > > while

On Fri, Jul 3, 2015 at 12:50 AM, poma via Syslinux <syslinux at zytor.com> wrote: > - "unsigned char c;" does not solve the problem > > - "c >= 0 && c <= ' '" solves the problem for the current git Could you try the following patch? Feel free to only apply the change to readconfig.c if you want. -- -Gene diff --git

On 02.07.2015 11:10, Thomas Schmitt wrote: > Hi, > > poma wrote: >> - if (c <= ' ' || c == '\x7f') { >> + if (c <= ' ' && c == '\x7f') { > > As Geert Stappers pointed out (and can be verified by a > simple test program), the reinstated term > (c <= ' ' && c == '\x7f') >

Hi, Ady wrote: > IMHO, the adequate way to solve the problem is finding why vesamenu.c32 > triggers a problem when it is compiled with gcc v.5+. I agree. Currently i am riddling why copy_sysappend_string() should be invoked at all. txt/syslinux.cfg.txt obviously describes the .cfg interface of readconfig.c:record() as "SYSAPPEND" and its flag values. Rawhide-Live-Xfce-628.iso

On Tue, Jun 30, 2015 at 4:29 PM, poma <pomidorabelisima at gmail.com> wrote: > "A real serial port that can reliably operate at 115200 8n1 may be > necessary." > > Gene, is there something special in "A real serial port" usage, compared to emulated? I should restate: A serial port that responds on BIOS IO port 3F8h that can reliably operate at 115200 8n1 may

On 02.07.2015 23:12, Thomas Schmitt wrote: > Hi, > > hpa wrote: >> On PowerPC (I think) "unsigned char" is the default. > > In any case it seems a good idea to interpret the character > more explicitely. To my experience, one signdness change causes > a little tree of consequential signedness changes or questionable > cast operations. > How about the

Hi, hpa wrote: > On PowerPC (I think) "unsigned char" is the default. In any case it seems a good idea to interpret the character more explicitely. To my experience, one signdness change causes a little tree of consequential signedness changes or questionable cast operations. How about the following instead ? if ((c >= 0 && c <= ' ') || c == '\x7f')

Hi, poma wrote: > - if (c <= ' ' || c == '\x7f') { > + if (c <= ' ' && c == '\x7f') { As Geert Stappers pointed out (and can be verified by a simple test program), the reinstated term (c <= ' ' && c == '\x7f') evaluates always as false, because ('\x7f' <= ' ') is false. So it is

On 02.07.2015 01:28, Gene Cumm wrote: > On Wed, Jul 1, 2015 at 10:14 AM, poma <pomidorabelisima at gmail.com> wrote: >> On 01.07.2015 12:10, Gene Cumm wrote: >>> On Wed, Jul 1, 2015 at 4:35 AM, poma <pomidorabelisima at gmail.com> wrote: >>>> >>>> To remind you once again. >>>> ISOLINUX >= 6.00 built with GCC >= 5.0.0 causes a

core and the simple menu do not interpret the IPAPPEND/SYSAPPEND directives in the same way. Which is the proper way? Either way, this should be clarified in the documentation. com32/elflink/ldlinux/readconfig.c: } else if ((ep = looking_at(p, "ipappend")) || (ep = looking_at(p, "sysappend"))) { uint32_t s = strtoul(skipspace(ep), NULL,

On Sun, Jun 23, 2013 at 11:09 PM, Gene Cumm <gene.cumm at gmail.com> wrote: > On Sun, Jun 23, 2013 at 11:06 PM, Gene Cumm <gene.cumm at gmail.com> wrote: >> core and the simple menu do not interpret the IPAPPEND/SYSAPPEND >> directives in the same way. Which is the proper way? Either way, >> this should be clarified in the documentation. > > To be clear:

On Sun, Jun 23, 2013 at 11:06 PM, Gene Cumm <gene.cumm at gmail.com> wrote: > core and the simple menu do not interpret the IPAPPEND/SYSAPPEND > directives in the same way. Which is the proper way? Either way, > this should be clarified in the documentation. To be clear: core treats the value as always hexidecimal while simple menu treats it as decimal unless a 0x prefix is

On Sun, Jun 23, 2013 at 3:16 PM, Gerardo Exequiel Pozzi <vmlinuz386 at yahoo.com.ar> wrote: > I guess the bug is here (com32/menu/readconfig.c) > > 910 } else if (looking_at(p, "ipappend") || looking_at(p, > "sysappend")) { > 911 if (ld.label) > 912 ld.ipappend = atoi(skipspace(p + 8)); > 913

On 06/13/2013 11:06 PM, Gerardo Exequiel Pozzi wrote: > On 06/13/2013 10:15 PM, Gene Cumm wrote: >> On Thu, Jun 13, 2013 at 8:08 PM, Gerardo Exequiel Pozzi >> <vmlinuz386 at yahoo.com.ar> wrote: >>> Hello >>> >>> While testing PXE booting, I decided to change IPAPPEND to the new >>> SYSAPPEND and does not work: nothing is appended to command

On Sun, Jun 23, 2013 at 8:24 PM, Gene Cumm <gene.cumm at gmail.com> wrote: > On Sun, Jun 23, 2013 at 3:16 PM, Gerardo Exequiel Pozzi > <vmlinuz386 at yahoo.com.ar> wrote: >> I guess the bug is here (com32/menu/readconfig.c) >> >> 910 } else if (looking_at(p, "ipappend") || looking_at(p, >> "sysappend")) { >> 911

The following changes since commit 022cdd1d56512e8759e8374c10a7420201db93c0: Matt Fleming (1): cli: don't disable linewrap when redrawing the cmdline are available in the git repository at: git://github.com/geneC/syslinux.git menu-ipappend-1-for-mfleming Gene Cumm (1): menu.c32: Fix SYSAPPEND com32/menu/readconfig.c | 8 +++++--- 1 files changed, 5 insertions(+), 3

On Sun, 23 Jun, at 11:21:45PM, Gene Cumm wrote: > Correction: simple menu always does decimal (as should be expected). > > >> com32/elflink/ldlinux/readconfig.c: > >> } else if ((ep = looking_at(p, "ipappend")) || > >> (ep = looking_at(p, "sysappend"))) { > >> uint32_t s = strtoul(skipspace(ep),

On Thu, Jul 2, 2015 at 1:32 AM, poma <pomidorabelisima at gmail.com> wrote: > On 02.07.2015 01:28, Gene Cumm wrote: >> On Wed, Jul 1, 2015 at 10:14 AM, poma <pomidorabelisima at gmail.com> wrote: >>> On 01.07.2015 12:10, Gene Cumm wrote: >>>> On Wed, Jul 1, 2015 at 4:35 AM, poma <pomidorabelisima at gmail.com> wrote: >>>>>