similar to: [PATCH] Btrfs: fix typo in send.c

On Thu, Jan 10, 2013 at 11:57:25AM +0300, Dan Carpenter wrote: > The closing parenthesis is in the wrong place. We want to check > "sizeof(*arg->clone_sources) * arg->clone_sources_count" instead of > "sizeof(*arg->clone_sources * arg->clone_sources_count)". > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Original message id:

This fixes bugzilla 57491. If we take a snapshot of a fs with a unlink ongoing and then try to send that root we will run into problems. When comparing with a parent root we will search the parents and the send roots commit_root, which if we''ve just created the snapshot will include the file that needs to be evicted by the orphan cleanup. So when we find a changed extent we will try

This patch adds the flag, BTRFS_SEND_FLAG_NO_FILE_DATA to the btrfs send ioctl code. When this flag is set, the btrfs send code will never write file data into the stream (thus also avoiding expensive reads of that data in the first place). BTRFS_SEND_C_UPDATE_EXTENT commands will be sent (instead of BTRFS_SEND_C_WRITE) with an offset, length pair indicating the extent in question. This patch

First two patches are trivial cleanups that I''ve spotted while reading send.c, can be applied independently. The third patch contains the important bits, safety checks that the subvolumes involved in send do not accidentally lose the RO status. I haven''t seen this documented anywhere that this is mandatory, implied from how I assume send works. Please let me know if this is

This commit adds a command line option to enable sending streams which make use of the new end-cmd semantic if multiple snapshots are sent back-to-back. The goal is to use the <end cmd> as an indication to stop reading the input stream. So far, the receiver could only use EOF to recognize the end. If the new command line option ''-e'' is set, this commit requires a kernel

From: Mark Fasheh <mfasheh@suse.de> btrfs-progs: re-add send-test send-test.c links against libbtrfs and uses the send functionality provided to decode and print a send stream to the console. 66819df "btrfs-progs: add send-test" contained this file when submitted, but somehow got lost on commit. [sandeen@redhat.com: Resurrect lost send-test.c from original commit]

=================================================================== "Change is such hard work." Billy Crystal =================================================================== Release Announcements ===================== This is is the latest stable release of Samba 3.6. Major enhancements in Samba 3.6.7 include: o Fix resolving our own "Domain Local" groups

=================================================================== "Change is such hard work." Billy Crystal =================================================================== Release Announcements ===================== This is is the latest stable release of Samba 3.6. Major enhancements in Samba 3.6.7 include: o Fix resolving our own "Domain Local" groups

==================================================================== "Laughter is inner jogging." Norman Cousins ==================================================================== Release Announcements ===================== This is is the latest stable release of Samba 3.6. Major enhancements in Samba 3.6.8 include: o Fix crash bug in smbd caused by a blocking lock

==================================================================== "Laughter is inner jogging." Norman Cousins ==================================================================== Release Announcements ===================== This is is the latest stable release of Samba 3.6. Major enhancements in Samba 3.6.8 include: o Fix crash bug in smbd caused by a blocking lock

Hello there, I just ran the sourceforge tool cppcheck over the source code of the new Linux kernel 2.6.32.4 It said 1. [./btrfs/free-space-cache.c:600]: (style) Redundant condition. It is safe to deallocate a NULL pointer The source code is                 if (info->bitmap)                         kfree(info->bitmap); I agree with cppcheck. Suggest delete the if test. 2.

Hello there, dovecot-2.2.32/src/doveadm/doveadm-mail-fetch.c:130]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses. Source code is if ((ret = doveadm_print_istream(input) < 0)) Maybe better code if ((ret = doveadm_print_istream(input)) < 0) Some duplicates: [dovecot-2.2.32/src/doveadm/doveadm-mail-fetch.c:220]: (style) Suspicious

On Mon, Jul 20, 2009 at 3:33 PM, Arjen de Korte<adkorte-guest at alioth.debian.org> wrote: > Author: adkorte-guest > Date: Mon Jul 20 19:33:33 2009 > New Revision: 1866 > > Log: > Resolve naming conflict Arjen, should drivers/Makefile.am be changed from: virtual_SOURCES = virtual.c to: clone_SOURCES = clone.c as well? -- - Charles Lepple

https://bugzilla.netfilter.org/show_bug.cgi?id=1149 Bug ID: 1149 Summary: xtables-eb.c:533: bad test ? Product: netfilter/iptables Version: unspecified Hardware: x86_64 OS: All Status: NEW Severity: enhancement Priority: P5 Component: ip_tables (kernel) Assignee:

Hello there, dovecot-2.2.33/src/lib/str-find.c:86]: (warning) Calling 'sizeof' on 'sizeof' Source code is ctx = p_malloc(pool, MALLOC_ADD(sizeof(struct str_find_context), MALLOC_MULTIPLY(sizeof(ctx->goodtab[0]), key_len))); Regards David Binderman

Hello there, Offending source code is ????? if(? ( BattVoltage> 129 ) || ( BattVoltage < 144 ) ) Maybe swap || for && would be better. This problem I found by using cppcheck. It said [rhino.c:190]: (warning) Logical disjunction always evaluates to true: BattVoltage> 129 || BattVoltage < 144. Regards David Binderman

Hello there, I just ran the static analysis checker "cppcheck" over the source code of icecast version 2.3.3 Amongst many other things, it said [log.c:301]: (warning) Logical conjunction always evaluates to false: log_id < 0 && log_id>= 25. Source code is ??? if (log_id < 0 && log_id>= LOG_MAXLOGS) ??????? return; Suggest replace && with ||.

On Tue, Jan 8, 2013 at 6:45 PM, Chris Lattner <clattner at apple.com> wrote: > some version of GCC and later (linux folks should pick?) 4.6 is the official compiler on Ubuntu 12.04 (released 04/2012), which is the latest Long Term Support release (which come out every 2 years, with 3 years desktop support and 5 years server support), so I wouldn't push farther than that on Linux for

On Jan 8, 2013, at 4:26 PM, Jeffrey Yasskin <jyasskin at googlers.com> wrote: >> Another thing to bring up is that we have a lot of classes which have >> method pairs `foo_begin()` and `foo_end()` (e.g. >> `Function::arg_{begin,end}()`). These don't play nice with range-for >> loops (we are already seeing this come up in LLD). We probably should >> adopt

Dear All, Please see the short script at the end of the email, which I assembled looking for bits and pieces on the web. It essentially does what I need: it plots several countries as a color-coded map. I just would like to fine-tune a bit the final image, in particular (1) Select my own colors for "painting" the countries (i.e. associate manually a color to every level) (2) Be