Displaying 20 results from an estimated 10000 matches similar to: "number_to_currrency formats negative numbers incorrectly"
2010 Apr 18
1
Add shorthand support for routes like /projects/status(.:format)
Hi, when trying to migrate Signal to Rails 3 I tried to use the shorthand
route for:
match ''/projects/status(.:format)''
but it thrown an error because the controller was not specified. This
happend because actually the shorthand routes only work with routes without
optional parameters. The modification to support routes ending with a
optional parameters is very simple, as can
2010 Jun 09
1
[patch] fix bytesize in exception template; multibyte titleize
Hi all,
I wanted to draw some attention to a couple of very small multibyte-related
patches I believe should be included before Rails 3.0 RC1:
* Use String#bytesize rather than String#length in exception templates:
This is a simple case where string length is checked, but bytes is needed,
so it breaks with string with multibyte chars.
2010 Nov 01
1
[patch] Allowing to_xml to rename keys in lower camel case format
Hi all,
I''ve created and submitted a patch to resolve an issue I had while
attempting to meet the OpenSocial API specifications, which dictates that
the xml output have tags formatted as lower camelcase (as opposed to upper
camelcase, which is currently the only option). With this patch, simply
passing :camelize => true still begets the current behavior, but you can now
enable lower
2010 Dec 07
0
A couple of patches
I''ve submitted a couple of patches in Ligththouse.
Provide NoStore implementation of ActiveSupport::Cache::Store
This patch provides a NoStore implementation of
ActiveSupport::Cache::Store suitable for use in development and test
environments where the code need to use the cache interface, but
actually caching data is not desired.
2010 Apr 05
2
Harmonizing JSON/XML serialization
The way Rails handles root nodes in JSON and XML serialization is
inconsistent. This has been discussed before:
https://rails.lighthouseapp.com/projects/8994/tickets/2584-232-activeresource-json-doesnt-send-parameters-with-root-node
This seems mostly taken care of with
ActiveModel::Base.include_root_in_json, especially if/when it ends up
in ActiveResource. However, there is also the issue of how
2011 Mar 18
1
ActiveResource: prefix attributes that are mass assigned are not readable - Stale ?
Hi,
I noticed that 2 days ago that this ticket was marked "stale".
https://rails.lighthouseapp.com/projects/8994/tickets/6171
But the issue is still here (I checked just now), and it reminded me I
had a patch for it I forgot to submit, so I attached the patch file to
the ticket.
Since I''m still new on this, can someone please point me the right
procedure ? Should I have
2010 Mar 20
1
[PATCH] AR migration generator includes model's modules in table name. [#4230]
Hello! Could someone review the patch attached to [1] and provide
feedback?
Briefly, it targets rails 3, and fixes "rails g model admin/post".
The generated migration creates a "admin_posts" table while the model
expects a table simply named "posts". With the patch, the migration
creates "posts".
Thank you!
--phil--
[1]
2010 Jun 18
1
[PATCH] option_groups_from_collection_for_select should produce an HTML-safe string
Can somebody please review my ticket:
https://rails.lighthouseapp.com/projects/8994/tickets/4879
It''s a trivial bugfix ("option_groups_from_collection_for_select
should produce an HTML-safe string") before RC, I think.
Cheers,
Wincent
--
You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group.
To post to this group,
2010 Sep 23
1
Patch to fix docs for auto_link
Hi I''ve contributed a patch which fixes an incorrect example in the
documentation for auto_link in ActionView::Helpers::TextHelper.
The example uses truncate in the old style of tuncate(text, length)
which no longer works, so I''ve patched it to use the new
tuncate(text, :length => n) style.
2010 Sep 23
1
[patch] Properly memoize protected methods
This patch fixes an issue with protected methods becoming public if
they are memoized.
Looking for +1''s and/or a commit by core...
https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/5695
Thanks.
--
You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group.
To post to this group, send email to
2010 May 14
1
select method on ActiveRecord::Relation brakes enumeration
class Brake
scope :good, where(:quality => ''good'')
end
Brake.all.select &:nil? #=> works fine
Brake.good.select &:nil? #=> FAILS
Last statement fails because Brake.good.select is returning
ActiveRecord::Relation and not an array.
I have posted a detailed discussion on ticket #4589 .
2010 Oct 25
1
A few fixes to eager loading issues
Hey all,
I''d really appreciate some eyes on https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/5845-activerecord-3-eager-loading-fail#ticket-5845-19. There''s a small issue in Rails 3 eager loading, and this ticket has an accompanying patch.
Sssociations that show up twice in a Relation chain like:
Article.includes(:comments).includes(:comments =>
2010 Oct 11
2
my first patch ... what now? simple 1 word change
Hi everyone,
I just created my first rails patch. It is a simple textile doc
error requiring only a single word to be changed.
https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/5779
I uploaded a .diff file.
Not sure what to do now but lighthouse guide says I should ask on here
for someone to take a look.
Thank you for your time,
fooledbyprimes
Peoria, Illinois, USA
--
2011 Feb 28
0
Patch for serious nil response bug when Action caching responses that are not cacheable
Hi guys,
I''ve fixed a pretty annoying bug in Action caching that is detailed
here:
https://rails.lighthouseapp.com/projects/8994/tickets/6480-action-cache-filter-code-incorrectly-renders-nil-response-body-if-response-is-non-cacheable
Would appreciate testers or a direct commit if it checks out :)
Cheers,
Chu Yeow
--
You received this message because you are subscribed to the Google
2011 Feb 28
3
Feature: ActiveResource - Adding associations through reflections
Hello everyone,
I''m new in contributing and i saw in the contributing-guides, that i
have to write an email at this list.
I hope, that''s the right place for this. If it''s not, i''M really
sorry.. ;)
Could someone please give me feedback about this lighthouse-ticket?
2010 May 05
2
Add method to get at captured content_for
In Rails 3 the only way to get for content captured with the
content_for method in a view is to call yield from within a view.
However, sometimes is it useful to get to this data from within a
helper (for instance to provide a default value). Calling yield from
within the helper method won''t work, and accessing the @_content_for
variable directly is not encouraged.
Proposed solution: add
2010 Jul 02
3
Ticket #5038 ActiveResource not handling updates correctly
https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/5038-activeresource-not-handling-updates-correctly
I just added this ticket. I''m writing a Sinatra API to be consumed by
Rails and I''ve run into an issue where the ActiveResource
documentation specifies that on update you should return an HTTP 204
status with no body. The problem is that Rack doesn''t
2010 Jan 22
3
Release date for Rails 2.3.6?
Hello guys,
I went into milestones page (https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/milestones) and found out that Rails 2.3.6 was due Jan 15, 2010. Does it mean all tickets in that milestone should be cleared first?
If so, then I would pay attention to clear tickets in that bucket first.
Thank you,
Prem Sichanugrist (sikachu)
--
You received this message because you are
2010 Apr 12
2
[PATCH] Access to more Arel predicate types from where condition hash
I could use some eyes on https://rails.lighthouseapp.com/projects/8994/tickets/4368
if anyone has the time.
Summary of the change:
Similar to PredicateBuilder''s existing support for ''table.column'' =>
''value'', this patch enables ''column#method'' => ''value''.
For instance,
2010 Jun 18
0
i18n routes and resource names problem
Hi,
I recently tried to adopt localized resource names usage, in
particular using the http://github.com/kwi/i18n_routing plugin, but
faced a problem with HTML escaped non ANSI characters in route names.
I''ve created a ticket to track this down:
https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/4896
The problem was introduced with