similar to: Patch review request: improvements to lazy-loaded sessions and session reset behavior

Hello, How can I get anyone to review a patch I posted to this (stalled) issue: https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/3271 ? -- Regards, Alex -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send

A Rails 2.3.9 app with Active Record or Memcache session store will never send the session ID cookie to a client if the client doesn''t send any HTTP cookies in its requests. Rails integration tests didn''t catch this because they always send the HTTP_COOKIE header, even if it''s empty. This is a huge bug, as it can break keeping sessions on sites which don''t set

The jist: by avoiding "MyApp::Application" in config/routes.rb generator template, those generated config/routes.rb work out-of-box when turning the app into an engine. https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/4400-patch-avoid-app_const-when-drawing-routes-in-app-generator Thanks! --phil-- -- You received this message because you are subscribed to the

Hi all, I wanted to draw some attention to a couple of very small multibyte-related patches I believe should be included before Rails 3.0 RC1: * Use String#bytesize rather than String#length in exception templates: This is a simple case where string length is checked, but bytes is needed, so it breaks with string with multibyte chars.

Hi, when trying to migrate Signal to Rails 3 I tried to use the shorthand route for: match ''/projects/status(.:format)'' but it thrown an error because the controller was not specified. This happend because actually the shorthand routes only work with routes without optional parameters. The modification to support routes ending with a optional parameters is very simple, as can

Here are a couple of problems with the use of eval.parent(substitute(expr)) instead of just lazily evaluating expr in the .doTrace function used by trace. (a) In S+ I sometimes use trace() to see how long a function takes to run with a tracer expression the saves the start time and calls on.exit to report the difference between the start and end times when the trace function ends. E.g., >

I''ve submitted a couple of patches in Ligththouse. Provide NoStore implementation of ActiveSupport::Cache::Store This patch provides a NoStore implementation of ActiveSupport::Cache::Store suitable for use in development and test environments where the code need to use the cache interface, but actually caching data is not desired.

The way Rails handles root nodes in JSON and XML serialization is inconsistent. This has been discussed before: https://rails.lighthouseapp.com/projects/8994/tickets/2584-232-activeresource-json-doesnt-send-parameters-with-root-node This seems mostly taken care of with ActiveModel::Base.include_root_in_json, especially if/when it ends up in ActiveResource. However, there is also the issue of how

Hello all, I was wondering if there is an existing mechanism in Xen for restoring a saved/checkpointed VM lazily. By that, I mean that the pages of the VM should be mapped only on access. Currently, restoring a VM from a snapshot seems to take a long time [~20 seconds for 2 GB]. Assuming that there is no lazy-restore functionality, what would be a good way to implement this? Using parts

OK I have a very large zfs snapshot I want to destroy. When I do this, the system nearly freezes during the zfs destroy. This is a Sun Fire X4600 with 128GB of memory. Now this may be more of a function of the IO device, but let''s say I don''t care that this zfs destroy finishes quickly. I actually don''t care, as long as it finishes before I run out of disk space. So a

Hello, I''d like to ask for some feedback on a patch I just submitted. The patch improves the reliability of ActiveSupport::Inflector.transliterate, which currently does not handle many characters from Danish, Swedish, Icelandic, Polish and other European languages. This is because the current code relies upon UTF-8 decomposition, but many common characters do not in fact decompose to

+cc Artem, who added the LinkOnlyNeeded flag. On Wed, Apr 20, 2016 at 9:18 AM, Mehdi Amini via llvm-dev < llvm-dev at lists.llvm.org> wrote: > Hi Neil, > > On Apr 20, 2016, at 5:20 AM, Neil Henning via llvm-dev < > llvm-dev at lists.llvm.org> wrote: > > TL;DR - when linking from a lazily loaded module and using > Linker::LinkOnlyNeeded, bodies of used functions

Hi, I noticed that 2 days ago that this ticket was marked "stale". https://rails.lighthouseapp.com/projects/8994/tickets/6171 But the issue is still here (I checked just now), and it reminded me I had a patch for it I forgot to submit, so I attached the patch file to the ticket. Since I''m still new on this, can someone please point me the right procedure ? Should I have

Hello! Could someone review the patch attached to [1] and provide feedback? Briefly, it targets rails 3, and fixes "rails g model admin/post". The generated migration creates a "admin_posts" table while the model expects a table simply named "posts". With the patch, the migration creates "posts". Thank you! --phil-- [1]

Can somebody please review my ticket: https://rails.lighthouseapp.com/projects/8994/tickets/4879 It''s a trivial bugfix ("option_groups_from_collection_for_select should produce an HTML-safe string") before RC, I think. Cheers, Wincent -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group,

Hi all, I''ve created and submitted a patch to resolve an issue I had while attempting to meet the OpenSocial API specifications, which dictates that the xml output have tags formatted as lower camelcase (as opposed to upper camelcase, which is currently the only option). With this patch, simply passing :camelize => true still begets the current behavior, but you can now enable lower

Hi I''ve contributed a patch which fixes an incorrect example in the documentation for auto_link in ActionView::Helpers::TextHelper. The example uses truncate in the old style of tuncate(text, length) which no longer works, so I''ve patched it to use the new tuncate(text, :length => n) style.

This patch fixes an issue with protected methods becoming public if they are memoized. Looking for +1''s and/or a commit by core... https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/5695 Thanks. -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to

class Brake scope :good, where(:quality => ''good'') end Brake.all.select &:nil? #=> works fine Brake.good.select &:nil? #=> FAILS Last statement fails because Brake.good.select is returning ActiveRecord::Relation and not an array. I have posted a detailed discussion on ticket #4589 .

Extract the bit of code for lazy creation of a temporary directory, so it can be used for more directories as well. This is just code motion, with no behaviour changes. --- src/tmpdirs.c | 28 +++++++++++++++++----------- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git a/src/tmpdirs.c b/src/tmpdirs.c index 9154d8b..2ae9c74 100644 --- a/src/tmpdirs.c +++ b/src/tmpdirs.c @@ -119,6