similar to: [PATCH] windows: Fix creation of /Temp/V2V directory (RHBZ#868073).

We were unconditionally creating /temp/v2v in the guest, and later using case_sensitive_path to look the path up again. If C:\Temp already existed, this would lead to unpredictable results. Fixes RHBZ#672521 --- lib/Sys/VirtV2V/Converter/Windows.pm | 21 ++++++++++++++------- 1 files changed, 14 insertions(+), 7 deletions(-) diff --git a/lib/Sys/VirtV2V/Converter/Windows.pm

Fixes RHBZ#596238 --- lib/Sys/VirtV2V/Converter/Windows.pm | 57 +++++++++++++++------------------ 1 files changed, 26 insertions(+), 31 deletions(-) diff --git a/lib/Sys/VirtV2V/Converter/Windows.pm b/lib/Sys/VirtV2V/Converter/Windows.pm index 8de2bcd..e55d0f3 100644 --- a/lib/Sys/VirtV2V/Converter/Windows.pm +++ b/lib/Sys/VirtV2V/Converter/Windows.pm @@ -181,9 +181,8 @@ sub _preconvert

Currently when converting a Windows guest we do a minimum installation of the viostor driver, configure the RHEV guest agent and leave RHEV to properly install viostor and all remaining drivers. This works well if RHEV is properly configured and the installation is not interrupted on first boot. However, if the target of the conversion is not RHEV, RHEV is not properly configured, or the first

This change is part of an ongoing effort to remove use of $desc and inspect the OS directly as required during conversion. --- lib/Sys/VirtConvert/Connection/LibVirtTarget.pm | 4 +- lib/Sys/VirtConvert/Connection/RHEVTarget.pm | 41 +++++++++--------- lib/Sys/VirtConvert/Converter.pm | 35 ++++++++++++---- lib/Sys/VirtConvert/Converter/RedHat.pm | 45

From: "Richard W.M. Jones" <rjones at redhat.com> Don't assume that if guestfs_case_sensitive_path returns NULL, that it means the file does not exist. The (previously undefined) behaviour of case_sensitive_path was that a NULL return meant "either the file doesn't exist or some other error". However in commit 973581780d8a006f336684fef6762801402d775d this was

On Mon, Mar 13, 2017 at 11:48:05PM +0200, Keresztes Péter-Zoltán wrote: > Hello, > > We have a nodejs app which is injecting first boot scripts using virt-customize however the exact same commands are working when triggered manually. > > Here is the debug output of the commands Which version of virt-customize? A number of bugs were fixed in this part of the code in the last

I am running libguestfs version 1.34.2 The issue is the following. When I start the vm with virt-log I see this: Mar 13 17:33:30 multi6 firstboot.sh[358]: /usr/lib/virt-sysprep/firstboot.sh start Mar 13 17:33:30 multi6 cron[359]: (CRON) INFO (Running @reboot jobs) Mar 13 17:33:30 multi6 firstboot.sh[358]: Scripts dir: /usr/lib/virt-sysprep/scripts Mar 13 17:33:30 multi6 firstboot.sh[358]: ===

Hello, We have a nodejs app which is injecting first boot scripts using virt-customize however the exact same commands are working when triggered manually. Here is the debug output of the commands Regards, Peter [ 0.0] Examining the guest ... libguestfs: trace: set_network true libguestfs: trace: set_network = 0 libguestfs: trace: add_drive

On Friday, October 11, 2013 04:57:32 PM Mike Latimer wrote: > I think I've addressed all the concerns you raised in the following patch. > Can you take a look and let me know if I've created any new ones? ;) Other than the concern about being a little too obsessed about the 79 character line length. ;) This version of the patch has all the unecessary cleanup removed, and only

The following patch adds augeas_error to the Sys::VirtConvert::Util use statement for GrubLegacy (matching what is used in the Grub2 package). This is required to prevent an undefined subroutine error for the augeas_error call in list_kernels(). There are also a few minor typo fixups: - A message string in _configure_kernel was missing the $ before a variable - In _install_capability, the

On Tuesday, October 08, 2013 10:05:17 AM Matthew Booth wrote: > Feel free to remove ^$path. However, for robustness I ditch the leading > ^ from your replacement. The difference will be down to a different > version of file included in the libguestfs appliance on SUSE. I think I've addressed all the concerns you raised in the following patch. Can you take a look and let me know if

From: "Richard W.M. Jones" <rjones at redhat.com> This is the default since libguestfs 1.6. It does not need to be explicitly set. See also https://bugzilla.redhat.com/show_bug.cgi?id=799798#c6 --- lib/Sys/VirtConvert/GuestfsHandle.pm | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/lib/Sys/VirtConvert/GuestfsHandle.pm

This patch fixes an incorrect integer comparison that results in the following error: Argument "/files/boot/grub/menu.lst/title[1]/kernel" isn't numeric in numeric gt (>) at /usr/share/perl5/vendor_perl/Sys/VirtConvert/Converter/RedHat.pm line 206. This problem is not fatal, but it can result in duplicate entries in menu.lst. --- lib/Sys/VirtConvert/Converter/RedHat.pm | 2

'distro' isn't used anywhere for Windows guests. However, if it's set, it's required to be matched in virt-v2v.conf. Rather than have to update the config again, just don't set it for Windows guests. --- lib/Sys/VirtConvert/Converter.pm | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/lib/Sys/VirtConvert/Converter.pm

The $vmdk value is a directory name in ESX.pm, although the later codes replace '/' with '_', the volume name isn't still friendly, for example, it looks like this: # virsh vol-list pool-dir Name Path ----------------------------------------- esx4.1-rhel6.2-x86_64_esx4.1-rhel6.2-x86_64

--- lib/Sys/VirtConvert/Converter/Windows.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Sys/VirtConvert/Converter/Windows.pm b/lib/Sys/VirtConvert/Converter/Windows.pm index 765ed9f..59d273f 100644 --- a/lib/Sys/VirtConvert/Converter/Windows.pm +++ b/lib/Sys/VirtConvert/Converter/Windows.pm @@ -338,7 +338,7 @@ sub _prepare_virtio_drivers

Although not fatal, _unconfigure_xenpv should report a warning and return if firstboot is not available (during Windows conversions). --- lib/Sys/VirtConvert/Converter/Windows.pm | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/lib/Sys/VirtConvert/Converter/Windows.pm b/lib/Sys/VirtConvert/Converter/Windows.pm index 59d273f..ce8b474 100644 --- a/lib/Sys/VirtConvert/Converter/Windows.pm

Hi! I'm trying to convert some Xen guests running Centos 5.8 to KVM on Centos 6.3. Hopefully this is the right place to ask this question, if not, let me know and I'll go there instead! :) My setup: Centos 5.8 Host running Xen with a Centos 5.8 guest, and I want to transfer this guest to a different Centos 6.3 host running KVM. I am able to tweak the target server all I want, but the

SUSE VMDP comes with a replacement for rhsrvany.exe named pvvxsvc.exe. Check for either one of them instead of only rhsrvany. --- builder/virt-builder.pod | 13 +++- customize/firstboot.ml | 169 +++++++++++++++++++++++-------------------- customize/virt-customize.pod | 6 ++ sysprep/virt-sysprep.pod | 6 ++ v2v/virt-v2v.pod | 6 ++ 5 files changed, 117

During a Windows conversion, _prepare_virtio_drivers aborts the conversion completely if the configured virtio driver path does not exist. If the path exists but is empty, the conversion completes correctly by defaulting to the non-virtio drivers. This patch treats a missing directory just like missing drivers, by reporting a message, then defaulting to non-virtio drivers. ---