similar to: permit many-to-many vms / networks relationship redux

This patchset contains changes to the ovirt server frontend, backend, and tests components, permitting vms to be associated with multiple networks and vice versa. Also included are two patches which are required for the frontend bits; a patch adding collapsable sections to the vm form, which in itself depends on the second patch that provides default values for the cpu and memory vm table fields

- db, model, service, controller, and view changes - many tests additions - various fixes / cleanup to get things working depends on my last two (still unacked) patches: - add collapsable sections to vm form - provide default vm allocated cpu and memory values ovirt-agent might need to be updated to work with the changes --- src/app/controllers/pool_controller.rb | 2 +-

Signed-off-by: Scott Seago <sseago at redhat.com> --- src/app/services/vm_service.rb | 25 ++++++++++++++++--------- 1 files changed, 16 insertions(+), 9 deletions(-) diff --git a/src/app/services/vm_service.rb b/src/app/services/vm_service.rb index 4c29bcf..47ac5f5 100644 --- a/src/app/services/vm_service.rb +++ b/src/app/services/vm_service.rb @@ -52,15 +52,9 @@ module VmService def

From: Simon Courtois <scourtois at linagora.com> Signed-off-by: Simon Courtois <scourtois at linagora.com> --- src/app/controllers/vm_controller.rb | 19 ++++++++++++++++- src/app/views/vm/_form.rhtml | 25 ++++++++++++++++++++--- src/db/migrate/044_add_virtio_to_vm_and_nic.rb | 11 ++++++++++ src/public/stylesheets/components.css | 5

Previously, a pxe-booted vm would always boot to HD at next startup. Signed-off-by: Nicolas Ochem <nicolas.ochem at alcatel-lucent.com> --- src/app/controllers/vm_controller.rb | 1 + src/app/models/vm.rb | 15 +++++++++++---- src/app/views/vm/_form.rhtml | 2 +- src/task-omatic/taskomatic.rb | 13 +++++++++++-- 4 files changed, 24 insertions(+), 7

There was no release since virtio support was introduced, so a proper migration is not necessary. Signed-off-by: Nicolas Ochem <nicolas.ochem at gmail.com> --- src/app/controllers/vm_controller.rb | 6 ++- src/app/models/nic.rb | 2 + src/app/views/vm/_form.rhtml | 25 +++++++++------- src/db/migrate/046_add_model_to_nic.rb | 29 ++++++++++++++++++

There's still room for additional refactoring as we may want to eventually split out nic, bonding, and ip address manipulation into their own controller/svc module, but that would be a much more extensive redesign than we want to deal with for the overall service layer creation refactoring. Signed-off-by: Scott Seago <sseago at redhat.com> --- src/app/controllers/network_controller.rb

Signed-off-by: Simon COURTOIS <scourtois at linagora.com> --- src/app/controllers/vm_controller.rb | 16 ++++++++++++++ src/app/views/vm/edit_vmpool.rhtml | 36 ++++++++++++++++++++++++++++++++ src/app/views/vm/show.rhtml | 3 ++ src/public/images/icon_vmpool_11px.png | Bin 0 -> 542 bytes 4 files changed, 55 insertions(+), 0 deletions(-) create mode 100644

This patch fixes state changes in dbomatic so that there is no intermediate 'stopped' state after being unreachable or on startup of dbomatic etc. Also fixes a number of smaller bugs around host associations, state changes, etc. Signed-off-by: Ian Main <imain at redhat.com> --- src/db-omatic/db_omatic.rb | 85 +++++++++++++++++++++++++++++++------------- 1 files changed, 60

the vm form is getting cluttered, this patch simply add collapsable sections to the form, making the 'storage' and 'network' sections collapsed by default credit goes to jayg for contributing alot to this patch in terms of simplification and cleanup --- src/app/helpers/application_helper.rb | 4 +- src/app/views/vm/_form.rhtml | 35 ++++++++++++++++++++++----------

This is the new ovirt agent that implements the QMF API. This is just its humble beginnings. The goal was to implement the create VM method on VMs but it turns out we need to specify the VM pool in order to do that. This is currently hardcoded to '5' and works locally but would likely not work elsewhere. What does work well is listing/querying of existing VMs. There is still lots of

- changes to the form/style cleaning it up greatly - changes to the controller fixing allowing nics/ networks to actually be saved (credit to Michel Loiseleur for helping with this) - very small test and indentation fixes --- src/app/controllers/vm_controller.rb | 41 +++- src/app/views/vm/_form.rhtml | 365 ++++++++++++++---------------

fixes regression bug that got recently introduced --- src/app/models/network.rb | 2 ++ src/app/models/physical_network.rb | 2 -- src/app/models/vlan.rb | 2 -- 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/app/models/network.rb b/src/app/models/network.rb index a4b1b8b..89f9876 100644 --- a/src/app/models/network.rb +++

Provides a mechanism to generate ip addresses for static networks and prefill the 'ip address' fields of the host and vm networking forms w/ the first suggested ip. --- src/app/controllers/vm_controller.rb | 2 +- src/app/models/ip_address.rb | 52 +++++++++++++++++++++++++++++++++ src/app/models/network.rb | 11 +++++++ src/app/models/physical_network.rb |

Also includes a couple minor model changes to support better error reporting. This method was added so that a client could submit multiple vms to the service layer in one call and get back appropriate messages showing any failures without those failures also causing the entire call to fail, or forcing the client to implement handling (begin/rescue blocks) of these errors to continue through the

Signed-off-by: Simon Courtois <scourtois at linagora.com> --- src/task-omatic/taskomatic.rb | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/task-omatic/taskomatic.rb b/src/task-omatic/taskomatic.rb index 471ec88..1dfd74f 100755 --- a/src/task-omatic/taskomatic.rb +++ b/src/task-omatic/taskomatic.rb @@ -355,11 +355,10 @@ class TaskOmatic end end

Hi, is there a good reason why taskomatic check the number of real cores in the find_capable_host ? It prevents to use the full capacity of multithreading Signed-off-by: Arthur Clement <aclement at linagora.com> --- src/task-omatic/taskomatic.rb | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/task-omatic/taskomatic.rb b/src/task-omatic/taskomatic.rb index

Signed-off-by: Scott Seago <sseago at redhat.com> --- src/test/functional/host_controller_test.rb | 41 -------------------- .../functional/managed_node_configuration_test.rb | 14 ++++--- src/test/functional/nic_controller_test.rb | 8 ---- src/test/functional/permission_controller_test.rb | 15 ++++--- src/test/functional/quota_controller_test.rb | 2 +-

This resend includes the rebase, but fixes a problem I just noticed with nil/empty checks.

This is a resend of the 2-patch series from a week or so ago, needed to be rebased due to some commits on next